#metabrainz

/

      • ruaok
        k
      • 2021-10-11 28446, 2021

      • lucifer
        alastairp: ruaok: are join ON clauses benefitted by an index?
      • 2021-10-11 28431, 2021

      • ruaok
        not sure.
      • 2021-10-11 28433, 2021

      • lucifer
        wondering if we should add some index for this. https://github.com/metabrainz/listenbrainz-server…
      • 2021-10-11 28422, 2021

      • lucifer
        i know that optimizer can interchange where and join on clauses sometime so i hope that index would work on it but yeah unsure.
      • 2021-10-11 28426, 2021

      • ruaok
        one of the reasons I want to deploy to test is to make sure everything is ok.
      • 2021-10-11 28445, 2021

      • ruaok
        let me run some explains on gaga
      • 2021-10-11 28437, 2021

      • lucifer
        yup makes sense. that's usually how i test my PRs :). tests usually miss something which only shows up in the prod setup (not necessarily a good thing but works).
      • 2021-10-11 28455, 2021

      • zas
        lucifer: wait, why does it try to launch this container on kiss???
      • 2021-10-11 28429, 2021

      • zas
        gitzconsul is set to run on herb & kiki
      • 2021-10-11 28432, 2021

      • lucifer
        zas: possibly? not sure. it happens on when doing `. scripts/services.sh`
      • 2021-10-11 28408, 2021

      • zas
        do not run this!
      • 2021-10-11 28418, 2021

      • ruaok
      • 2021-10-11 28421, 2021

      • ruaok
        looks ok
      • 2021-10-11 28422, 2021

      • zas
        I guess you look for start_services.sh
      • 2021-10-11 28411, 2021

      • lucifer
        i used to do eariler . script/services.sh and alastairp too. if this is an issue, can change the workflow.
      • 2021-10-11 28412, 2021

      • zas
        services.sh is not meant to run (bad things can happen), actually this error is a good thing
      • 2021-10-11 28425, 2021

      • lucifer
        not running. sourcing it
      • 2021-10-11 28436, 2021

      • zas
        from ?
      • 2021-10-11 28443, 2021

      • lucifer
        in the shell directly
      • 2021-10-11 28453, 2021

      • zas
        so, no, not meant for that
      • 2021-10-11 28406, 2021

      • ruaok
        services.sh defines functions only, zas. it doesn't run any code.
      • 2021-10-11 28416, 2021

      • ruaok
        (function and consts)
      • 2021-10-11 28431, 2021

      • ruaok
        we've been using this to deploy containers for months now and it works fine.
      • 2021-10-11 28437, 2021

      • lucifer
      • 2021-10-11 28456, 2021

      • ruaok
        oh. that's not good.
      • 2021-10-11 28406, 2021

      • lucifer
      • 2021-10-11 28408, 2021

      • lucifer
        latest master.
      • 2021-10-11 28415, 2021

      • ruaok
        sounds like we need to do some coordinating on this stuff
      • 2021-10-11 28457, 2021

      • lucifer
        yeah.
      • 2021-10-11 28401, 2021

      • zas
        wtf
      • 2021-10-11 28414, 2021

      • lucifer
        that code looks errily similar to the one in the function though. maybe a leftover?
      • 2021-10-11 28426, 2021

      • zas
        I'll fix this, looks like code was copied where it shouldn't be
      • 2021-10-11 28438, 2021

      • lucifer
        makes sense. since all nodes scripts will be sourcing it too.
      • 2021-10-11 28419, 2021

      • zas
        pull again, it should be fixed
      • 2021-10-11 28430, 2021

      • ruaok goes shopping in anticipation of zas arriving
      • 2021-10-11 28438, 2021

      • zas
        not sure how this got in, but it was an error
      • 2021-10-11 28449, 2021

      • ruaok
        you arrive wednesday, zas? what time?
      • 2021-10-11 28456, 2021

      • zas
        yup, let me check
      • 2021-10-11 28412, 2021

      • lucifer
        yup works. thanks! :D
      • 2021-10-11 28434, 2021

      • zas
        16:53 BARCELONA SANTS
      • 2021-10-11 28446, 2021

      • ruaok
        k
      • 2021-10-11 28406, 2021

      • alastairp
        I'll be at officebrianz Thursday
      • 2021-10-11 28423, 2021

      • ruaok
        yay, Brian!
      • 2021-10-11 28436, 2021

      • alastairp
        he'll be there too
      • 2021-10-11 28418, 2021

      • lucifer
        ruaok: that explain looks good. thanks for checking!
      • 2021-10-11 28424, 2021

      • ruaok
      • 2021-10-11 28439, 2021

      • ruaok
        works fast too. there are no user visible features, but no errors I've found so far.
      • 2021-10-11 28423, 2021

      • lucifer
        nice
      • 2021-10-11 28451, 2021

      • akshat
        I finally added search facility to my mb web work🥲
      • 2021-10-11 28458, 2021

      • antlarr has quit
      • 2021-10-11 28432, 2021

      • reosarevok
        bitmap, yvanzo: we were supposed to release a beta today, right? We don't have a lot merged, does either of you want to review some more?
      • 2021-10-11 28438, 2021

      • reosarevok
        If so we could put it out tomorrow
      • 2021-10-11 28409, 2021

      • reosarevok
        yvanzo: https://github.com/metabrainz/musicbrainz-server/… seems ready to merge - if you want go for it, if you're not around I'll merge it myself before release
      • 2021-10-11 28415, 2021

      • bitmap
        for some reason I thought we were delaying the release since yvanzo was traveling, but I can review a few more things to get beta out
      • 2021-10-11 28433, 2021

      • reosarevok
        Oh, maybe we are? It wouldn't be a bad idea, anyway
      • 2021-10-11 28441, 2021

      • reosarevok
        So we can do that, although putting one beta out wouldn't hurt either
      • 2021-10-11 28443, 2021

      • bitmap
        I'll focus on y-young's PR's tho
      • 2021-10-11 28447, 2021

      • reosarevok
        More time to test :)
      • 2021-10-11 28449, 2021

      • reosarevok
        Sure!
      • 2021-10-11 28417, 2021

      • reosarevok
        Hmm. Wasn't search supposed to find an artist based on its artist credits?
      • 2021-10-11 28459, 2021

      • reosarevok
        I was expecting a search for "Manteca" to find "KIDDO" based on this AC https://beta.musicbrainz.org/artist-credit/3022767
      • 2021-10-11 28405, 2021

      • bitmap
        depends on which search field you use I guess
      • 2021-10-11 28425, 2021

      • reosarevok
        The standard search I meant, non-indexed
      • 2021-10-11 28425, 2021

      • reosarevok
        Seems they're completely ignored by artist search, in any case
      • 2021-10-11 28441, 2021

      • reosarevok
      • 2021-10-11 28410, 2021

      • bitmap
        non-advanced you mean? but yeah, looks like it's not considered in any case
      • 2021-10-11 28426, 2021

      • reosarevok
        Yeah, non-advanced
      • 2021-10-11 28434, 2021

      • reosarevok
        Damn, I've always thought it was
      • 2021-10-11 28407, 2021

      • lucifer
        bitmap: we started testing perf monitoring using sentry in LB today. might be useful in MB too. https://sentry-cloud.metabrainz.org/organizations…
      • 2021-10-11 28423, 2021

      • antlarr joined the channel
      • 2021-10-11 28455, 2021

      • bitmap
        lucifer: neat, that looks very useful. I assume the python client enables that somehow? I wonder if the perl raven clients are modern enough to do that...
      • 2021-10-11 28429, 2021

      • lucifer
        right, sentry's python sdk handles it all.
      • 2021-10-11 28447, 2021

      • lucifer
      • 2021-10-11 28416, 2021

      • bitmap
        yeah, just saw that
      • 2021-10-11 28418, 2021

      • yvanzo
        bitmap, reosarevok: will do some reviews after the meeting as well
      • 2021-10-11 28410, 2021

      • BrainzGit
        [listenbrainz-server] 14mayhem merged pull request #1655 (03master…add-mbids-to-listens): Add mbids from mapping to listens https://github.com/metabrainz/listenbrainz-server…
      • 2021-10-11 28436, 2021

      • reosarevok
        Thanks :)
      • 2021-10-11 28402, 2021

      • lucifer
        monkey: you and I updated snapshots at the same time lol. the error still persists though :/
      • 2021-10-11 28419, 2021

      • monkey
        Sorry about that :p
      • 2021-10-11 28439, 2021

      • monkey
        Want me to take a look? (he now asks before doing)
      • 2021-10-11 28449, 2021

      • lucifer
        yes please
      • 2021-10-11 28405, 2021

      • monkey
        👍
      • 2021-10-11 28409, 2021

      • lucifer
        thanks
      • 2021-10-11 28427, 2021

      • Freso
        <BANG>
      • 2021-10-11 28427, 2021

      • Freso
        It’s International Monay of the Girl Child!
      • 2021-10-11 28427, 2021

      • Freso
      • 2021-10-11 28439, 2021

      • Freso
        I have received one mailed in review, so… yyoung[m], go!
      • 2021-10-11 28442, 2021

      • Freso
        yyoung[m] says…
      • 2021-10-11 28442, 2021

      • ruaok
        monkey: MBIDs will soon be in listens. just merged that PR.
      • 2021-10-11 28443, 2021

      • Freso
        """
      • 2021-10-11 28451, 2021

      • CatQuest
        freso, what
      • 2021-10-11 28402, 2021

      • Freso
        CatQuest: ?
      • 2021-10-11 28414, 2021

      • CatQuest
        International Monay of the Girl Child :D
      • 2021-10-11 28428, 2021

      • Freso
        - Last week I opened a few tickets and looked at some others related to URL cleanup.
      • 2021-10-11 28428, 2021

      • Freso
        - Apart from that, I set up a local replication database of MusicBrainz to get a better view of the URL relationships, and improved my PR #2296.
      • 2021-10-11 28428, 2021

      • Freso
        - After spending some time exploring the data, I found a couple of issues and came up with several cleanup projects, now I'm considering writing a bot for them.
      • 2021-10-11 28428, 2021

      • Freso
        - That's all, thank you.
      • 2021-10-11 28429, 2021

      • Freso
        """
      • 2021-10-11 28447, 2021

      • Freso
      • 2021-10-11 28424, 2021

      • Freso
        Anyway.
      • 2021-10-11 28433, 2021

      • Freso
        Other people up for reviews: lucifer, reosarevok, ruaok,Freso, akshaaatt[m] , zas, alastairp, monkey, yvanzo, bitmap, CatQuest
      • 2021-10-11 28436, 2021

      • Freso
        lucifer: Go!
      • 2021-10-11 28439, 2021

      • lucifer
        hi all!
      • 2021-10-11 28416, 2021

      • lucifer
        i was afk for ~half of the week due to college work. other than that i worked on some small LB tasks. an improvement in LB recommended tracks, issue triaging, small UI bug fixes
      • 2021-10-11 28440, 2021

      • lucifer
        and earlier today helped alastairp in completing the sentry migration.
      • 2021-10-11 28444, 2021

      • lucifer
        that's it for me.
      • 2021-10-11 28447, 2021

      • lucifer
        alastairp: next?
      • 2021-10-11 28451, 2021

      • alastairp
        hi
      • 2021-10-11 28455, 2021

      • ruaok
        wooo that is done!
      • 2021-10-11 28410, 2021

      • alastairp
        I finished my work to convert JS in AB to typescript, thanks to monkey for answering all my questions about that. This is now deployed
      • 2021-10-11 28420, 2021

      • alastairp
        We decided to deploy a new version of sentry (more about this after reviews), and it's now running - just need to do a dns change, everything else will remain the same. lucifer has already started to use some neat new features like tracing and it looks cool!
      • 2021-10-11 28424, 2021

      • alastairp
        I responded to some old threads on the forums, and made some updates to the readme in troi
      • 2021-10-11 28440, 2021

      • alastairp
        we finished discussions on updates to the suggested listen format. I need to turn these discussions into documentation. I also took some time to analyse the format of data submitted in listens to see what people are submittin
      • 2021-10-11 28444, 2021

      • alastairp
        submitting
      • 2021-10-11 28446, 2021

      • alastairp
        In short: l.fm and spotify importers have submitted the most listens, other file-based submitters tend to send all metadata tags, there are really not many other submitter tools, and most of them only submit the bare minimum
      • 2021-10-11 28432, 2021

      • alastairp
        I also reviewed a PR by bitmap to update the base image for our python projects, that looks fine and we should be able to start using it soon
      • 2021-10-11 28439, 2021

      • alastairp
        reosarevok: next?
      • 2021-10-11 28411, 2021

      • Freso
        reosarevok: Ping?
      • 2021-10-11 28412, 2021

      • reosarevok
        Hi!
      • 2021-10-11 28413, 2021

      • CatQuest
        REO
      • 2021-10-11 28417, 2021

      • reosarevok
        Sorry, got up for a second :D
      • 2021-10-11 28420, 2021

      • reosarevok
        Well, a minute I guess
      • 2021-10-11 28433, 2021

      • CatQuest
        :P
      • 2021-10-11 28404, 2021

      • reosarevok
        So, this week I mostly worked on updating all the PRs for this milestone based on feedback
      • 2021-10-11 28416, 2021

      • reosarevok
        And on debugging a few issues with my PR removing unused variables and imports in our Perl files, where it turned out I removed a few variables too many at first because they used a specific perl wrapping technique that made them look unused to Perl::Critic
      • 2021-10-11 28425, 2021

      • reosarevok
        So the debugging of that took quite a bit and was confusing :)
      • 2021-10-11 28428, 2021

      • reosarevok
        Working now though
      • 2021-10-11 28445, 2021

      • reosarevok
        Today I did nothing because my laptop hinges were being replaced, more tomorrow! :)
      • 2021-10-11 28450, 2021

      • reosarevok
        CatQuest: what about you?
      • 2021-10-11 28401, 2021

      • CatQuest
        Meow! `😺`
      • 2021-10-11 28409, 2021

      • CatQuest
        Made mb work for me again!
      • 2021-10-11 28414, 2021

      • CatQuest
        Worked on instruments!
      • 2021-10-11 28429, 2021

      • CatQuest
        will continue with this this week!
      • 2021-10-11 28429, 2021

      • CatQuest
        also please check this community post to help some language alias if you can! https://community.metabrainz.org/t/call-for-help-…
      • 2021-10-11 28429, 2021

      • CatQuest
      • 2021-10-11 28429, 2021

      • CatQuest
        fin, go freso
      • 2021-10-11 28435, 2021

      • Freso
        o/
      • 2021-10-11 28446, 2021

      • CatQuest
        ...
      • 2021-10-11 28447, 2021

      • Freso
        I mostly poked at reports last week and was around and about for a bit, but I was also not feeling super great, so. :\ Feeling better but have an achy throat. :(
      • 2021-10-11 28453, 2021

      • Freso
        fin.
      • 2021-10-11 28401, 2021

      • Freso
        ruaok: Go!
      • 2021-10-11 28411, 2021

      • ruaok
        feel better soon, Freso
      • 2021-10-11 28429, 2021

      • ruaok
        last week I finished migrating the MBID mapping to include artist_mbids and a few other changes.
      • 2021-10-11 28454, 2021

      • ruaok
        then I worked on adding MBIDs in listens, so many listens should soon have MBIDs, which is quite exciting.
      • 2021-10-11 28455, 2021

      • Freso
        (Others still up: akshat, zas, monkey, yvanzo, bitmap – anyone else who want to give review, let me know ASAP. :))
      • 2021-10-11 28423, 2021

      • ruaok
        I prepped for the board meeting happening in just under 2 hours and talked to a few potential new users.
      • 2021-10-11 28452, 2021

      • ruaok
        and then I ran off to Francalunya for hiking and roman baths and amazing food.
      • 2021-10-11 28456, 2021

      • ruaok
        fin. zas?
      • 2021-10-11 28459, 2021

      • zas
        Hey