let's keep it in the topic for this week but otherwise fin.
2021-10-25 29843, 2021
Freso
Freso/reo: Allow test editing without verification
2021-10-25 29854, 2021
CatQuest
hm
2021-10-25 29855, 2021
Freso
reosarevok: Do you want to take it?
2021-10-25 29800, 2021
CatQuest
like on test.mb or
2021-10-25 29803, 2021
reosarevok
Hi!
2021-10-25 29807, 2021
Freso
Or I can do it.
2021-10-25 29807, 2021
reosarevok
Yeah, so
2021-10-25 29809, 2021
Freso
Or not. :D
2021-10-25 29828, 2021
reosarevok
yvanzo had to disable verification emails on test.mb, as he mentioned, because it seems it's being used by some dodgy asshat
2021-10-25 29854, 2021
reosarevok
But in any case, verification in test has always been dodgy - everyone can see the verified email by editing the user, IIRC, and the user does not get notified
2021-10-25 29803, 2021
CatQuest
:O
2021-10-25 29809, 2021
reosarevok
But you can't edit with a new account without a verified email
2021-10-25 29817, 2021
reosarevok
(existing accounts have no email set)
2021-10-25 29821, 2021
reosarevok
(but are marked verified)
2021-10-25 29827, 2021
CatQuest
can't leave edit notes either
2021-10-25 29853, 2021
reosarevok
So, we were wondering, should we make it so that there's no verification requirement at all for editing in test?
2021-10-25 29801, 2021
reosarevok
As in, no email needs to be entered
2021-10-25 29815, 2021
CatQuest
seems liek a plan to me.
2021-10-25 29816, 2021
ruaok
test is connected to a dummy database, yes?
2021-10-25 29818, 2021
alastairp
this is the db with all existing users, but pw `mb`?
2021-10-25 29821, 2021
CatQuest
seems like a plan to me.
2021-10-25 29828, 2021
CatQuest
yes to both of those
2021-10-25 29836, 2021
reosarevok
Yes
2021-10-25 29843, 2021
yvanzo
bitmap: did you have a plan for a mocked mail sender on test.mb.o?
2021-10-25 29844, 2021
ruaok
if it is a dummy DB, then fine.
2021-10-25 29851, 2021
bitmap
yvanzo: no
2021-10-25 29853, 2021
Freso
It is.
2021-10-25 29858, 2021
alastairp
how were people sending emails? changing a user email in the db and then triggering something that sent an email to that address?
2021-10-25 29804, 2021
ruaok
and thanks for using the term asshat. its been too long since project asshat
2021-10-25 29807, 2021
Freso
alastairp: Yeah.
2021-10-25 29823, 2021
Freso
Or registering a new account using that e-mail.
2021-10-25 29825, 2021
alastairp
sounds to me like test shoudn't send emails
2021-10-25 29826, 2021
CatQuest
:D asshat
2021-10-25 29826, 2021
yvanzo
reosarevok: or a dummy email if that is easier to handle.
2021-10-25 29833, 2021
Freso
alastairp: Yes. :)
2021-10-25 29850, 2021
alastairp
if that means that verification shouldn't be required in order to make that happen, fine
2021-10-25 29859, 2021
bitmap
+1 to removing the verification requirement
2021-10-25 29811, 2021
alastairp
+1
2021-10-25 29815, 2021
monkey
I see no reason not to
2021-10-25 29816, 2021
CatQuest
+1
2021-10-25 29820, 2021
ruaok
+1
2021-10-25 29826, 2021
reosarevok
Freso: had you already added a ticket? I forget
2021-10-25 29835, 2021
Freso
I don’t think I did.
2021-10-25 29841, 2021
reosarevok
Ok, I will
2021-10-25 29845, 2021
yvanzo
Thanks
2021-10-25 29849, 2021
alastairp
maybe periodically (like, daily?) wipe emails from the db?
2021-10-25 29803, 2021
CatQuest
I'd say that's an excellent idea
2021-10-25 29815, 2021
alastairp
potential PII leak there too
2021-10-25 29827, 2021
CatQuest
indeed
2021-10-25 29831, 2021
yvanzo
monkey: the reason not to would be to be able to test code related to email but not sending them.
2021-10-25 29840, 2021
CatQuest
hm
2021-10-25 29850, 2021
CatQuest
how about thne only allowing a test mb adress
2021-10-25 29858, 2021
CatQuest
and *only* that adress
2021-10-25 29809, 2021
CatQuest
for any account
2021-10-25 29810, 2021
alastairp
that's a good idea CatQuest. We do something similar in freesound test db
2021-10-25 29812, 2021
CatQuest
including new ones
2021-10-25 29820, 2021
Freso
reosarevok: Include mention of wiping e-mail addresses too?
2021-10-25 29823, 2021
reosarevok
Ok
2021-10-25 29841, 2021
Freso
Not sure how much more discussion this needs here. reo will make ticket, add further thoughts etc. to that. :)
2021-10-25 29848, 2021
Freso
Freso: Allow account admins to see editor-editor subscriptions?
2021-10-25 29853, 2021
Freso
So.
2021-10-25 29838, 2021
Freso
One thing sockpuppets often do is follow other sockpuppets. _Sometimes_ those sockpuppeteer is clever enough to mark their subscriptions as private.
2021-10-25 29812, 2021
Freso
Being able to see which editors an editor is subscribed to can sometimes help untangling some of these webs.
2021-10-25 29829, 2021
CatQuest
I mean can admins see other private set things? (i thikn they do?) so sure
2021-10-25 29831, 2021
Freso
But I’m not sure if this is getting too intrusive?
I’d like to get ruaok’s thoughts as well before making a ticket. :)
2021-10-25 29848, 2021
reosarevok
Technically, most of the team has DB access and can check that already, just in a more annoying way
2021-10-25 29852, 2021
Freso
ruaok: Ping?
2021-10-25 29854, 2021
Freso
Yeah.
2021-10-25 29803, 2021
ruaok is reading
2021-10-25 29808, 2021
Freso
👍
2021-10-25 29830, 2021
monkey
The privacy page also states this in "Exceptions":
2021-10-25 29830, 2021
monkey
> The MetaBrainz server administrators (about five people in all) can of course see any information on the system they want to, but to be honest we're probably not interested enough to look.
2021-10-25 29836, 2021
ruaok
yeah, I'm ok with that.
2021-10-25 29852, 2021
Freso
Alright, thanks ruaok :)
2021-10-25 29858, 2021
Freso
And everyone else!
2021-10-25 29812, 2021
Freso
someone?: removing empty accounts - last
2021-10-25 29856, 2021
Freso
Who added this?
2021-10-25 29800, 2021
CatQuest
not me
2021-10-25 29800, 2021
reosarevok
oh
2021-10-25 29801, 2021
reosarevok
sigh
2021-10-25 29807, 2021
reosarevok
Is there a max len to /topic?
2021-10-25 29812, 2021
CatQuest
oh no
2021-10-25 29822, 2021
yvanzo
Probably
2021-10-25 29831, 2021
reosarevok
That was me, and after that Freso had another topic I might have obliterated (a PSA)
2021-10-25 29843, 2021
reosarevok
So, we talked about removing empty editors during the summit
And about how I would bring a query to the next meeting for review
2021-10-25 29851, 2021
reosarevok
So, I'm still working on the script that will run the query (since we can't just delete editors directly with SQL without dealing with FKs first, we'll use the delete method for editor in a Perl script)
I'd want people to take a last look to make sure we're not forgetting anything stupid
2021-10-25 29809, 2021
reosarevok
It currently hits 782014 editors
2021-10-25 29834, 2021
CatQuest
does it take into account peple with email-as-name?
2021-10-25 29839, 2021
ruaok
over 100 line sql query. nice!
2021-10-25 29841, 2021
reosarevok
It will still go through code review so we're not going to rush into it, but since not everyone does MBS code review, but maybe Freso, lucifer or ruaok might see something dumb :)
2021-10-25 29807, 2021
ruaok
ask me when I am fresh tomorrow. this seems important enough, ok?
2021-10-25 29809, 2021
reosarevok
CatQuest: not at the moment, but I guess we could exclude those initially. bitmap had a pre-made query for that, right? so we could add it to it
2021-10-25 29820, 2021
Freso
Uh. I’ll have to look at it outside of meeting. I’m not going to crawl through a 100+ LoC SQL right now. 😂
2021-10-25 29824, 2021
reosarevok
And then decide whether to write to them or not
2021-10-25 29833, 2021
reosarevok
yeah, sure, I'm not expecting this to happen literally now :)
2021-10-25 29837, 2021
reosarevok
I'll remind you
2021-10-25 29843, 2021
Freso
Thanks. :)
2021-10-25 29801, 2021
reosarevok
That's probably it for now, just "this is here, take a look, I'll bother you again before we run it"
2021-10-25 29807, 2021
Freso
Alright!
2021-10-25 29810, 2021
Freso
Final topic!
2021-10-25 29816, 2021
Freso
Freso: Next meeting PSA
2021-10-25 29819, 2021
Freso
o/
2021-10-25 29819, 2021
CatQuest
:O
2021-10-25 29830, 2021
Freso
This Saturday/Sunday Europe will stop observing daylight savings time, so anyone who is not sync’d with Europe in this regard (e.g., Indians, Turtle Islanders/North Americans) will have the meeting be an hour different next week.
2021-10-25 29841, 2021
Freso
I can’t math right now, so not sure if an hour earlier or later. 😂
Thank you everyone who gave reviews, and thank you every everyone for your time!
2021-10-25 29857, 2021
yvanzo
Thanks!
2021-10-25 29807, 2021
monkey
Thanks !
2021-10-25 29810, 2021
Freso
Remember to take care of yourselves out there!
2021-10-25 29812, 2021
Freso
</BANG>
2021-10-25 29814, 2021
alastairp
lucifer: btw, 1 November soon - email required date on LB
2021-10-25 29837, 2021
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Follow up on Summit Notes -> Tickets, next meeting PSA (Freso)
2021-10-25 29803, 2021
lucifer
alastairp: oh yeah, i remembered that yesterday but forgot about it today 😅
2021-10-25 29823, 2021
alastairp
not sure how we can remember it. does it just require a consul change, or LB code change too?
2021-10-25 29828, 2021
Leo__Verto is now known as Leo_Verto
2021-10-25 29828, 2021
lucifer
consul change
2021-10-25 29837, 2021
alastairp
we could open a PR now, and then by the time we get around to reviewing it, it'll be november ;-)
2021-10-25 29851, 2021
lucifer
lol makes sense
2021-10-25 29806, 2021
lucifer
i'll open the PR
2021-10-25 29812, 2021
CatQuest
hey Leo_Verto !
2021-10-25 29823, 2021
Leo_Verto
o/
2021-10-25 29836, 2021
CatQuest
:D
2021-10-25 29843, 2021
Leo_Verto
alastairp: I heard you ventured into the abyss that is the BrainzBot setup on nomo :P
2021-10-25 29849, 2021
Leo_Verto
Also I hope everyone had a lovely summit this year
2021-10-25 29850, 2021
alastairp
Leo_Verto: oh hi. I'm back from it ;)
2021-10-25 29843, 2021
alastairp
Leo_Verto: curious about your comment about not being able to compile on new go - besides another command that I had to add, I successfully built it using the Dockerfile, which has no version label, so I assume that's the latest verision
