#metabrainz

/

      • lucifer
        let's keep it in the topic for this week but otherwise fin.
      • Freso
        Freso/reo: Allow test editing without verification
      • CatQuest
        hm
      • Freso
        reosarevok: Do you want to take it?
      • CatQuest
        like on test.mb or
      • reosarevok
        Hi!
      • Freso
        Or I can do it.
      • reosarevok
        Yeah, so
      • Freso
        Or not. :D
      • reosarevok
        yvanzo had to disable verification emails on test.mb, as he mentioned, because it seems it's being used by some dodgy asshat
      • But in any case, verification in test has always been dodgy - everyone can see the verified email by editing the user, IIRC, and the user does not get notified
      • CatQuest
        :O
      • reosarevok
        But you can't edit with a new account without a verified email
      • (existing accounts have no email set)
      • (but are marked verified)
      • CatQuest
        can't leave edit notes either
      • reosarevok
        So, we were wondering, should we make it so that there's no verification requirement at all for editing in test?
      • As in, no email needs to be entered
      • CatQuest
        seems liek a plan to me.
      • ruaok
        test is connected to a dummy database, yes?
      • alastairp
        this is the db with all existing users, but pw `mb`?
      • CatQuest
        seems like a plan to me.
      • yes to both of those
      • reosarevok
        Yes
      • yvanzo
        bitmap: did you have a plan for a mocked mail sender on test.mb.o?
      • ruaok
        if it is a dummy DB, then fine.
      • bitmap
        yvanzo: no
      • Freso
        It is.
      • alastairp
        how were people sending emails? changing a user email in the db and then triggering something that sent an email to that address?
      • ruaok
        and thanks for using the term asshat. its been too long since project asshat
      • Freso
        alastairp: Yeah.
      • Or registering a new account using that e-mail.
      • alastairp
        sounds to me like test shoudn't send emails
      • CatQuest
        :D asshat
      • yvanzo
        reosarevok: or a dummy email if that is easier to handle.
      • Freso
        alastairp: Yes. :)
      • alastairp
        if that means that verification shouldn't be required in order to make that happen, fine
      • bitmap
        +1 to removing the verification requirement
      • alastairp
        +1
      • monkey
        I see no reason not to
      • CatQuest
        +1
      • ruaok
        +1
      • reosarevok
        Freso: had you already added a ticket? I forget
      • Freso
        I don’t think I did.
      • reosarevok
        Ok, I will
      • yvanzo
        Thanks
      • alastairp
        maybe periodically (like, daily?) wipe emails from the db?
      • CatQuest
        I'd say that's an excellent idea
      • alastairp
        potential PII leak there too
      • CatQuest
        indeed
      • yvanzo
        monkey: the reason not to would be to be able to test code related to email but not sending them.
      • CatQuest
        hm
      • how about thne only allowing a test mb adress
      • and *only* that adress
      • for any account
      • alastairp
        that's a good idea CatQuest. We do something similar in freesound test db
      • CatQuest
        including new ones
      • Freso
        reosarevok: Include mention of wiping e-mail addresses too?
      • reosarevok
        Ok
      • Freso
        Not sure how much more discussion this needs here. reo will make ticket, add further thoughts etc. to that. :)
      • Freso: Allow account admins to see editor-editor subscriptions?
      • So.
      • One thing sockpuppets often do is follow other sockpuppets. _Sometimes_ those sockpuppeteer is clever enough to mark their subscriptions as private.
      • Being able to see which editors an editor is subscribed to can sometimes help untangling some of these webs.
      • CatQuest
        I mean can admins see other private set things? (i thikn they do?) so sure
      • Freso
        But I’m not sure if this is getting too intrusive?
      • yvanzo
        It seems it would still comply with https://metabrainz.org/privacy
      • “Subscriptions on MusicBrainz”
      • Freso
        I’d like to get ruaok’s thoughts as well before making a ticket. :)
      • reosarevok
        Technically, most of the team has DB access and can check that already, just in a more annoying way
      • Freso
        ruaok: Ping?
      • Yeah.
      • ruaok is reading
      • 👍
      • monkey
        The privacy page also states this in "Exceptions":
      • > The MetaBrainz server administrators (about five people in all) can of course see any information on the system they want to, but to be honest we're probably not interested enough to look.
      • ruaok
        yeah, I'm ok with that.
      • Freso
        Alright, thanks ruaok :)
      • And everyone else!
      • someone?: removing empty accounts - last
      • Who added this?
      • CatQuest
        not me
      • reosarevok
        oh
      • sigh
      • Is there a max len to /topic?
      • CatQuest
        oh no
      • yvanzo
        Probably
      • reosarevok
        That was me, and after that Freso had another topic I might have obliterated (a PSA)
      • So, we talked about removing empty editors during the summit
      • Freso
        Yeah, I remember my own topic. :)
      • CatQuest
        !recall oh no.
      • BrainzBot
      • reosarevok
        And about how I would bring a query to the next meeting for review
      • So, I'm still working on the script that will run the query (since we can't just delete editors directly with SQL without dealing with FKs first, we'll use the delete method for editor in a Perl script)
      • But the query itself currently looks like this https://gist.github.com/reosarevok/b0e1ad2e4618...
      • I'd want people to take a last look to make sure we're not forgetting anything stupid
      • It currently hits 782014 editors
      • CatQuest
        does it take into account peple with email-as-name?
      • ruaok
        over 100 line sql query. nice!
      • reosarevok
        It will still go through code review so we're not going to rush into it, but since not everyone does MBS code review, but maybe Freso, lucifer or ruaok might see something dumb :)
      • ruaok
        ask me when I am fresh tomorrow. this seems important enough, ok?
      • reosarevok
        CatQuest: not at the moment, but I guess we could exclude those initially. bitmap had a pre-made query for that, right? so we could add it to it
      • Freso
        Uh. I’ll have to look at it outside of meeting. I’m not going to crawl through a 100+ LoC SQL right now. 😂
      • reosarevok
        And then decide whether to write to them or not
      • yeah, sure, I'm not expecting this to happen literally now :)
      • I'll remind you
      • Freso
        Thanks. :)
      • reosarevok
        That's probably it for now, just "this is here, take a look, I'll bother you again before we run it"
      • Freso
        Alright!
      • Final topic!
      • Freso: Next meeting PSA
      • o/
      • CatQuest
        :O
      • Freso
        This Saturday/Sunday Europe will stop observing daylight savings time, so anyone who is not sync’d with Europe in this regard (e.g., Indians, Turtle Islanders/North Americans) will have the meeting be an hour different next week.
      • I can’t math right now, so not sure if an hour earlier or later. 😂
      • I think earlier?
      • lucifer
        later
      • CatQuest
        (and cats)
      • Freso
        Oh, thanks lucifer 😂
      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #2314 (03master…MBS-9356): MBS-9356: Add script to remove completely empty editors https://github.com/metabrainz/musicbrainz-serve...
      • Freso
        Anyway.
      • CatQuest
        workspam is best spam
      • Freso
        That’s all for this meeting.
      • CatQuest
        !m freso
      • BrainzBot
        You're doing good work, freso!
      • CatQuest
        !m and everyone
      • BrainzBot
        You're doing good work, and everyone!
      • alastairp
        thanks all
      • lucifer
      • Freso
        Thank you everyone who gave reviews, and thank you every everyone for your time!
      • yvanzo
        Thanks!
      • monkey
        Thanks !
      • Freso
        Remember to take care of yourselves out there!
      • </BANG>
      • alastairp
        lucifer: btw, 1 November soon - email required date on LB
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Follow up on Summit Notes -> Tickets, next meeting PSA (Freso)
      • lucifer
        alastairp: oh yeah, i remembered that yesterday but forgot about it today 😅
      • alastairp
        not sure how we can remember it. does it just require a consul change, or LB code change too?
      • Leo__Verto is now known as Leo_Verto
      • lucifer
        consul change
      • alastairp
        we could open a PR now, and then by the time we get around to reviewing it, it'll be november ;-)
      • lucifer
        lol makes sense
      • i'll open the PR
      • CatQuest
        hey Leo_Verto !
      • Leo_Verto
        o/
      • CatQuest
        :D
      • Leo_Verto
        alastairp: I heard you ventured into the abyss that is the BrainzBot setup on nomo :P
      • Also I hope everyone had a lovely summit this year
      • alastairp
        Leo_Verto: oh hi. I'm back from it ;)
      • Leo_Verto: curious about your comment about not being able to compile on new go - besides another command that I had to add, I successfully built it using the Dockerfile, which has no version label, so I assume that's the latest verision