#metabrainz

/

      • Mineo has quit
      • MRiddickW joined the channel
      • rdswift
        CatQuest, it should now be Thursday in your time zone, so let me be one of the first to wish you a Happy Birthday!
      • gcrkrause has quit
      • gcrkrause joined the channel
      • MRiddickW has quit
      • MRiddickW joined the channel
      • kinduff6 joined the channel
      • kinduff has quit
      • kinduff6 is now known as kinduff
      • MrClon has quit
      • CatQuest
        rdswift: thanks!
      • :D
      • MRiddickW has quit
      • reosarevok
        🍰!
      • I assume you already got the MB cakes, but still :D
      • goldenshimmer, mayhem: of course, if we *do know* the format, we could still add it :)
      • (assuming that's what this was about)
      • mayhem
        moooin!
      • Arsen has quit
      • Arsen joined the channel
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1776 (03master…validate-listen-): LB-1035: 500 error when sending an array to /1/submit-listens https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        monkey: I dont remember what you and i were looking at yesterday, but the release_mbid in playlists is actually not trivial. a few hours of work, but not trivial. which means I can't really dig until the playlists are done.
      • lucifer
        morning
      • lol this non-dict breaks the code to jsonify the exception too `TypeError: cannot convert dictionary update sequence element #0 to a sequence`
      • nbin
        lucifer: those listens are still hanging around, so my account must be the edgiest of edge cases
      • lucifer
        nbin: not an edge case but i had discovered another bug in listen counts yesterday evening :(. we are going to rework listen counts so that these bugs go away, listen counts are flaky till then.
      • nbin
        no worries. if i add listens in the meantime i assume the count will eventually reflect properly?
      • lucifer
        yes, when the counts are recalculated the correct one will be reflected.
      • nbin
        that's all that really matters then. just figured since i was "starting fresh" that i should probably try to start from 0
      • maybe i'll use the "-1 when deleting an invalid listen" bug to get there :P
      • CatQuest has quit
      • CatQuest joined the channel
      • monkey
        mayhem: Understood. So not a "one line change" then :p
      • mayhem
        more like a weekend project.
      • well not quite.
      • monkey
        So about a week?
      • mayhem
        lol
      • I just need to make a new labs api endpoint for this.
      • monkey
        Joyeux anniversaire CatQuest !
      • mayhem
        and in the process I also figured out how to make canonical recordings, which is something that MB and BBC has desired over the years.
      • effectively, if you roll in with a recording_mbid, it will look up the canonical one and return it and the associated metadata.
      • including release.
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #1774 (03master…LB-1033-fix_doc_comment): LB-1033: Fix doc comment for listenbrainz.webserver.views.api_tools.MAX_LISTEN_SIZE https://github.com/metabrainz/listenbrainz-serv...
      • MrClon joined the channel
      • [listenbrainz-server] 14amCap1712 merged pull request #1776 (03master…validate-listen-): LB-1035: 500 error when sending an array to /1/submit-listens https://github.com/metabrainz/listenbrainz-serv...
      • akshaaatt
        Happy Birthday CatQuest ! 🎉
      • monkey
        I managed to make that graph a bit better, thanks for the feedback riksucks and tandy1000 https://usercontent.irccloud-cdn.com/file/xXJYs...
      • mayhem
        akshaaatt monkey alastairp lucifer tandy1000 reosarevok : if I have made you a playlist (via troi-bot) in the past couple of weeks and you want to save your list, clone it soon. I'm going to nuke all generated playlists soon.
      • !m monkey
      • BrainzBot
        You're doing good work, monkey!
      • monkey
        Thanks for the heads up
      • Definitely want to save one of those playlists
      • akshaaatt
        Already done ruaok 👌
      • mayhem
        yeah, I'm saving my missed tracks one.
      • akshaaatt
        mayhem!
      • mayhem
        :D
      • lucifer
        mayhem: 👍
      • alastairp
        python logging is so confusing
      • mayhem
        alastairp: agreed. one of my least favorite parts of python
      • alastairp
        and it's so opaque in so many places, you have no idea _what_ is doing the logging
      • I think I've finally got the double-logging stuff fixed in both dev and prod
      • unfortunately, I now think my recommendation from earlier in the year to use `current_app.logger` everywhere was a stupid move and doesn't make sense, so got to put that on the future todo list again
      • MrClon has quit
      • mayhem
        why so?
      • MrClon joined the channel
      • alastairp
        flask has a single logger, named the thing that you pass in to the `Flask()` constructor. in our case this is `listenbrainz.webserver`. We print the name of the logger in log messages:
      • > spotify_reader_1 | 2021-12-09 12:12:19,994 listenbrainz.webserver INFO Processed 1 users successfully!
      • this means that a log message coming from `listebrainz/spotify_updated/spotify_read_listens.py` still has a name of `listenbrainz.webserver`
      • not the end of the world, but makes it a bit more difficult to work out where the message comes from
      • mayhem
        clear as mud. :)
      • alastairp
        I was just confused why _all_ of our log messages appeared to be coming from the webserver package
      • atj
        outsidecontext: there is something weird going on here https://i.ibb.co/BwjkBZr/Screenshot-2021-12-09-...
      • Picard appears to be changing electronica to electronic. I just checked the tags and it's written electronic twice.
      • outsidecontext
        atj: how have you configured genres? is this genres from MB (the built-in ones in Picard options), or any plugins?
      • alastairp
      • let me futz with genres a bit more, and then if I have time I'll get back to https://github.com/metabrainz/listenbrainz-serv...
      • nice
      • reosarevok
        alastairp: btw, do we now have the CB review filter to get only text reviews?
      • monkey
        When are you coming to the motherland reo? Planning on stopping by here?
      • reosarevok
        Nah, Madrid / Asturias only this time
      • monkey
        Makes sense. You'll be missed !
      • reosarevok
        Next Autumn, maybe? :)
      • That's for seeing you, not for the alastairp code
      • (but maybe both :D )
      • atj
        outsidecontext: those are genres from MB. Configuration: https://i.ibb.co/Q6X6rYX/Screenshot-2021-12-09-...
      • outsidecontext
        and what release is that?
      • alastairp
        reosarevok: CB managed to find itself on the backburner again :( Maybe lucifer and I can do a hack week after YIM is finished or early in the new year to finish up all of the PRs (and the new LB mini review functionality!)
      • atj
        no plugins installed except for a custom one I wrote to define some script functions for my folder name conventions
      • sigh
      • reosarevok
        alastairp: ok, no worries :)
      • atj
      • reosarevok
        (just wanted to make sure re: the MB PR)
      • outsidecontext
        that's odd. does this only happen if you have files on that release, or does it show up the same when just loaded?
      • atj
        I just loaded the release manually by entering the MB URL in the search box and it shows electronic twice
      • I feel like this is too odd, so it must be something I've done :)
      • outsidecontext
        can't reproduce this here. a script maybe?
      • for me it shows only a single genre, "Electronic", which would be expected with the given settings (because of the minimal genre usage threshold)
      • mayhem
        alastairp: when do you think you'll leave the office today? because the first conversation is really more a request than a long discussion...
      • atj
        outsidecontext: I'll investigate further and let you know if I find a bug
      • mayhem
        alastairp: looks like I might return closer to 3pmish.
      • lucifer
        alastairp: 1765 lgtm but something in frontend tests needs poking. https://github.com/metabrainz/listenbrainz-serv...
      • alastairp
        mayhem: I think we'll do lunch and then I'll be around until 4ish, so should be fine to talk then
      • lucifer: good catch, thanks. urg, this will be due to /code being owned by root. will have to rethink it
      • maybe just preventing pyc files is a good enough fix for now and we can look at it later
      • lucifer
        sure sounds good.
      • alastairp: 1773 looks good but will probably need a change. i realised after approving that load_config should probably come before logger init.
      • mayhem
        +1
      • alastairp
        urgh. I thought that I put it there, I must have been moving it around while testing stuff
      • ah, that's right. I removed DEBUG from my config file and was using the FLASK_ENVIRONMENT env var to set it
      • so yeah - if for some reason we set FLASK_ENV=production, but config.DEBUG=True it wouldn't necessarily work as we expected it to. will change
      • tandy1000
        <monkey> "I managed to make that graph a..." <- lookin good
      • <monkey> "I managed to make that graph a..." <- graph is looking good! what helped?
      • monkey
        tandy1000: Removing values on the bars, and figuring out how to massage the data to get a better looking X axis
      • mayhem
        alastairp: ready to chat when you are.
      • alastairp
        just debugging something
      • rdswift
        mayhem, you might want to update your IRC nick on https://metabrainz.org/team
      • mayhem
        I did the code change, but haven't deployed yet.
      • rdswift
        👍
      • alastairp
      • reosarevok
        yvanzo, bitmap: updated https://github.com/metabrainz/musicbrainz-serve... with the suggestion to allow reuse, would be good to get this ran this year :) Maybe next week even?
      • dogga joined the channel
      • mayhem
        lucifer: I just tried to deploy metabrainz.org and I am getting:
      • anything you've encountered before?
      • monkey
      • lucifer
        mayhem: haven't seen myself but looks like https://stackoverflow.com/questions/70068407/mo...
      • mayhem
        I'll go deal with this in the new year. too much YIM left to be YAMmering about with this.
      • lucifer
        quick look at https://github.com/metabrainz/metabrainz.org/bl... don't see us pinning the version so unless a dep show does. possible it pulled in a latest version which changed some imports
      • if you want, i can look into it later today or tomorrow?
      • mayhem
        sure, if you feel inclined.
      • lucifer
        👍
      • also, let me know if i can help with the left yim stuff
      • mayhem
        k, not sure if there is a chunk that can be broken out. I only have submitting playlist excerpts to LB left.
      • alastairp
      • lucifer
        what's the plan? troi dumps a csv, we import the csv in LB with a script?
      • mayhem
        I dislike the repeatability of this plan, so I am going to add a troi element that will query LB directly to fetch a list of users who do not have YIM playlists for a given troi patch. and the end of the pipeline will be a submitter element which executes an UPDATE statement on LB to insert the JSPF except into the DB. should the process get interrupted, I just start it over again.
      • alastairp
        monkey: ` "test:ci": "JEST_JUNIT_OUTPUT_DIR=/tmp TZ='Europe/London' jest --ci --reporters=default --reporters=jest-junit",`
      • mayhem
        that begs the question -- in which order do we process these things?
      • if I do an UPDATE, then I am assuming that most of the data already exists and that I just need to add one key value pair.
      • lucifer
        order of processing as in order of other YIM stats and playlists?
      • mayhem
        yes
      • lucifer
        to confirm, troi will create a playlist for the user and then add a link of it to YIM table with a specifc key?
      • mayhem
        I expect that generating playlists might take as long as a day.
      • lucifer: yes, to be specfic, monkey requested that I upload a 5 track JSPF except file to LB.
      • excerpt
      • lucifer
        i see. i would say we execute both together, and let INSERT ON CONFLICT DO UPDATE do its job. all the stats jobs are written that way.