#metabrainz

/

      • lucifer
        doing a release
      • alastairp
        but things are in a bit of a state of flux - I'm currently still using your branch git+https://github.com/amCap1712/brainzutils-py... because BU 2.0 (which has the sets API in it) also has the renaming of the musicbrainz_db methods from get_x_by_id to _by_mbid
      • so I'm trying to reduce the amount of changes at once
      • monkey
        akshaaatt: I made a few modifications to the Brainzplayer PR (mainly getting the controls aligned horizontally in the middle and take less space), here's what it looks like currently: Interested to hear your opinion https://usercontent.irccloud-cdn.com/file/I2T1j...
      • akshaaatt
        Looks great to me monkey!
      • !m monkey
      • BrainzBot
        You're doing good work, monkey!
      • lucifer
        alastairp, how about making an upgrade branch? changing/reviewing one part in 1 PR merging to that once everything done merge to master.
      • akshaaatt
        Also, I was wondering if the brainzplayer could be moved to an npm package
      • I think that was discussed before, but this PR looks like a good fit to start that motion monkey
      • monkey
        That will most likely be the case, part of the prep work for that has been done with tandy1000, and the redesign was one of the last missing tasks
      • Separating should definitely be done in another PR.
      • akshaaatt
        Yuss. Sounds good to me
      • monkey
        My hunch is that we should wait until we have controls working for currently playing track regardless of it having an mbid. Currently I'm not sure the love/hate buttons will work for example
      • I should probably sort that out before extracting to a package
      • akshaaatt
        Right
      • monkey
        (because it's pretty central functionality)
      • After that I agree, let's package it.
      • akshaaatt
        Great!
      • monkey
        And then new features (for example play queue) can be developed in the package
      • So no misgivings or improvements you see for the player akshaaatt ?
      • akshaaatt
        Yuss! Also, once the package is available and if other developers use it in their projects, we could widen our reach to collect data for the recommendation system in some way
      • All good for me monkey as of now!
      • monkey
        great :)
      • alastairp
        lucifer: any idea why this check is `if not`? https://github.com/metabrainz/critiquebrainz/pu...
      • lucifer
        alastairp: that looks like wrongly introduced in https://github.com/metabrainz/critiquebrainz/pu...
      • alastairp
        mmm, yeah
      • deleting it
      • lucifer
        👍
      • alastairp
        that was the cause of the error above, btw. `cache.delete_many([])`
      • lucifer
        ah! makes sense
      • BrainzGit
        [listenbrainz-server] release 03v-2022-02-21.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • lucifer
        mayhem: while going through stale branches found https://github.com/metabrainz/listenbrainz-serv... . do we still want to do this?
      • mayhem
        yes, I think we should.
      • lucifer
        also mayhem, alastairp, monkey (and me too!) have a bunch of stale branches for LB. i think a lot of those are deletable. please take a look when you have time.
      • 👍
      • monkey
        Merci
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #1878 (03master…param/patron-page): Add a patron page to take donations https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        deleted my old ones. sadly, many open data gulag tasks for me.
      • lucifer
        thanks!
      • Freso: i realized today LB-932 was done sometime ago accidentally :)
      • BrainzBot
        LB-932: Hide rows with non-existent accounts on /similar-users/ https://tickets.metabrainz.org/browse/LB-932
      • CatQuest
        open data gulage
      • have an open data 🐟 instead
      • idea for april fools day: dispaly fish emoji randomly on mb pages
      • all the french users wil lol
      • tiny little script to count how many fish you clicked on that day, at the end yo uget a banner message or something with "you clicked on $number fish! happy april fools day!"
      • .. where is that google doc with april fools day suggestions.. fm
      • bitmap
        akshaaatt: yes, I was working on porting the TS types to Flow, and can probably push them today
      • akshaaatt
        That would be wonderful bitmap! Thanks!!
      • lucifer
        LB prod updated.
      • tandy1000: your PR has been deployed.
      • alastairp
        !m tandy1000
      • BrainzBot
        You're doing good work, tandy1000!
      • lucifer
        monkey, the feed listens event limit is also live now.
      • monkey
        Awesome, thank you !
      • bitmap
        yvanzo: i'm not sure what the open question on https://github.com/metabrainz/musicbrainz-serve... is
      • yvanzo
        hi bitmap: Do we fill mirror's logs as well? Or how do we prevent it to happen?
      • reosarevok
        mayhem: I like my trackball :D But that's also probably not what you want
      • mayhem
        yeah
      • MRiddickW has quit
      • BrainzGit
        [critiquebrainz] release 03v-2021-02-21.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/critiquebrainz/re...
      • mayhem reads the longest comment in history of computer science
      • mayhem
        !m lucifer
      • BrainzBot
        You're doing good work, lucifer!
      • lucifer
        :D
      • mayhem
        I'll deffo get the comment read today.
      • not sure about the rest of the PR
      • bitmap
        yvanzo: well, in musicbrainz-docker they weren't logged, but I'm not sure I see a problem with logging them there. so I suggested waiting to see if someone requests a way to turn it off
      • lucifer
        sounds good, no hurry
      • akshaaatt
        mayhem you might be interested in https://www.logitech.com/en-in/products/mice/mx...
      • BrainzGit
        [critiquebrainz] release 03v-2022-02-21.0 has been published by 14alastair: https://github.com/metabrainz/critiquebrainz/re...
      • alastairp
        pro tip: it's not actually 2021 any more
      • mayhem
        akshaaatt: yeah, I saw that one, but seems a bit overkill for my needs. thanks though.
      • alastairp
        CB cron released, will keep an eye on dumps tomorrow
      • lucifer
        monkey, bitmap, yvanzo, reosarevok, zas: hi! BB, MB, Picard GSoC Ideas do not mention time estimate 175 or 350 hrs. would be nice to add that when you have time.
      • monkey
        Roger that. I still haven't added new project ideas
      • lucifer
        mayhem: re the email from Youtube verification, i don't see what the recording is missing. do you? if not, i'll reply and ask for more details.
      • akshaaatt
        lucifer the cb integration extension we talked about today might be a potential gsoc project
      • into lb*
      • lucifer
        akshaaatt: i think it'll be really shorter than a soc project even for 175 hrs one. CB already has an api to fetch reviews given an entity id.
      • akshaaatt
        Oh that's wonderful then! And yeah makes sense!
      • yvanzo
        bitmap: Ok, I just checked and there even is a logs size limit (2.5G) already.
      • bitmap, reosarevok, cc lucifer: I will ping okno about GSoC. I won’t add more ideas but can help with reviewing any addition.
      • mayhem
        lucifer: you could also be daring and resubmit the same video and say "We've added the missing bits you requested"
      • lucifer
        🤣
      • alastairp
        lucifer: hmm, what's your opinion on using `f"{variable=}"`-style debug strings as an implementation details? (opposed to `f"variable={variable}"` or some other type of formatting)
      • lucifer
        alastairp: i think either is fine. i'd probably do with first one as it looks is more concise but iirc it also needs py 3.8
      • alastairp
        yeah - I'm not too worried about python versions, it'll be in CB and so we control the version
      • I'm just a bit concerned that it's this weird "special" syntax (ok, sure - it's not going to disappear any time soon, but it seems easy to miss what it's doing)
      • explicit is a lot more clear about what's going on
      • lucifer
        fair point, makes sense.
      • Freso
        <BANG>
      • It’s International Mother Language Monday!
      • zas has mailed in a review, so zas, go!
      • zas says…
      • """
      • I mainly worked on preparing Ansible move, meeting with atj, reading documentation, and we did a bunch of experiments. We (with atj) plan to replace cage by a new server, and work on a playbook to ease the new server deployment.
      • I also reviewed and merged a few Picard PRs.
      • Plus usual supervision, upgrades, user support, edits.
      • """
      • Others up are the usual suspects: reosarevok, yvanzo, bitmap, atj, mayhem, monkey, alastairp, akshaaatt, lucifer, CatQuest, Freso
      • reosarevok: Why don’t you start us off? :)
      • reosarevok
        Hi! I documented more tests, mostly, and I also did some code review :)
      • Plus spent a fair amount of time looking at style tickets, which I had kinda left unloved for a bit
      • (so we now have a bunch more release status, the Non-binary gender, and a new event type and series type fro awards)
      • *for
      • CatQuest: you?
      • CatQuest
        Meow! `😺`
      • Doing mostly books now, so much to read and add!
      • Been creating tickets related to that
      • Been creating tickets related to that
      • Today is my 18th MusicBrainz anniversary!
      • 🎉
      • mayhem
        wooo, MB can go and get drunk now!
      • Freso
        🎉
      • CatQuest
        also today i'e been working on finalising the instrument document
      • mayhem: my thoguhts exactly
      • :D
      • Freso
        CatQuest: Thank you for sticking around. :)
      • CatQuest
        so all we need is a looksy form freso and it cna be finished!
      • monkey
        Happy MBirthday CatQuest !
      • CatQuest
      • :D
      • fin, go monkey
      • monkey
        Hello everyone !
      • As usual, last week contained lots of PR reviewing for BB and LB
      • akshaaatt
        !m CatQuest
      • BrainzBot
        You're doing good work, CatQuest!
      • monkey
        I continued working on mood classification and tagging. It's taking a while, but it can't be rushed lest we anger everyone out there.
      • I've got a good grasp on how that component is going to look like now.
      • mayhem
        noice!
      • monkey
        I've been working with and helping Shubh on importing entities into MB from third-party websites
      • Did some debugging of BrainzPlayer, and some LB design
      • In particular preparing for continuing work on redesigning BrainzPlayer, a PR I started late last year
      • And a smidge of work on the new LB album endpoint
      • And that's me ! bitmap go !
      • bitmap
        hey
      • last week I continued working on schema change tickets, code review, and updating some refactoring PRs I had open
      • rn testing the individual upgrade scripts I added to make sure those are good
      • also worked on adding some fontawesome Flow types for akshaaatt's homepage PR which I'll have ready today
      • I think that's all - go yvanzo!
      • yvanzo
        Hi!
      • Last week I updated a PR to bring timestamp for every line of log in MusicBrainz Server.
      • (It is expected to help us with debugging still current I/O load alerts for example.)
      • Freso
        (Still up: atj, mayhem, alastairp, akshaaatt, lucifer, Freso)
      • yvanzo
        Prepared for migrating Weblate, updated code for spam report and artist credits MBID.
      • Debugged a contributed patch to the triggers generated by the search indexer.