makes sense, i'll add to the comment on that proposal.
we only have 2 proposals for LB for the time being so that's it on this topic.
mayhem
thanks for jumping into this -- I hope to be out of accounting jail tomorrow.
half day should do it.
lucifer
alastairp: you may also want to look at the proposal above. particularly the time zone storage stuff, i had assumed PG had a built in type for it but apparently there isn't one.
ah cool. nice
PrathameshG[m]
<akshaaatt> "Why would you need to share..." <- Actually half of them were just MBID examples embedded with the links haha.
I removed them, so it should be fine now ig.
alastairp
lucifer: yeah, I have it open now. that's a good question
lucifer
the answers i saw on SO, suggested text column plus a constraint check.
akshaaatt
Great Prathamesh! All the best :)
PrathameshG[m]
<alastairp> "PrathameshG: you can make a..." <- Yes, I am doing both.
Including a full link for the google doc, as well as a not-as-good-looking proposal written in Markdown on discourse.
alastairp
lucifer: where text is the name of an official tz database name?
lucifer
yes.
alastairp
right. I wonder how often new ones get added/removed there? :)
PrathameshG[m]
akshaaatt: Thanks akshaaatt :))
lucifer
oh well there was a great controversy about that recently.
alastairp
yes, I remember
lucifer: oh, urhg. you know what I realised
lucifer
mostly about pre 1970 dates though so not concerning us much. iirc PG chose to track the fork or revert changes from offical repos
alastairp
for when DST changes, we should probably store an offset with the listen, indicating what the offset was at the time that it was submitted
there was that interesting post on HN a few weeks back about how to store time in calendars for future events
lucifer
do we need an offset for that? i was assuming knowing the timezone would be enough and a datetime lib could figure out the offset.
alastairp
nope
lucifer
oh!
Dijia joined the channel
alastairp
because for example, CEST happens from the last sunday of march to the last sunday of october
but what if next year they decide to start it on the first sunday of april
Freso
alastairp: datetime lib should be able to handle that.
Using the tzdata.
alastairp
hmm, yes, if it takes into account historical data then it should
lucifer
yeah i was assuming tzdata tracks the offset for each zone over period
Freso
It does.
mayhem
Freso: I have some obligations at :30 after the hour. I'd love to go sooner than later, plz.
alastairp
lucifer: in any case, some careful things to think about with this proposal so that we don't screw it up again like we did with the listened at timestamp
I'll take a look at it
Freso
<BANG>
It’s International Monday for Mine Awareness and Assistance in Mine Action!
I was occupied with work and some IRL matters last week so was unfortunately unable to dedicate much time to MB.
However I did resolve a minor issue with shorewall due to a reference to an invalid log file and hopefully fixed an recurrent issue with apt tasks failing when bootstrapping servers. I also reviewed a PR created by zas that added a role to manage timezone and NTP configuration.
The playbooks are now mature enough that zas was able to fully deploy a server from scratch in 30 minutes today, which is a great achievement.
"""
Others up: alastairp, mayhem, akshaaatt, zas, yvanzo, lucifer, bitmap, monkey, reosarevok, CatQuest, Freso – anyone else who wish to give review, let me know ASAP!
mayhem: Go!
mayhem
thx!
Freso
Np :)
alastairp
great to see the playbooks going well!
lucifer
alastairp: yes makese sense 👍
alastairp
!m atj and zas
BrainzBot
You're doing good work, atj and zas!
mayhem
last week was all about the metadata view, or more specifically the MB datadata cache coming together.
massive SQL queries ftw.
lucifer and I also cleaned up some mapping stuff, fixing some things that were not mapped and also renaming things to be more consistent.
we now also have a python class for making it super simple to run an SQL query to create a new table and then to rotate that table into production inside a transaction.
those bulk tables can be chained as well, so more than one table can be swapped in in the same transaction.
this is the meat and potatoes of the mapping work, so this will make me more efficient in the future.
then I paid people and did quarterly accounting today.
mayhem alastairp akshaaatt : Please check it out if you find some time :))
Feel free to criticize it wherever possible. I'd be happy to even rewrite it if required!
akshaaatt
Sure PrathameshG[m]! Will do so after a while :)
mayhem
will do tomorrow afternoon
Freso
Mostly the usual, but I also poked at an issue with logging in to the forums from the iOS… and got that solved. So anyone using the Discourse iOS app should now be able to use it with our instance, too. :)
fin.
alastairp: Go!
alastairp
hello
PrathameshG[m]
Thanks a lot akshaaatt mayhem :)
alastairp
last week I finished work on the metadata viewer backend to update out of date rows, and planned with mayhem how to actually find out of date rows. I also started work on data dumps for the canonical tables
I finally got the BU upgrade in CB finished and released and some people tested that. It's looking good so we'll merge and roll that out. with lucifer's help I also merged and released some really old CB PRs (from before when lucifer was a contractor!)
I also read and reviewed some SoC proposals, and reviewed some PRs
finally, I worked on getting AB dumps working, so that we can distribute an archive of submissions when we shut the site down. 2 of the 3 dump types are working, so almost finished there
that's me, akshaaatt next?
akshaaatt
Hi everyone!
Last week I worked massively on the MusicBrainz revamp work
I also opened a PR to improve our CAA error logging and deployed that to hopefully help debug an issue Zas was seeing
earlier in the week I helped perform another primary database switchover from pink to floyd so that pink could be upgraded, then restored standby service on pink later that day. and I apologize for not better communicating which services would be affected by that, I've noted it for the future!
fin. yvanzo go!
yvanzo
Hi!
Last week I hotfixed bugs in the wrapper that runs MB background tasks.
Freso
(Still up: zas, lucifer, monkey, reosarevok, CatQuest – anyone else who wish to give review, let me know ASAP!)
yvanzo
Helped with pink update, and investigated some alerts (CAA, SIR…).
Updated the documentation PR about Docker volumes.
Resumed updating the PR about releasing MBS.
Also reviewed a few PRs and provided support.
Finito, go zas!
zas
Hey
Mainly worked on moving servers to ansible, last week we did pink, patton and ludwig
It implied fixing/improving our playbooks, but today's ludwig was up and running within 30 minutes from scratch (including formatting/installing from rescue)
monkey
!m zas and atj
BrainzBot
You're doing good work, zas and atj!
zas
I also continued on new gateways, fixed few issues, and started to benchmark (using vegeta), there's some bottlenecks related to SSL I need to identify
basically I achieved 30k+ req/s on http on a single server, but this goes down to 2.5k in https with keepalive, and only 530 without ka
(that's per second)
plus usual supervision, upgrades, edits, PR reviews. fin, lucifer?
lucifer
hi all!
cuanim has quit
Freso
(Only monkey, reosarevok, and CatQuest left.)
lucifer
i reviewed some LB PRs last week and SoC proposals. also did some on work on metadata viewer backend and related electron app. also some dumps debugging. that's it for me.
reosarevok: next?
reosarevok
Hi!
I released the server, worked on a few small issues, and took a couple chill days to rest and bird and cycle
Also spent some time reviewing akshaaatt's code :)
CatQuest
:bird:
alastairp
I didn't know that birds could cycle
CatQuest
:D
cyclebirds
reosarevok
It's in the Lion King, dude
CatQuest
eeehht
reosarevok
It's the cyyyyycle of biiiirss
*birds
CatQuest
shouldn't thst be birbs
reosarevok
Oh, yeah, of birbs
Anyway, this week plan is to hopefully start working on moods
We should work on merging some of the open schema change PRs too
But anyway, that's it for me. CatQuest ?
CatQuest
Meow! `😺`
last week was spent mostly nagging people to help write a stupid blogpost
then reosarevok basically rewrote the whole thing :(
but it ended up a success so that was a good thing! :D
this week I've nagged monkey and shub but they are doing really good work
mayhem runs off
mayhem
bai!
CatQuest
so I'll be working on testing bookbrainz and seeing if I can be at all useful :) ♓
fin, go monkey !
(also ps happy aprilfish day!)
monkey
Hello everyone !
Last week I worked on UI mockups for the LB metadata viewer, with a bit of help from aerozol (thanks!)
I tweaked BB's automated GitHub deployment configuration a bit, and deployed a new version in production.
We’ve already identified a couple of regressions (unrelated to the deployment config), so not the best deployment ever…we’re discussing better deployment cycle practices on the #bookbrainz channel.
I also reviewed PRs, mostly for BB, and spent some time helping and directing new contributors, participating in forum discussions and reviewing GSoC project proposals.