for flask testing, i guess we find another testing lib or fork and fix the stuff we need. the repo seems unmaintained so submitting patches there is likely not useful.
2022-04-11 10100, 2022
alastairp
lucifer: pip wasn't happy with upgrading just flask - there were quite a number of dependencies that we have that weren't compatible and so I had to update them too
monkey: hi, this dropdown (top right) is from a recent PR by Ansh. Any feedback on it? Specifically, if it's currently set to "newest", should the option in the dropdown be selected/disabled in any way?
2022-04-11 10115, 2022
alastairp
akshaaatt: aerozol: your feedback on this welcome too!
2022-04-11 10127, 2022
CatQuest has quit
2022-04-11 10111, 2022
monkey
alastairp, Ansh: yes, I think showing the currently selected option (which is just adding the "active" css class if i'm not mistaken) would be useful
2022-04-11 10152, 2022
monkey
Not much other feedback, it's clear and the placement makes sense.
2022-04-11 10111, 2022
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews , Next meeting (Easter monday, alastair)
2022-04-11 10154, 2022
alastairp
monkey: thanks. only other change is to remove Popularity and replace with 'Most Popular' and 'Least Popular' (so that we have the matching ascending/descending options for that)
2022-04-11 10109, 2022
monkey
Yes, that sounds great
2022-04-11 10118, 2022
CatQuest joined the channel
2022-04-11 10100, 2022
monkey
riksucks: I'm around now
2022-04-11 10121, 2022
reosarevok
bitmap: oh, neat
2022-04-11 10127, 2022
reosarevok
Hopefully that will help
2022-04-11 10135, 2022
reosarevok
What's the loss compared with the usual one?
2022-04-11 10131, 2022
bitmap
it is way faster, but we lose the ability to customize how the strings are split before diffing (e.g. in some cases we use \s+ to implement word diffing)
2022-04-11 10107, 2022
reosarevok
Hmm
2022-04-11 10133, 2022
reosarevok
Would it make sense to use it only for annotations?
2022-04-11 10104, 2022
reosarevok
So, either pass a useFastDiff or call a different FastDiff component?
bitmap: I just thought it might be annoying to check len, but maybe not
2022-04-11 10123, 2022
reosarevok
Can you send a quick PR?
2022-04-11 10139, 2022
bitmap
sure
2022-04-11 10144, 2022
reosarevok
Ideally we'd release that today as well (with a quick test in beta to see nothing is broken) because the whole thing seems ridiculous at the moment
2022-04-11 10133, 2022
lucifer
mayhem: done
2022-04-11 10139, 2022
riksucks
Hi monkey, I wanted to ask, how do you guys plan to code the new frontend of LB
2022-04-11 10117, 2022
riksucks
Should I be keeping something in mind while writing code, so that minimal changes need to be done
2022-04-11 10114, 2022
riksucks
When migrating the codebase ofc (specially asking this so that I can choose the right drag and drop library for the soc project)
2022-04-11 10121, 2022
mayhem
lucifer: thanks!
2022-04-11 10125, 2022
CatQuest joined the channel
2022-04-11 10125, 2022
CatQuest has quit
2022-04-11 10125, 2022
CatQuest joined the channel
2022-04-11 10103, 2022
monkey
I don't think there's anything you would need to keep in mind, except maybe one: I think we will eventually end up with a sidebar to show the current user's followers on any page, so don't assume by default that the new functionality will only ever be used on the feed and home pages
2022-04-11 10131, 2022
monkey
No specific considerations with the drag&drop library.
2022-04-11 10134, 2022
monkey
I've been using react-sortable for playlist items but I don't think it does full drag/drop features
Some unsolicited advice on the side: probably best to start with and get a fully working end-to-end feature using the ListenCard context menu before doing anything drag&drop.
2022-04-11 10156, 2022
skelly37 joined the channel
2022-04-11 10118, 2022
akshaaatt
alastairp: I think the popularity fix you suggest makes sense. Other than that monkey has already suggested on how to make the selected option visible :)
Opening instrument for editing also creates links to all the instrument attributes, heh
2022-04-11 10113, 2022
reosarevok
(not from the list, but from its doc page)
2022-04-11 10122, 2022
reosarevok
I see two options: 1) have a check for id = 14 that shows a string for "Possible values" like "The possible values for this relationship can be seen from the {instrument list}"
2022-04-11 10156, 2022
reosarevok
2) have the possible values here, but block editing attributes if they have a root ID of 14 and not an id of 14
2022-04-11 10105, 2022
reosarevok
bitmap: what sounds better to you?
2022-04-11 10116, 2022
bitmap
both, I think? :) linking to /instruments makes sense but also making sure you can't edit them even if you type the url
that should be automatic i think. if you update the docstrings in flask endpoint, it gets updated in doc.
2022-04-11 10132, 2022
chinmay
Hi, I had a few questions that I posted late on Saturday. I'll post them again..
2022-04-11 10144, 2022
chinmay
Hello @monkey @lucifer, I had a few doubts about send track project.
2022-04-11 10144, 2022
chinmay
1. I am thinking that when a user clicks on "Recommend to user" option from the ListenCard component, they will see a modal with a populated list of users along with check boxes. What should this list populate?
2022-04-11 10144, 2022
chinmay
a. Followers + Search box to search MusicBrainz users
2022-04-11 10144, 2022
chinmay
b. Followers + Following + Search box
2022-04-11 10144, 2022
chinmay
c. Followers only
2022-04-11 10144, 2022
chinmay
d. Followers + Following only
2022-04-11 10145, 2022
chinmay
2. When a recommendation is sent, should the sender see his sent recommendation in their feed? eg. "You recommended 'Song' to User B".
2022-04-11 10146, 2022
chinmay
3. Should a third user (say User C) be able to see who recommended what track to whom? eg. "User A recommended 'Song' to User B".
I was mostly working on BookBrainz tickets. This week will be spent preparing for Easter. 🐟
2022-04-11 10102, 2022
Freso
"""
2022-04-11 10102, 2022
Freso
atj: Go!
2022-04-11 10103, 2022
Freso
(Others up: akshaaatt, reosarevok, yvanzo, lucifer, monkey, zas, bitmap, mayhem, alastairp, Freso – anyone else who want to give review, let me know ASAP!)
2022-04-11 10104, 2022
Freso
No atj?
2022-04-11 10108, 2022
Freso
akshaaatt: Go!
2022-04-11 10113, 2022
akshaaatt
Hi everyone!
2022-04-11 10126, 2022
akshaaatt
Last week I continued work on MusicBrainz.
2022-04-11 10150, 2022
akshaaatt
bitmap and I were also discussing how we could automate the release process, hence I started to understand jenkins and how we could potentially migrate to github actions.
2022-04-11 10101, 2022
akshaaatt
This involved some research work.
2022-04-11 10117, 2022
akshaaatt
Other than that I reviewed yellowhatpro's GSoC proposal and continued some work on the android app.
2022-04-11 10149, 2022
akshaaatt
I also fixed some work in the Listenbrainz revamp work.
2022-04-11 10101, 2022
akshaaatt
That's it for me! fin. Go reosarevok!
2022-04-11 10109, 2022
reosarevok
Hi!
2022-04-11 10100, 2022
reosarevok
Last week I worked on a bunch of tickets, including MBS-11178 (to document entity types and whatnot)
