yes, UNION is an anti-pattern as far as I am concerned.
2022-05-23 14335, 2022
lucifer
that was actually how they optimized it in this case. replaced left join with union all.
2022-05-23 14306, 2022
mayhem
wait, really?
2022-05-23 14310, 2022
lucifer
yup
2022-05-23 14349, 2022
mayhem
my experiences have been the other way around. odd.
2022-05-23 14310, 2022
lucifer
the left join was preventing them from using indexes, rewritign it with union all allowed them to utilise those.
2022-05-23 14323, 2022
mayhem
thats odd.
2022-05-23 14335, 2022
mayhem goes back to board meeting prep
2022-05-23 14313, 2022
lucifer
>A LEFT JOIN for tables A and B is the intersection of A and B plus the rows in A that do not appear in B. We cannot index a left join directly, however the intersection case can be indexed quite nicely, and we can perhaps do something better than the current case for the null join case. So rather than using a LEFT JOIN directly, let's create a query which explicitly calculates each part of the result set and appends them, and see how we
2022-05-23 14314, 2022
lucifer
can improve performance.
2022-05-23 14343, 2022
texke joined the channel
2022-05-23 14339, 2022
lucifer
mayhem: not sure whether an issue or not with the json files, but i realised we send a limited number of stats at a time. we store 1000 but paginate by 25. not sure if this counts as querying.
2022-05-23 14354, 2022
revi has quit
2022-05-23 14348, 2022
trolley joined the channel
2022-05-23 14311, 2022
mayhem
no that is pagination, which should should be able to do with the proposed solution.
2022-05-23 14323, 2022
PrathameshG[m]
Hey everyone :))
2022-05-23 14331, 2022
mayhem
hi!
2022-05-23 14338, 2022
mayhem
oh that reminds me, I need to create IRCCloud accounts for all our GSOC students.
2022-05-23 14338, 2022
PrathameshG[m]
Now that we're finally in the community bonding period, it's a nice reminder that we should know each other better!
2022-05-23 14350, 2022
PrathameshG[m]
mayhem: Oooh interesting
2022-05-23 14309, 2022
mayhem
send me your email in a PM and I'll invite you.
2022-05-23 14359, 2022
lucifer
mayhem: ah cool, btw looking at json stores currently, couchdb and cassandra particularly. will find and look at others later.
2022-05-23 14333, 2022
mayhem
gah. cassandra. LB was first build using cassandra and we had to do huge amounts of fighting and we replaced it with PG.
2022-05-23 14356, 2022
lucifer
oh, any particular issues? it seems like could work fine for this task.
2022-05-23 14357, 2022
PrathameshG joined the channel
2022-05-23 14329, 2022
mayhem
much better PrathameshG[m]
2022-05-23 14337, 2022
mayhem
eh, PrathameshG
2022-05-23 14339, 2022
PrathameshG
Yes, looks like this is it
2022-05-23 14350, 2022
PrathameshG
Yea pretty confusing usernames lol
2022-05-23 14308, 2022
mayhem
lucifer: I don't recall the particular issues, it was just... not good.
2022-05-23 14311, 2022
PrathameshG
I should rename the matrix ID for this channel ig
2022-05-23 14324, 2022
lucifer
i see.
2022-05-23 14331, 2022
mayhem
people shouldnt use software written by FB.
2022-05-23 14359, 2022
mayhem
PrathameshG[m]: just drop your matrix one. it will just confuse us all. Just use one.
atj: ping, I'd like to add a specific /etc/smartmontools/run.d/10mail file to certain machines (managed by ansible), in order to filter out spammy messages (like the non-issue "Critical Warning (0x04): Reliability" we have on trille. The idea is to override this file with a per-host (or per-group) file, but only if there's one. What would be the best approach to achieve that with ansible?
2022-05-23 14320, 2022
chinmay joined the channel
2022-05-23 14309, 2022
riksucks
hi monkey, whenever you are free, do you wanna have discussions about polishing the mockups of the personal recommendation feature
2022-05-23 14321, 2022
riksucks
or do you want to discuss it when the backend has been implemented
monkey I'm looking to move forward with `container-fluid` instead of `container` wrapping on ListenBrainz. The same is followed on MusicBrainz. Any comments on that or good to go?
2022-05-23 14301, 2022
monkey
Can you sum up the differences please?
2022-05-23 14353, 2022
akshaaatt
A difference will be felt in the desktop version where the width with fluid will be maximized
2022-05-23 14320, 2022
akshaaatt
`container-fluid covers the whole width of any device, . container is set to cover a maximum of 1320px width on the largest viewports`
2022-05-23 14354, 2022
monkey
Well, I can only say the lack of any sort of margin or padding on the side looks really really wrong to me
2022-05-23 14314, 2022
atj
zas: we should be able to ignore that error via the configuration
2022-05-23 14317, 2022
monkey
Probably depends on the pages though
2022-05-23 14348, 2022
monkey
But that hompage liketaht makes me wantto scream :p
2022-05-23 14353, 2022
akshaaatt
We can fix that monkey
2022-05-23 14342, 2022
akshaaatt
I am looking forward to adjusting the font sizes later. I think that should fix our issue
2022-05-23 14311, 2022
monkey
I think a bit of paddi.g to make sure the text doesn't rub on the sides of the page should be enough
2022-05-23 14321, 2022
akshaaatt
For now monkey, I have moved the footer and the nav out of container and have them on fluid, while the homepage and the listens, etc with a container
2022-05-23 14338, 2022
akshaaatt
Once we add the sidebar, we can replace the main sections's container with fluid
2022-05-23 14359, 2022
mayhem
FWIW, I strongly oppose the lack or margin as well.
2022-05-23 14312, 2022
akshaaatt
Right mayhem. I think yeah having the main container on container does make sense
2022-05-23 14320, 2022
akshaaatt
section*
2022-05-23 14321, 2022
mayhem
good. :)
2022-05-23 14304, 2022
bitmap
akshaaatt: sorry but I'm not sure since I didn't attempt to debug it, I was just relaying the error I found. but it's easy to reproduce
2022-05-23 14343, 2022
monkey
For what it's worth akshaaatt, the `container-fluid` class with the css var `--bs-gutter-x` set to `3em;` for example seems fine to me. It doesn't have to be the super-wide margins of the regular `container` class: https://usercontent.irccloud-cdn.com/file/i1sC8Rh…
2022-05-23 14304, 2022
akshaaatt
Right bitmap!
2022-05-23 14313, 2022
akshaaatt
Noice monkey! Sounds good
2022-05-23 14345, 2022
monkey
It's not my favorite (reading text lines longer than ~50-60 character I find unpleasant), but at least I don't want to scream :p
2022-05-23 14356, 2022
mayhem
agreed
2022-05-23 14308, 2022
monkey
For reference, on this screen size that's about 110 characters per line
2022-05-23 14323, 2022
Freso
<BANG>
2022-05-23 14323, 2022
Freso
It’s International Monday to End Obstetric Fistula!
I have received one mailed in review… reosarevok, go!
2022-05-23 14302, 2022
Freso
reosarevok says…
2022-05-23 14304, 2022
Freso
"""
2022-05-23 14316, 2022
CatQuest
:o
2022-05-23 14328, 2022
Freso
Last week I helped put out the schema change, wrote a couple small PRs, then went on a break and did nothing else of note. Still doing that right now. Doing nothing is neat.
2022-05-23 14329, 2022
Freso
"""
2022-05-23 14336, 2022
Freso
bitmap: Go!
2022-05-23 14341, 2022
CatQuest
but
2022-05-23 14341, 2022
bitmap
hi
2022-05-23 14348, 2022
mayhem
so spanish, reo. :)
2022-05-23 14305, 2022
bitmap
last week I helped with the schema change release and was mostly working on PRs related to that
2022-05-23 14318, 2022
Freso
(Others up: monkey, Freso, akshaaatt, alastairp, zas, atj, mayhem, lucifer, yvanzo, CatQuest – anyone else who to give review, let me know ASAP! :))
2022-05-23 14330, 2022
CatQuest
:|
2022-05-23 14341, 2022
bitmap
afterward I fixed some small remaining issues. one causing the JSON dumps to hang and was hot-fixed, others were minor
2022-05-23 14356, 2022
bitmap
fin. go monkey!
2022-05-23 14301, 2022
monkey
Hiya !
2022-05-23 14324, 2022
monkey
Last week was a bit slow, but I did continue reviewed my giant stack of PRs
2022-05-23 14303, 2022
monkey
With alastairp we tweaked some things on BrainzBot to allow us to write PR review ids like so: LB#2000
I continued working a bit on the LB metadata viewer, and did some debugging to figure out some issues with listening on LB with Spotify (some listens don't make it into the listening history)
2022-05-23 14356, 2022
monkey
Worked a bit on the bootstrap migration
2022-05-23 14319, 2022
monkey
And finally started a document to explain what the goal is for moods on MB and LB
2022-05-23 14321, 2022
CatQuest
..
2022-05-23 14337, 2022
monkey
That's it for me ! lucifer go !
2022-05-23 14349, 2022
lucifer
hi all!
2022-05-23 14350, 2022
Freso
(Others still up: akshaaatt, alastairp, zas, atj, mayhem, yvanzo, CatQuest, Freso – anyone else who to give review, let me know ASAP! :))
2022-05-23 14301, 2022
lucifer
i helped a bit in the schema change by working on unifying our mbdata fork with upstream and updating the models for schema version 27. also worked on some sir tests.
2022-05-23 14310, 2022
mayhem
thanks for helping!
2022-05-23 14335, 2022
lucifer
reviewed some PRs, helped in debugging mbid mapper issues and added an initial version of rechecking old unmatched msids (further improvements to come). worked with LB team to get the long standing mini reviews PR merged, with that all of jdaok's work from last GSoC is now merged.
2022-05-23 14301, 2022
lucifer
some work on recommendations, like adding a new category and timestamps of when those were listened last. that's it for me. CatQuest: next?
2022-05-23 14313, 2022
CatQuest
Meow! `😺`
2022-05-23 14327, 2022
CatQuest
Hi! I've done plant things this week, but also had time to do INST-1053 & INST-1052
2022-05-23 14357, 2022
CatQuest
also been looking into fixing up a few abandoned recordings. there are quite a few.
2022-05-23 14357, 2022
CatQuest
finally working on some bookbrainz editions, hoping that updates will make things better :D
2022-05-23 14301, 2022
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, MeB-wide Oauth (lucifer), Securing MeB infrastructure - part 4
2022-05-23 14309, 2022
CatQuest
fin, go zas♉
2022-05-23 14317, 2022
zas
hey
2022-05-23 14348, 2022
Freso
BrainzBot: ping?
2022-05-23 14355, 2022
zas
On Monday, I moved aretha to ansible, during the new schema deployment
2022-05-23 14313, 2022
alastairp
CatQuest: known bug, I need to fix it
2022-05-23 14319, 2022
Freso
BrainzBot: ping
2022-05-23 14319, 2022
BrainzBot
Are you in need of my services, Freso?
2022-05-23 14329, 2022
zas
On Tuesday, we released another RC of Picard, stable version will be released tomorrow
2022-05-23 14318, 2022
CatQuest
!m picard-devs
2022-05-23 14318, 2022
BrainzBot
You're doing good work, picard-devs!
2022-05-23 14338, 2022
zas
I was off the remaining of the week, just keeping a distant eye to our infrastructure, thanks to mayhem & atj I had nothing to do ;)
2022-05-23 14349, 2022
zas
fin. akshaaatt ?
2022-05-23 14353, 2022
mayhem
I didn't do anything either. :)
2022-05-23 14354, 2022
akshaaatt
Hi Everyone!
2022-05-23 14308, 2022
zas
(mayhem : you did dns change for CAA)
2022-05-23 14335, 2022
mayhem
crap. so much for that clean record
2022-05-23 14308, 2022
akshaaatt
We have made explosive updates to MB Android App with the addition of the Spotify SDK to play tracks. Also, the tagger functionality has been updated to feature better results. A release has been deployed on the play store for you to try it out :)
