#metabrainz

/

      • BrainzGit
        [musicbrainz-server] 14mwiencek opened pull request #2582 (03master…relationship-editor-react): [WIP] Convert the relationship editors to React https://github.com/metabrainz/musicbrainz-serve...
      • mayhem has quit
      • DjSlash has quit
      • yvanzo has quit
      • DjSlash joined the channel
      • yvanzo joined the channel
      • mayhem joined the channel
      • Pratha-Fish has quit
      • krishan has quit
      • kuno has quit
      • kuno joined the channel
      • krishan joined the channel
      • Pratha-Fish joined the channel
      • alastairp joined the channel
      • yellowhatpro
        Moiinn!!
      • So some visible updates on BP implementation ヾ(@⌒ー⌒@)ノ
      • It's not complete yet, just some basic additions
      • > <@ashutosh3119:matrix.org> So some visible updates on BP implementation ヾ(@⌒ー⌒@)ノ
      • akshaaatt: do have a look sempai ヾ(≧▽≦*)o
      • Soon I'll update it with buttons on the bottom viewpager , and add media of the song etc
      • akshaaatt
        Perfect, yellowhatpro!
      • yellowhatpro
        Currently it works for songs on the local, also we'll work on albums and playlists
      • akshaaatt
        Great that we are aligned on the design.
      • yellowhatpro
        Yeahhh, so I do have some ideas like we can dragging the bottom viewpager upside to open the song screen etc
      • Like a bottom sheet or something
      • But ig we still will need a bottom nav route for for the brainzplayer that will show albums and all
      • I will soon make a pr related this week's work tho, there are a couple of changes that are remaining
      • s/dragging/drag/
      • trolley has quit
      • trolley joined the channel
      • agatzk has quit
      • agatzk joined the channel
      • Pratha-Fish
        Moin!
      • alastairp: soo what should we do next?
      • Any other methods for the artist conflation issue?
      • mayhem
        lucifer: ping me when you have a minute
      • lucifer
        mayhem: pong
      • mayhem
        hiya.
      • later today I want to spend time on moving the recent releases backend along.
      • lucifer
        hi!
      • mayhem
        you had pointed out a number of issues with the query that I created -- did you improve on those? where are things in general?
      • lucifer
        let me recheck.
      • afair, the existing query could be simplified to this
      • the other issues with the query in general were that it showed me a lot of re-releases, anniversary releases.
      • so probably better to use release_first_release_date or recording_first_release_date tables instead.
      • or maybe check it on release group level if possible?
      • mayhem
        I'll have to play with that, since I didn't think the first_release tables meshed real well with the rest of our cannonical data.
      • lucifer
        ah i see.
      • mayhem
        post query checking might in fact give better results, but I can have a look.
      • lucifer
        that's the only issue i can remember for now.
      • mayhem
        once I get that query done, I'll work on the API endpoint that fetches the data for all release (not a specific) user -- that still needs doing, yes?
      • lucifer
        yes
      • mayhem
        ok, cool. thanks for catching me up on this.
      • next up, I was thinking about how we manage cron entries.
      • we stagger them by time, but I wonder if we can just do roll-up action called "nightly" that does all the nightly tasks in a row so that we have less dead time during the night.
      • might be tricky since some things get queued and some block, but I think that will be my approach to keep generating models every night have not having i take quite so much time.
      • I'll play with that as well.
      • lucifer
        sure sounds good.
      • spark processes only 1 request at a time anyway so you could enqueue as much as you want and it'll catch up at some point.
      • mayhem
        exactly. I just need to make sure that the dumps and other non-spark tasks dont interfere. but we can also start dumps earlier. lots of options, but I think that will be my approach to improve that PR and get it out for testing.
      • lucifer
        agreed.
      • alastairp
        morning
      • ansh: did you just start up BB on wolf?
      • ansh
        yes
      • alastairp
        Pratha-Fish: hi, good afternoon. I'll take a look at your results later today and see if we can work out what the next possible step is. I think it might be a good idea to do an investigation into the items for which canonical mbid and mapping lookup are different
      • ansh: no problem, we just got a notification that all of the processes just crashed. I'm not sure what this behaviour is
      • Pratha-Fish
        alastairp: sounds good
      • I have exported a set of items for which canonical MBID and mapping lookups are different too
      • alastairp
        that's perfect
      • lucifer: mayhem: I recall a debug method for the mapper which provides more information about matches... am I remembering correctly?
      • monkey
        alastairp: I think the zombie procs are dur to using nodemon and webpack to rebuild sources and also restart the server upon changes
      • That's all I can think of
      • Looking at logs:
      • alastairp
        monkey: yeah, I wouldn't be surprised if that was the case, but does that mean that nodemon is broken?
      • monkey
        First time I see this personally
      • alastairp
        this doesn't seem like a normal behaviour to me even with a file-watcher
      • monkey
        But then again I don't really run it like that myself, and don't have a alert on zombie procs :p
      • alastairp
        ansh: as a test can you just shut down your bb server and start it again?
      • ansh
        okay
      • alastairp
      • Code reloading inside Docker generates a lot of zombie processes #881
      • monkey
        Ahaa
      • alastairp
        yes, all of the zombies have disappeared now
      • so, no clear answer to what might help this. perhaps it's related to signals not being passed to child processes correctly. unclear if this is explicitly a problem inside docker, or if it also happens on regular linux?
      • monkey
      • alastairp
        but I think this is even more different
      • we could run with an init process to try and help this issue described in 882, but I guess the other underlying issue is that nodemon is trying to restart _its_ child processes on filechange
      • not specifically a signal to nodemon
      • monkey
        > Nodemon kills the child process on rs and on SIGINT. However when it restarts due to file changes, it does not kill the child process.
      • alastairp
        and these issues are very old too - unless we're explicitly running an old nodemon, it seems that they may have changed all of this code a few times since
      • monkey
        I just checked, we're on a recent version of nodemon (2.0.2, current version is 2.0.18)
      • mayhem wonders why monkey is not in the desert
      • monkey is not deserting this year
      • alastairp hands monkey a desert and a dessert
      • mayhem
        ah, I see.
      • ansh
        monkey: For showing the CB reviews in BB site, do you have any design suggestions? This is the mockup that i proposed https://usercontent.irccloud-cdn.com/file/z2DdH...
      • lucifer
      • alastairp
        lucifer: that's the one I was thinking of, thank you!
      • lucifer
        mayhem: alastairp: monkey: i am around for a bit. can do a release. any PRs to merge?
      • alastairp
        nothing from my end today, thanks
      • mayhem
        Alas no.
      • lucifer
        alastairp, can you take a look at https://github.com/metabrainz/listenbrainz-serv... again?
      • mayhem
        Stupid paperwork keeping me busy
      • alastairp
        lucifer: yes, sure. I had a chat with monkey about this on wednesday too, perhaps he's got some further feedback on it
      • mayhem
        Yes, please.
      • lucifer
        ah cool, thanks!
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2035 (03master…add-timezone-support): create new table, modify UI and endpoint for timezone https://github.com/metabrainz/listenbrainz-serv...
      • monkey
        Yes I'd like to review #2044
      • lucifer
        makes sense, i'll release other PRs for now then.
      • BrainzGit
        [listenbrainz-server] release 03v-2022-07-04.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • reosarevok
        bitmap: wow, 14k lines :D
      • yvanzo: I'll assume there's nothing more for docker given there's nothing merged to master and just release that
      • ansh
        alastairp: I've removed the merge conflicts because of mbstore in CB#434
      • BrainzBot
        Fetch edition group from BB database: https://github.com/metabrainz/critiquebrainz/pu...
      • ansh
        Can you give some suggestions for CB#401? This is needed bec BB would need average ratings from the API
      • BrainzBot
        CB-427: Support entity endpoint in the API including average rating: https://github.com/metabrainz/critiquebrainz/pu...
      • BrainzGit
        [musicbrainz-docker] release 03v-2022-07-04 has been published by 14reosarevok: https://github.com/metabrainz/musicbrainz-docke...
      • zas
        alastairp: what's the status of frank to flobot migration? Do you need help on it?
      • alastairp
        zas: sorry, I didn't get back in contact with you last week
      • acousticbrainz.org is now running on flobot, mayhem did the DNS switch for me
      • frank is still running ftp.acousticbrainz.org, but now that we are putting dumps in aretha I think that we can just remove this domain and update the links
      • zas
        please do, so I can retire frank and order rex (rudi's clone / second part of new gateways). I'll be (very) busy this week and next one, moving to a new house, but I wish I can work on new gateways second part of July and test & validate redundancy. My goal is to replace kiki & herb asap.
      • alastairp
        yes, I didn't bother you too much because I knew that you were moving, maybe we can coordinate for a few hours when you are free to shut down/cancel frank? (you tell me when you are free)
      • mayhem
        i can help with that.
      • alastairp
        ok, fine. mayhem, let's coordinate tomorrow perhaps then? otherwise I don't think we need zas for anything else
      • mayhem
        sure.
      • I know zas' pain all too well. my turn to help out.
      • zas
        mayhem: thanks :) I'll be more or less around this week though, until Saturday, then serious stuff is starting, final sprint should end on 14/15th (move will/should be completed). Extra unexpected stuff happened, today I'm trying to sort out a Brazil-ish situation with French National Education / schools / kids stuff... (in short, someone somewhere didn't do his job, and my son is not registered for next year school as he should have).
      • CatQuest
        what is a Brazil-ish situation? are you moving to Brazil??
      • alastairp
      • zas
        alastairp: yes ;)
      • CatQuest: recommended film, btw
      • mayhem
        lucifer: crontab reorged for 2046, please have a look.
      • mayhem sets a timezone for himself on LB
      • zas
        outsidecontext: still ok for the release tomorrow?
      • thevar1able has quit
      • thevar1able joined the channel
      • agatzk has quit
      • agatzk joined the channel
      • monkey
        ansh: Regarding the mockup for showing reviews on BB: That looks pretty good ! I would like to make sure that we have as much a homogenous look between CB and BB as possible. I know alastairp was talking about adding short excerpts of the review text like you did in the mockup, so let's try to make them look similar once that is implemented
      • reosarevok
        bitmap: sorry about sending comments separately and not in a review, I didn't know how much I was going to look through so I started like that and now it seems silly to change :D
      • ansh
        monkey: Understood
      • bitmap
        reosarevok: not a problem
      • monkey
        ansh: looking at CB quickly, we could try to go closer to the look of reviews in the browse reviews page
      • Especially if they are modified to add an excerpt