Can I get the access to blog system to post the final eval blog??\
intrnl_[m] has quit
yellowhatpro has quit
treeshateorcs[m] has quit
riksucks has quit
heyarne[m] has quit
kepstin has quit
tandy1000 has quit
elomatreb[m] joined the channel
riksucks_ joined the channel
CatQuest
yellowhatpro_: ping Freso about that I think
kepstin joined the channel
treeshateorcs[m] joined the channel
riksucks joined the channel
riksucks_ has quit
tandy1000 joined the channel
yellowhatpro joined the channel
heyarne[m] joined the channel
riksucks has left the channel
intrnl_[m] joined the channel
yellowhatpro_
okii
riksucks_ joined the channel
riksucks_ has quit
riksucks2 joined the channel
riksucks joined the channel
riksucks2 has quit
riksucks_ joined the channel
riksucks_ is now known as riksucks22
riksucks22 is now known as riksucks_
riksucks is now known as riksucks1
riksucks_ is now known as riksucks
riksucks
yellowhatpro: hello, if you need the blog for the GSoC submission too, Freso will give you a link where your blog will be published later, and you can put that link in your gsoc submission.
yellowhatpro
Ohh okk .. thanks riksucks (≧∇≦)ノ
mayhem
moooin!
CatQuest has left the channel
CatQuest joined the channel
CatQuest has quit
CatQuest joined the channel
lucifer: what reviews need my attention?
lucifer
mayhem: nothing much currently but LB#2103 has many changes since last review so probably best to re-review it. i know about the test failures and will open a separate PR to merge before this to fix the underlying issue.
alastairp: mayhem: monkey: hi! in case you all are available now, can we prepone the LB meeting a bit? my internet connection is likely to become worse later in the day due to some unforseen situation.
alastairp
hi, I don't think I've ever used prepone
monkey
I like "prepone" :)
I can be ready for a chat in 10min
alastairp
but I'm here for the next 2h before going home
monkey: btw, I forgot to add the dryhop until yesterday. we should _post_pone bottling
lucifer
now that i look it up on google, apparently its an "indian" verb
I'm in favor of logical use of modifiers…if it can be post- it can be pre-
alastairp
or removing dis-
lucifer
alastairp: "interestingly", i hit another *listen submission json validation* bug while doing the MsB PR, ended up spending some hours on it before i understood what was going on. the test i added passes in isolation but not when run together with others so probably haven't reached the bottom it yet.
alastairp
hmm, right. I've also found some tests which work when run together, but not in isolation
some shared setup context I guess
lucifer
indeed but thats the secondary issue, the primary issue was a quirk in duration parsing.
we convert to int while checking but do not assign it back to the orginal json
so duration field in original json can pass validation but still be an integer in a string. ideally, i'd reject string fields here but api compat needs it...
alastairp
hmm
right, we check that it "can be parsed as an integer", but that could be either an int or a string of an int?
lucifer
yup
alastairp
and then it must be something else in the db for reasons?
we dont it currently anywhere but intend to in future. in recommendations etc. there a cast will be needed anyway due to historical string values in the field
alastairp
did we have a PR where we finally forced a particular type for all fields? it sounds familiar but I can't remember
it failed the MsB PR because duration is now a part of MsB and i was believing it would be an int there. since that's for new listens, i'll fix this duration parsing before merging that PR so that i can continue the assumption.
iirc we added documentation for type of fields but not additional checks to the api.
alastairp
ok, got it
lucifer
btw i ran thr msb Transfer script, it took 2.5 hours to transfer entire msb to ts.
reosarevok
bitmap: how do you feel about the relationship editor PR btw?
Is it getting there? Should we test it a bit more, then put it on beta? Or is it still not there, and we should not wait and put out a beta with other stuff for now?
lucifer
will run again after releasing the PRs to incrementally update.
odnes has quit
bitmap
reosarevok: it's been ready for review & I don't have any TODOs left on it, so I'd like it to be tested more by users at this point
reosarevok
So
I test it a bit more today, and if it seems ok we merge to beta and wait to see what breaks?
If it was deleting data or something similarly bad I think the few testers would have found it already, at least
bitmap
sure :) the latest version should be running on test.mb already
ZaphodBeeblebrox
[15:12] <monkey> I'm in favor of logical use of modifiers…if it can be post- it can be pre-
this sounds sensical to me
:D
odnes joined the channel
wait is this the relationship editor that messes up the order of everything? :(
[bookbrainz-site] 14dependabot[bot] opened pull request #880 (03master…dependabot/npm_and_yarn/redis-4.3.1): chore(deps): bump redis from 3.1.2 to 4.3.1 https://github.com/metabrainz/bookbrainz-site/p...
[bookbrainz-site] 14dependabot[bot] closed pull request #879 (03master…dependabot/npm_and_yarn/redis-4.3.0): chore(deps): bump redis from 3.1.2 to 4.3.0 https://github.com/metabrainz/bookbrainz-site/p...