#metabrainz

/

      • exoticchill joined the channel
      • exoticchill has quit
      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 opened pull request #81 (03main…handle-deleted-playlist): Improve spotify playlist handling https://github.com/metabrainz/troi-recommendati...
      • Arsen has quit
      • Arsen joined the channel
      • [musicbrainz-server] 14reosarevok opened pull request #2746 (03master…MBS-12716): MBS-12716: Output the right JSON-LD @context https://github.com/metabrainz/musicbrainz-serve...
      • yvanzo
        O’Moin
      • reosarevok
        lucifer, alastairp: where are we storing the twitter dumps?
      • yvanzo: moin!
      • lucifer
        reosarevok: i haven't received any so far so didn't think of that.
      • reosarevok
        Ok, the MB one is ready apparenty
      • Apparently too
      • elomatreb[m] has quit
      • elomatreb[m] joined the channel
      • mayhem
        moin moin everyone!
      • BrainzGit
        [troi-recommendation-playground] 14amCap1712 merged pull request #81 (03main…handle-deleted-playlist): Improve spotify playlist handling https://github.com/metabrainz/troi-recommendati...
      • [troi-recommendation-playground] release 03v-2022-11-21 has been published by 14amCap1712: https://github.com/metabrainz/troi-recommendati...
      • [listenbrainz-server] 14amCap1712 opened pull request #2260 (03master…fix-daily-jams): Improve daily jams error handling https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
      • that was quite interesting. I bet aerozol will snooze his way right through this for a 100% score.
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #2259 (03master…fix-filter-artist-credit): Revert "Use artist_credit_id instead of artist mbids for artist credit filtering" https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] 14amCap1712 merged pull request #2260 (03master…fix-daily-jams): Improve daily jams error handling https://github.com/metabrainz/listenbrainz-serv...
      • mayhem
        aerozol: I've made a couple more minor edits/comments on the target audience doc. what's next for the document?
      • reosarevok
        mayhem: heh. I got bronze only
      • Embarrassing :D
      • mayhem
        I think I would've done far worse had it not been for monkey's influence on me.
      • reosarevok
        There were honestly a fair amount where I was like "this is the same picture twice"
      • mayhem
      • wargreen has quit
      • wargreen joined the channel
      • BrainzGit
        [listenbrainz-android] 14yellowHatpro opened pull request #1 (03main…bp-MOBILE-86): added new properties in Song class https://github.com/metabrainz/listenbrainz-andr...
      • yellowhatpro
        akshaaatt: sempai we need to create a new branch for this, I shall some more modifications as well. This one PR was targetted for MOBILE-86 issue
      • BrainzBot
        MOBILE-86: Track and disc tags not read https://tickets.metabrainz.org/browse/MOBILE-86
      • monkey
        In today's edition of "WTF is my test suite doing‽", not only did I have tests failing in CI while all tests pass locally, and no way to know which test was failing in CI, now it looks like it is running tests that do not exist on the branch being tested…
      • I'm guessing perhaps there is a cache issue somewhere in CI. lucifer have you seen this before?
      • lucifer
        monkey: why do think its running tests that aren't on this branch?
      • iirc the CI runs a version of the branch merged with the master, so if your PR branch is out of date that's possible to happen.
      • monkey
        See the warnings about `js/src/personal-recommendations/PersonalRecommendationsModal.tsx`, a file that does not exist in the react-18-update
      • Ahhhh
      • I didn't know that :) Indeed then that's what's happening, and would explain my other fantom bugs, thanks !
      • lucifer
        👍
      • monkey updates the PR
      • monkey
        That does not seem like a safe thing to do. Any way we can change that behaviour?
      • I've been pulling my hair for a couple of days trying to figure out why my tests were failing in CI
      • lucifer
      • will need to add an if probably because these works run on pushes to master as well, not just PRs.
      • monkey
        Thanks, I'll look into it
      • lucifer
        but yeah possible. i have been bitten by this previously as well but i guess it makes sense to see if tests will fail after merge. no strong preference though
      • i can update the actions today or tomorrow if it helps. i'll be needing your help on some UI stuff anyway :)
      • *ui stuff very soon
      • monkey
        I see why it is set up that way. It's either 1) run test against the content of the branch, devs should remember to keep branch up to date (which is sometimes not easy) or 2) risk having failing tests after merging to master.
      • On possibility would be to require that the branch be up-to-date before merging, but I don't know if there is an automated check for that
      • One*
      • Or perhaps we have two separate test suites, one against current branch, one against branch merged with master
      • None of these solutions seem ideal
      • mayhem
      • lucifer: ^^ if I wanted to order the items in the array agg, how would I do that? is it possible to reference a JSONB object from the ORDER BY clause?
      • lucifer
        array_agg(jsonb_build_object(...) ORDER BY rr.position ... so on)
      • i.e. add ORDER BY inside array_agg
      • mayhem
        that... seems like magic.
      • mayhem tries it
      • lucifer
      • mayhem
        works. thanks!
      • yeah, my problem is that I see these things in the PR, but then can never recall *Where* I saw them.
      • monkey
        HALLELUJAH React 18 PR tests are passing!
      • Gonna need more eyes on that one… https://usercontent.irccloud-cdn.com/file/u7MZP...
      • Anyone with React/Jest experience, please review a handful of files and let others know which files you reviewed :)
      • monkey goes pack his suitcase
      • alastairp starts preparing to come home...
      • BrainzGit
        [musicbrainz-android] 14dependabot[bot] opened pull request #159 (03master…dependabot/gradle/hilt_version-2.44.2): Bump hilt_version from 2.44.1 to 2.44.2 https://github.com/metabrainz/musicbrainz-andro...
      • monkey
        Like two ships in the night, alastairp !
      • BrainzGit
        [bookbrainz-site] 14tr1ten opened pull request #902 (03master…fix/delete-revision): Fix: Deleting entity crashes the site https://github.com/metabrainz/bookbrainz-site/p...
      • alastairp
        bon voyage monkey !
      • lucifer
        monkey: should i put react 18 PR on test.lb?
      • monkey
        Why not :)
      • Thanks lucifer !
      • And a million thank yous for the hint about the merged-branch-tests thing, it was driving me nuts
      • kellnerd joined the channel
      • kellnerd
        "Can't Unsee - 7330 - Rank GOLD (top 10%) - Completed in 00:21:44 - You are 200 points away from platinum" - I think I only had three or four designs wrong :)
      • Setting a new bar for aerozol, although kiwiirc won't let me upload a proof screenshot right now.
      • Freso
        <BANG>
      • It’s World Television Monday!
      • I have not received any mailed in reviews, so the usual people are up: yvanzo, zas, atj, lucifer, monkey, alastairp, reosarevok, bitmap, akshaaatt, mayhem, yellowhatpro, Pratha-Fish, riksucks, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP. :)
      • yvanzo: Go!
      • yvanzo
        Hi!
      • Last week I looked into security alerts, closed 24 SEC tickets, merged 3 related pull requests.
      • aerozol
        Ata mārie Freso, I'll go too thanks!
      • yvanzo
        99 more SEC tickets have been closed by bitmap, lucifer, mayhem, monkey, and zas.
      • alastairp
        Freso: I'm on holiday please take me off!
      • yvanzo
        There still are 140 open SEC tickets, all of which are now assigned.
      • aerozol
        Wow team, that's a lot of closed tickets
      • yvanzo
        So thanks to all, keep it up, half of the way has been made already!
      • Also investigated an incident with 5xx codes on MB website with zas.
      • Plus various support and some MBS PR reviews.
      • aerozol: SEC tickets can be quickly closed, it doesn’t necessarily require a patch, just to be investigated.
      • Fin, go aerozol!
      • aerozol
        Hi all! Can't sleep so here I am 😝
      • Freso
        (Still up: zas, atj, lucifer, monkey, reosarevok, bitmap, akshaaatt, mayhem, yellowhatpro, Pratha-Fish, riksucks, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP.)
      • yvanzo
        (because there are false positive some alerts are about the same dependencies)
      • aerozol
        Last couple of weeks I've been working a lot on the LB redesign with monkey, it's coming along. Heavily simplifying the menu but making sure all the interesting stuff is still very near by, seems to be the way to go
      • I'm tandem, working on a 'target audience' doc with monkey and mayhem that is bringing up some interesting questions
      • akshaaatt likes being targeted as an audience
      • mayhem
        working with me always brings up interesting questions
      • aerozol
        Made a MB and MeB slide template - if you give presentations please let me know if I can add any others or make changes
      • mayhem
        thanks for doing that. I'm looking forward to using those next time I need to give a talk
      • aerozol
      • Bit of CB moderation
      • The door is open for more template requests as well all
      • akshaaatt: go!
      • akshaaatt
        Hi Everyone!
      • I made the setup for deploying the LB android app and cleaned up the repo further
      • I’ll look to make an internal/test release of LB first and collect feedback from people on what more to remove from the app before we go to production
      • I also tried adding coverflow to the widgets and looked at making the widgets lightweight to load. Can’t promise much on that yet though
      • Other than that things look great! Thanks to yellowhatpro for continuing to work on the LB android app! Amazing work from his side
      • Go yellowhatpro !
      • yellowhatpro
        hello everyone!! ヾ(≧▽≦*)o
      • Last week was pretty busy with college and intern stuff.
      • On weekend I worked on the issue MOBILE-86 and created a PR regarding the same
      • BrainzBot
        MOBILE-86: Track and disc tags not read https://tickets.metabrainz.org/browse/MOBILE-86
      • yellowhatpro
        I look forward to more bug fixes and optimisation stuff , LB-android is gonna be a hit ヾ(@⌒ー⌒@)ノ
      • That's all from my side. riksucks next ??
      • riksucks
        hi guys!
      • I worked on the playlist view and am working on including the NamePill element I wrote for recommendation modal
      • in the playlist view
      • making the UI more unified, I will have a PR by tomorrow, that's it tbqh, fin
      • lucifer: do you wanna go next?
      • lucifer
        sure. hi!
      • Freso
        👀
      • lucifer
        last wee, I worked on fixing bugs in the cover art query in the metadata cache, further improved error handling in daily jams, fixed an issue in TS writer. also worked on adding an api so that users can mark artists/albums/recordings that should not be recommeneded to them,
      • monkey
        Weee !
      • lucifer
        lastly, worked on adding a cron job to look for msids which have been mapped and update that in various places. that's it for me.
      • monkey: next/
      • monkey
        Hello !
      • Freso
        (Still up: zas, atj, reosarevok, bitmap, mayhem, Pratha-Fish, CatQuest, Shubh, Freso – anyone else who wish to give review, please let me know ASAP.)
      • monkey
        I spent pretty much all of last week (!) working on updating each front-end test in ListenBrainz as part of the React 18 update PR (LB#2233) Such a PITA that was!
      • BrainzBot
      • Pratha-Fish 👀
      • monkey
        Finally finished today, tests are passing and now I can live again. > feelsgoodman.gif
      • Considering this modifies the entire test suite I would appreciate some help reviewing the changes. If a few people review a handful of files we can make quick work of it.
Anyone with some React experience, please help, you're my only hope…
      • I also helped lucifer improve/fix some of our code to fetch cover art in LB.
      • Had a great video chat with aerozol and reviewed some aspects of the redesign. I'm looking forward to the new improved UI and UX !

      • Spent some time reviewing SEC tickets — thanks yvanzo for dispatching!
 Plus a sprinkle of PR reviews and other repo upkeep.
      • aerozol
        Ooh yes great meeting!
      • monkey
        I'm flying away to the US tomorrow morning; I'll be on-and-off for the next two weeks, but responding to messages when I can (at west coast work times).
That's me done !
      • bitma: go go go !
      • bitmap even