mayhem, alastairp: just a heads up, i am going to run the query from LB#2279 on the db. expected invalidation's are ~22M out of total 75M rows therefore i am creating a copy of the original table first, just in case we discover something was wrong.
Is this something we could improve somehow, it seems to me adding new indexes cost a lot cpu-wise, on all cluster members
d4rkie joined the channel
jivte has quit
d4rk has quit
vibhoo_24 has quit
monkey
mayhem, lucifer, alastairp, aerozol: I was looking into how to add social media sharing buttons for YIM without loading third-party javascript as discussed during the summit.
We can pretty easily add buttons to share a page URL (user's YIM page) + title/text and a generic image (with OpenGraph `<meta>` tags in the html), which requires us to host that image somewhere and point to its URL.
I suppose that restricts us to non-user-specific images, unless we want to generate and store an image for each user (which I assume wouldn't include cover art anyway). Are we OK with the non-user-specific image sharing?
mayhem
non-user specific is pretty trivial, no? I mean that just means linking to an image that is part of YIM, right?
monkey
Yes
I.e. the header withe this is fine doggo
Maybe a small tagline with a short explanation
mayhem
yeah, easy. and do we actually have any generated images for users?
We could ship some of the new cover arts for people, but SVGs don't share as nicely...
jasje joined the channel
jasje
akshaaatt: Any recommended addons or actions for the pr on listenBrainz?
akshaaatt
Hi jasje! It looks good to me. Let me just test once and then merge
jasje
okay and for future (after my exams) i would converting the settings to composable activity and getting rid of the deprecated OnAttach function bec i think playstore usually isnt happy about the deprecated functions.
is this what i should do?
akshaaatt
Deprecated function aren’t a problem until and unless playstore sends the devs a warning in general, asking to eliminate those.
I think we should focus more on features for the app
One thing which we would like is Year in Music to be available from the app
yvanzo
zas: It seems to be expected. It should hopefully improve with Solr 9. It also brings a way to throttle updates.
jivte joined the channel
jasje
akshaaatt: can you brief me on this feature anytime soon?
also just fixed the onAttach deprecated function pushing changes now.
vibhoo_24 joined the channel
vibhoo_24 has quit
rdswift
<monkey> "... two radio options: "now" and "past listen". Next to past listen you can put that date-time select component": Or perhaps just include the date/time picker and default it to "now"?
monkey: mayhem: I think we need to let people share their personal stats
For yim
mayhem
yes, clearly. but what parts of those are images? do they contain cover art?
aerozol
I think they should contain cover art where appropriate... Which I now realize may be a concern?
I've seen a few Spotify yim pics without images so I guess it's not necessary. I could mock up some stuff. How much work do we want to put into the shareable images monkey? Since we don't want to overwork ourselves!
lucifer
iirc spotify shares had only had 1 or 2 images and people still liked it. if cover art is an issue.
aerozol
We could do some similar stuff with just text but it would need a bit of work to look nice. But maybe the ground work was done by mayhem and monkey already with the colorful top 10 text 'grids'?
jasje has quit
mayhem
as long as YIM uses the output of the art api endpoints and embeds SVGs files, we're good to go.
if we need a new composition, send me the SVG files and I'll get a PR in.
aerozol
Fun!
mayhem
got something in mind?
I've got some spare time this evening, could make it happen quickly.
lucifer
i hate the part that we can't share to instagram from web :(. i guess twitter then ...
mayhem
what we need is a "share screenshot" function. the user loads that on mobile and the shares to instagram. should be an acceptable process, methinks.
any prs that are ready lucifer ?
aerozol
I haven't used insta in ages... Guess we would have a download option for the same images anyway? Can you upload those to insta?
lucifer
nope. all merged for now.
aerozol
Hmm I'm a bit hungover mayhem so having something for you to implement tonight (this morning) is probably too ambitious :D
mayhem
aight. enjoy the hangover. :)
aerozol
Thanks! Hah
BrainzGit
[musicbrainz-server] 14reosarevok opened pull request #2775 (03master…MBS-12767): MBS-12767: Convert relationship attribute type edit form to React https://github.com/metabrainz/musicbrainz-serve...
reosarevok
lucifer: why not instagram from web? I thought Instagram allowed browser uploads now
lucifer
reosarevok: huh, i wasn't aware of that. i'll check if thats possible.
tandy1000
<reosarevok> "lucifer: why not instagram..." <- dont think so
reosarevok
I dunno, it shows me a "Create" button for a new post?
I haven't tried it tho
tandy1000
i think it says go to the app
or at least it did a few months ago
reosarevok
I checked, it gives me an upload image button, lets me apply filters, etc
reosarevok shrugs
lucifer
reosarevok: oh i think we aren't on the same page. the issue is that 3rd party can't upload to instagram, they probably have an internal api to allow uploads from their own site.
reosarevok
Ooooh, gotcha
lucifer
the public api for sharing is only for android and ios apps
reosarevok
Well, you can have an instruction to download + upload :p
But yeah, not the same
rain0r has quit
rain0r joined the channel
mayhem
lucifer: I'm looking at the artist similarity data and I really think we need to change how we treat artists.
we're getting individual band members of the bands in similar results and thats not quite what people would expect.
should we be doing similarity on the array of mbids? we're doing it on single artist mbids right now, yes?
vibhoo_24 has quit
vibhoo_24 joined the channel
vibhoo_24 has quit
aerozol
Just had a shower thought re. socializing LB without having to deal with a dreaded chat box. What about allowing people to react to people's listens with the full array of emojis? Reasonably 'safe' and actually quite versatile