#metabrainz

/

      • monkey
        You can try creating that file manually as they did in that PR #104
      • And if that solves the issue open a PR forreact-datetime-picker
      • jivte
        actually this fix i also experimented
      • but no luck :(
      • so for the time being using a dummy declaration
      • monkey
        OK
      • vibhoo_24 joined the channel
      • Freso
        alastairp: Going to close all my MeB tabs for a couple of hours now until the meeting. Might be better if you send me an e-mail if you have questions.
      • alastairp
        Freso: OK, I'll prepare some notes or we can talk tomorrow. I guess that means that none of the botbot items from the docsprint were on your radar for last week?
      • agatzk joined the channel
      • Thuraabtech joined the channel
      • vibhoo_24 has quit
      • reyku joined the channel
      • serial-ata joined the channel
      • jivte
        monkey: while updating snapshots getting this error ( TS2307: Cannot find module 'react-datetime-picker/dist/entry.nostyle' or its corresponding type declarations. import DateTimePicker from "react-datetime-picker/dist/entry.nostyle";
      • getting this error
      • reyku has quit
      • vibhoo_24 joined the channel
      • jivte_ has quit
      • BrainzGit
        [musicbrainz-android] 14dependabot[bot] opened pull request #192 (03master…dependabot/gradle/com.google.android.material-material-1.9.0-alpha01): Bump material from 1.8.0-beta01 to 1.9.0-alpha01 https://github.com/metabrainz/musicbrainz-andro...
      • [musicbrainz-android] 14dependabot[bot] closed pull request #182 (03master…dependabot/gradle/com.google.android.material-material-1.8.0-rc01): Bump material from 1.8.0-beta01 to 1.8.0-rc01 https://github.com/metabrainz/musicbrainz-andro...
      • reosarevok
        bitmap: ping
      • bitmap
        reosarevok: pong
      • reosarevok
        Remember how I told you to hide the attributes help link for dates-only?
      • bitmap
        yeah
      • reosarevok
        I just took another look at prod, and noticed an additional help link:
      • By the dates
      • Which I guess you accidentally dropped when converting, and I didn't even remember existed so never noticed
      • So we could re-add that instead :)
      • bitmap
        ah I forgot about that too, I can add it back
      • reosarevok
        Thanks! No need to make a ticket I guess then
      • Also, remind me, do we have any docs about how to get files served by staticbrainz?
      • (since I guess eventually I'd want the OpenAPI specs I'm writing to be served by SB)
      • bitmap
        I believe there are some docs for that in syswiki
      • StaticBrainz.md
      • jivte has quit
      • jasje_ joined the channel
      • jasje has quit
      • but if those will be stored in the mbs repo then it should be pretty easy to modify the 'MusicBrainz Static Resources' jenkins job to upload them
      • monkey
        jivte: I tried locally, rebuilt the container first (`./test.sh fe -b`)`and re-ran the test script to update the snapshot (`./test.sh fe -u`), it worked for me.
      • reosarevok
        Oh, syswiki, ok
      • bitmap: also, lucifer suggested using https://github.com/swagger-api/swagger-ui/blob/... for showing the API docs
      • I guess we could just run that in /doc/API, but ideally I imagine we'd want to still have the MB style and whatnot on the page? Or should it just be a fully static HTML page?
      • (we don't have many of those except for tests like root/static/scripts/tests/web.html)
      • bitmap
        maybe we can customize the theme a bit? but I think static pages are fine for developer docs
      • vibhoo_24 has quit
      • reosarevok
        Oh, btw, I was thinking
      • If we can make the release editor accept seeding for everything (rather than just most things as now)
      • Wouldn't that make it trivial to add a "save and continue later" button, at least for additions?
      • I guess if it's all on React state, that'd also kinda be the same
      • bitmap
        yep, we could already do the same with the new relationship editor if we wanted (it already saves everything when you submit the form)
      • reosarevok
        Yeah
      • My worry with editing releases and the relationship editor is that there can be conflicts
      • (someone can change them in between)
      • But that won't be a problem with an addition, so probably easier to start there
      • bitmap nods
      • (plus with the relationship editor you usually can submit all to continue later at least)
      • bitmap
        I was working on finishing the docs for react state last week, will hopefully submit a PR before the meeting
      • reosarevok
        <3
      • Also, I haven't seen this before (Sentry): "RangeError: Attempt to access memory outside buffer bounds"
      • bitmap
        is that from the template renderer? that's the only place I can remember where we use Buffer
      • reosarevok
      • jivte joined the channel
      • Also, I wonder how unset_beta ended up there on sentry.metabrainz.org/organizations/metabrainz/...
      • bitmap
        yeah it is, looks like the perl sent less data than it expected. we really need to modify the template renderer to include the URL in the setry data
      • I'd guess a script or someone modifying the URL by hand
      • vibhoo_24 joined the channel
      • vibhoo_24 has quit
      • reyku joined the channel
      • reyku has quit
      • BrainzGit
        [listenbrainz-android] 14dependabot[bot] opened pull request #37 (03main…dependabot/gradle/room_version-2.5.0): Bump room_version from 2.4.3 to 2.5.0 https://github.com/metabrainz/listenbrainz-andr...
      • [listenbrainz-android] 14dependabot[bot] opened pull request #38 (03main…dependabot/gradle/com.google.android.material-material-1.9.0-alpha01): Bump material from 1.8.0-beta01 to 1.9.0-alpha01 https://github.com/metabrainz/listenbrainz-andr...
      • [listenbrainz-android] 14dependabot[bot] closed pull request #28 (03main…dependabot/gradle/com.google.android.material-material-1.8.0-rc01): Bump material from 1.8.0-beta01 to 1.8.0-rc01 https://github.com/metabrainz/listenbrainz-andr...
      • vibhoo_24 joined the channel
      • reosarevok
        bitmap: is that something we haven't done because it's hard, or we just never spent the 10 minutes? :)
      • jasje_ has quit
      • yvanzo: I'm writing a ton of suggestions on the URL document, hope it's not too annoying :D
      • aerozol
        Ata mārie tīmu!
      • mayhem: Did you see the extended mockup for the Fresh Releases design? Just looking at your comments now, I’ll do another version on that ‘page’ in the figma
      • yvanzo
        reosarevok: Take all the time you need. It took me about two days.
      • aerozol
      • reosarevok
        yvanzo: most of it looks like a big improvement, anyway, so thanks!
      • KassOtsimine
        'oh did the meeting start already
      • aerozol
        I don’t think so :D
      • alastairp
        reosarevok: do you want a review on https://github.com/metabrainz/mb-solr/pull/52, or is that waiting on yvanzo?
      • reosarevok
        KassOtsimine: it's :59 :)
      • bitmap
        reosarevok: the latter I think, though it's annoying to test properly without setting up a local sentry instance
      • (could also throw it on test.mb though)
      • alastairp
        bitmap: can't we just create a new temporary project (we can talk after the meeting if you want)
      • mayhem
        aerozol: ah no, I didn't.
      • Freso
        <BANG>
      • It’s Measure Your Feet Monday!
      • (and apparently also Community Manager Appreciation Day)
      • I haven’t received any mailed in reviews, so…
      • People up: reosarevok, monkey, mayhem, yvanzo, akshaaatt, atj, lucifer, zas, alastairp, bitmap, vibhoo_24, jasje, Pratha-Fish, riksucks, CatQuest, jivte, yellowhatpro, Freso – anyone else who wish to give review, please let me know ASAP.
      • reosarevok: Go!
      • KassOtsimine
        dun wanna measure my feet :(
      • reosarevok
        alastairp (yvanzo): basically I'm waiting for yvanzo to decide what's best for the field names and then either I or he can merge
      • Hi!
      • Last week I mostly spent time on documentation (as one would hope)
      • alastairp
        you know what they say. big feet...
      • large shoes
      • CatQuest
        bwahaha
      • reosarevok slaps alastairp with a large arctic char
      • wtf is a char?
      • is that a fish?
      • aerozol throws a pompano
      • wtf guys XD
      • reosarevok
        I also worked quite a bit on testing (and somewhat improving) the relationship editor (the version on test.mb looks really nice IMO, thanks bitmap and aerozol)
      • CatQuest
        lmao
      • reosarevok
        And lately I've been looking into a decent set of interactive API docs using Swagger (thanks alastairp for starting the work and being a big help with the whole thing)
      • I'm not even done with artist, so this is going to take quite a while, and I'm afraid it's not going to be very easy to automate it from the code (it might be easier to actually generate bits of the code using the OpenAPI spec, if anything)
      • But it feels a lot more useful to me than the current wiki mess I spent a lot of time trying to get to a decent level without even getting there (all I can say is they suck less than they used to) so I'm happy with the progress
      • Oh, and I helped CatQuest a bit with merging a weird catch-all instrument which wasn't really working out
      • Speaking of, CatQuest, go? :)
      • CatQuest
        Meow! `😺`
      • aerozol
        reosarevok: So this is a system that would replace the wiki?
      • Sorry can talk after :)
      • alastairp
        aerozol: specifically for API docs, yes
      • CatQuest
        wait for documentaiton or everything?
      • :( I liek the wiki
      • Last week I looked through my backlog and cleaned it up
      • WE did some research and put in a merge for an old messed up catch-all instrument
      • I've also added heaps of aliases on instruments and have also added an instrument - this week I will be adding more bagpipes.
      • a note to everyone that if you are interested in a bagpipe (esp ones listed under "IROM") now's your chance to create a (sub)ticket: https://tickets.metabrainz.org/browse/INST-773
      • BrainzBot
        INST-773: Bagpipes
      • yvanzo
        aerozol, cc alastairp: just two pages of the wiki
      • CatQuest
        make sure it's not already in mb or already has a ticket in jira
      • also don't add novelties or ones with no info available, but else. go wild! ♑
      • fin ΦωΦ, go monkey
      • monkey
        Hi everyone
      • Last week I spent a bunch of time improving the BookBrainz user docs
      • reosarevok
        yvanzo: three, but that shows the docs suck if you might not even have found the third :D
      • !m monkey
      • BrainzBot
        You're doing good work, monkey!
      • monkey
        Diagnosed an issue with the live API docs for BB (problem was between my computer and my chair it turns out), so that's back online after a hiatus
      • yvanzo
        anyway not all the wiki
      • KassOtsimine
        oh good
      • Pratha-Fish wonders if KassOtsimine and CatQuest are the same 🗿
      • is indeed
      • Freso
        Pratha-Fish: They are.
      • monkey
        Looked at cleaning up the autogenerated JSDocs as well, which are pretty unreadable all jumbled up
      • aerozol
        Good to know! Though a Wiki refresh wouldn’t hurt let’s be honest!
      • Pratha-Fish
        ```wauw```
      • monkey
        Also accepted some help from brand new contributors to improve the developer docs (specifically for getting set up locally and troubleshooting install issues)
      • reosarevok
        Always the best way to figure out what's not working
      • KassOtsimine
        !m newbie contributers