#metabrainz

hi!

Haven’t looked at your most recent updates bitmap yet, but looking great!!

thanks aerozol :)

Last week I kept up the Documarathon about MB Solr and MB URL mainly.

(Still up: atj, vibhoo_24, jivte, yellowhatpro, jasje, Freso – anyone else who want to give review, let me know ASAP. :))

Also completed and sent a review of Weblate ToS after they resolved technical issues.

bitmap, reosarevok and I had a video call about getting the MB dev team back together.

It was informal, mostly about communication and common expectations.

We will have our first development meeting here on Thursday.

It will focus on delivering the relationship editor obviously. :)

Fin, go atj!

hi

not much to report, i assisted zas with some issues bootstrapping the new discourse server

and wrote a pr which zas had already created :)

jasje?

Hi everyone!

Last week i fixed 1 bug

1 Ui fix

and if we count 1 hour before this meeting as last week

2 bugs in total

!m jasje

You're doing good work, jasje!

not much going on since sentry is helping alot

!m sentry

You're doing good work, sentry!

lol

and looking forward to implement ui tests (akshaaatt?)

Obviously

thats it for me

(Still up: vibhoo_24, jivte, yellowhatpro, Freso – anyone else who want to give review, let me know ASAP. :))

jivte?

Looks like no jivte is around.

No vibhoo either.

yellowhatpro: Go?

Or not.

Freso: Go!

🙋

xD

Stay!

So I dealt a bit with answering questions about BrainzBot as well as writing up some docs for some of the basic administration of it via its admin interface. I sent them to alastairp earlier, so hopefully they will go into syswiki or somewhere? Idk.

Also cleared up some uncertainties about the Discourse upgrade.

Spent some time looking at reports and flags etc. as well as just generally keeping an eye on IRC, forums, e-mail, etc.

Sorry to hear that Freso!! But finally treatment!?

:o :hugs: freso

If you have any process or thing that you would like me to document or grant access to, please e-mail me and I’ll do my best to get it dealt with tomorrow.

[musicbrainz-server] 14mwiencek opened pull request #2817 (03beta…test): Merge relationship editor changes from the test branch into beta https://github.com/metabrainz/musicbrainz-serve...

aerozol: Only been 3 years since I first took contact. 🙃

Anyway. fin.

Take care Freso!

yes

(literally)

take care freso

Unbelievable. Finally there now. Hopefully it works the magic

And nothing from yellowhatpro, jivte, or vibhoo, so this concludes the reviews.

Thank you all for yours.

No more items on the agenda either, so this also concludes the meeting.

Thank you all for your time! See you around and take care!

</BANG>

Thanks!

jasje MOBILE-117

MOBILE-117: RuntimeException: Unable to create application org.listenbrainz.android.App: android.app.BackgroundServiceStartNotA... https://tickets.metabrainz.org/browse/MOBILE-117

Hope things go well for you Freso. Just curious, during your absense, who will be looking after the weekely meetings and where should be mailed in reports be addressed?

akshaaatt: ill have a look

rdswift: I will assume community-manager@metabrainz.org gets redirected to someone else, and that should probably be the address used.

👍

I assume the same for editor and community abuse reports?

rdswift: we'll work out all those details tomorrow. but I suspect that reosarevok and I will lead the meetings. unless you have a burning desire to do it. :)

No burning desire. ;-) ... But I can help if needed.

rdswift: Feel free to e-mail me at freso@ and I’ll look it over tomorrow. :)

No problem. I was just making sure that any loose ends were tied up before you take off. With all that's going on in your life, I can see how something might easily slip through the cracks.

heh, I appreciate someone else thinking about these things. :)

Truth be told, I'm better at asking the questions than providing the answers. ;-)

I mean, (and I mean this really) if I can do anything, really, to help please ask!

[bookbrainz-site] 14dependabot[bot] opened pull request #922 (03master…dependabot/npm_and_yarn/faker-js/faker-7.6.0): chore(deps-dev): bump @faker-js/faker from 7.2.0 to 7.6.0 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #923 (03master…dependabot/npm_and_yarn/jsdom-21.1.0): chore(deps-dev): bump jsdom from 20.0.0 to 21.1.0 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #924 (03master…dependabot/npm_and_yarn/rewire-6.0.0): chore(deps-dev): bump rewire from 5.0.0 to 6.0.0 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #925 (03master…dependabot/npm_and_yarn/mini-css-extract-plugin-2.7.2): chore(deps-dev): bump mini-css-extract-plugin from 2.5.3 to 2.7.2 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] opened pull request #926 (03master…dependabot/npm_and_yarn/redis-4.6.3): chore(deps): bump redis from 3.1.2 to 4.6.3 https://github.com/metabrainz/bookbrainz-site/p...

[bookbrainz-site] 14dependabot[bot] closed pull request #904 (03master…dependabot/npm_and_yarn/redis-4.5.1): chore(deps): bump redis from 3.1.2 to 4.5.1 https://github.com/metabrainz/bookbrainz-site/p...

[musicbrainz-server] 14reosarevok merged pull request #2816 (03beta…MBS-12857): MBS-12857 / MBS-12858: Details for recent entities in autocompletes https://github.com/metabrainz/musicbrainz-serve...

bitmap: I expect this is not intended?

(the pink is some userscript I don't have disabled on test, but I assume that's not connected to the double green box)

oh you mean how there's two highlighted items?

Yeah

Sorry, maybe wasn't the clearest gif :)

one has keyboard focus (so will be selected if you press tab or enter) and the other is just a mouseover effect (I agree this is confusing and we should distinguish them somehow)

was thinking about how to do that yesterday actually, but nobody had brought it up yet so I left it alone :)

Hmm

Is it possible to move the keyboard focus with the mouse?

So that if I press Enter it'll select whatever the mouse is on?

aerozol might have some ideas too, dunno

I have to run in a sec, but it seems in the current setup it does what you’re saying reo - mouseover and keyboard selection is the same

Hmm doesn’t currently work with tab, just up and down arrows, is that what’s different?

wtf?

Tab confirms selection and moves onto the next field - which might be pretty good behavious. I’m not much of a keyboard editor though so can’t say for sure

> Have you considered the domain name HammerGroup.com ?

the spam/shit we get.

STOP

HAMMER TIME

honestly i find all the colours in the dordownboxes/selection kidna confusing

aerozol: if you move around with the mouse, it still keeps the top selection green - and if you click with the mouse it selects whatever you're on, but if you press enter or whatever it selects the first selected green box

(and you can move the selections separately if you both move the mouse and with the up/down keys)

reosarevok: yeah I got that from your gif! I was just describing how it works currently on prod

Oh, I see

Should have been clearer

And yeah, that's what happens in prod and I like it, sometimes I end up moving my mouse but then deciding that I want the one immediately over and moving with the arrow or something

I'm weird, dunno :D

But them being one and the same does seem clearer anyway

bitmap: are the selenium failures random you think?

I agree that current prod behaviour seems better (without actually testing both… I gotta run!)

yeah I could make it move the keyboard focus with the mouse so there's only one focus

aerozol: good running! :p

bitmap: that'd be sweet if it's simple

bitmap: also, did you have any time to look into readding the dates section help?

honestly I actually see reo's point, I will use the mouse and it hovers over something and I will use arrowkey to go up or down fro mthat

I rarely do it, but it has happened :D

hover/select/hover/whatever

yes

it's not hard but I used css for mouseover because it's a lot faster (to do it the other way we need events that run every time the mouse moves which also renders the entire autocomplete again)

but I'll see if there's a way to optimize it

I'm having deja vu of bookbrainz dropdown discussions

reosarevok: selenium failures might be legit, I'll check. and no I forgot about the dates thing! sorry

bitmap: is it like "optimizing" slow or "I can actually see this go slow" slow? :D

If the first, I'd implement it now and optimize later

And maybe you can look into adding the date stuff before we merge to beta? :)

So we don't forget again

I remember it feeling a bit laggy but not unbearable or anything

Ok, not a lot to say about the PR other than these two issues I guess :)

Left a few comments anyway

But minor ones

getting selenium tests set up again so I can debug those. dunno how much longer you'll be awake but I can either deploy beta tonight, or I could continue working on the menu highlight stuff and we could release early tomorrow

(tomorrow is prob better tho)

I might be off tomorrow during the day but I can find some time in the morning to test the stuff probably

np, I'll release the current stuff tonight and open a separate pr for the menu stuff then, I can just do another release tomorrow

Sounds good to me to

*too

The dates stuff is going in today then?

yup