#metabrainz

/

      • bitmap
        reosarevok: maybe they mean in the autocomplete results? but I'm not sure that changed from the old one
      • phw_ has quit
      • reosarevok
        Oh. I guess, but that's the same - do we even know how many results are there?
      • BrainzBot
        MBS-12866: Beta: Make grouping relationships more visible in dropdowns https://tickets.metabrainz.org/browse/MBS-12866
      • phw joined the channel
      • yvanzo
        Looking into post #5 by UltimateRiff which has 1 bug (possibly a regression) about “Change credits for other relationships”, 1 improvement suggestion for “Credited as”, 1 regression about edits submission delay.
      • bitmap
        I'm pretty sure we include a pager in the ws/js output
      • so it may be possible to improve
      • reosarevok
        Ok, then I can add a ticket
      • bitmap
        yvanzo: the edit submission delay might be MBS-12832
      • BrainzBot
        MBS-12832: Beta: Submit multiple (relationship) edits per request https://tickets.metabrainz.org/browse/MBS-12832
      • yvanzo
        Thank you
      • There is no ticket for “Change credits for other relationships” so I’m trying to reproduce it.
      • reosarevok
        I suspect they might be right that "change other credits" might not work on collapsed mediums
      • That might be a bug, or it might be a feature
      • yvanzo
        Is that new though?
      • reosarevok
        Well, collapsed mediums are new :)
      • For the relationship editor
      • But that might be consistent with "change other artist credits" in the release editor
      • bitmap?
      • yvanzo
        Ok, so it’s a new bugged feature, it qualifies as a beta bug at least.
      • bitmap
        I assume it's consistent in the release editor (can't edit anything until it's loaded)
      • yvanzo
        I confirm, opening a ticket now.
      • reosarevok
        I'm not sure it's bugged, I think it's the correct behaviour
      • But you can add a ticket so we can discuss it there :)
      • bitmap
        if the mediums aren't loaded, I guess we should disable the checkboxes, but if they're loaded and collapsed, it should probably work?
      • reosarevok
        bitmap: what happens if it's loaded, *then* collapsed?
      • IIRC we had an issue about that in the release editor, let me find it
      • bitmap
        I'm not sure but I'd intend for it to work at least
      • reosarevok
      • BrainzBot
        MBS-11811: Make Tracklist editing buttons behave consistently on collapsed mediums
      • reosarevok
        That's what I was thinking of
      • We intentionally changed the release editor behaviour to *not* run on collapsed mediums, since that could cause edits that are invisible to the editor until they submit
      • (and might be wrong, or at the very least unchecked)
      • bitmap
        hmm, right
      • not sure what should happen to the track selections if you select a mediumm and then collapse it
      • reosarevok
        Me neither. I guess we could automatically expand it again if something changes?
      • That could be a good compromise
      • bitmap
        yeah, maybe
      • reosarevok
        I don't think this is a "delay the release" issue, or even a bug necessarily
      • But a ticket would be good
      • yvanzo
        bitmap: Is there a ticket for dynamically loading numerous medium in the release relationship editor?
      • (dynamically/lazily)
      • reosarevok
        "expand all" like in the release editor?
      • bitmap
        there is MBS-7919 which I forgot about, but it's more about collapsing than lazy-loading
      • yvanzo
        I don’t know what you mean.
      • BrainzBot
        MBS-7919: Allow collapsing mediums in the relationship editor for big releases https://tickets.metabrainz.org/browse/MBS-7919
      • bitmap
        I'm not sure if there's one for the dynamic loading aspect
      • reosarevok
        Yeah, that should be set as in beta testing
      • bitmap
        don't see one with search
      • reosarevok
        Hmm, one thing that I saw in that thread re:accessibility, do text readers move by tabbing? Because the fact that tab selects the first autocomplete result might make a mess for blind people if so
      • yvanzo: I mean if you mean something like the "Expand all mediums | Collapse all mediums" options in https://beta.musicbrainz.org/release/0ee90972-7...
      • yvanzo
        bitmap: Would you prefer to edit MBS-7919 to mention lazily loading too, or have a separate ticket for it?
      • reosarevok
        Sorry, not release editor, release index, my bad
      • bitmap
        yvanzo: hmm, I think editing it is fine since they're pretty related features
      • reosarevok
        I would not, actually
      • I think that ticket is solved by the current editor
      • (I'd know, it's mine :D )
      • I would add an improvement ticket to add expand all / collapse all options to both the release editor *and* the relationship editor in one go
      • yvanzo
        The current release relationship editor doesn’t allow collapsing, or am I missing something?
      • reosarevok
        The current *beta* editor I meant :)
      • It already does what I asked for
      • The expand all thing with lazy loading is a different feature
      • jivte has quit
      • yvanzo
        We are only speaking about the release relationship editor here.
      • reosarevok
        (I'd also like that, but it's not an inseparable part of the other, as you can see by the fact the release editor has collapsing and expanding but no option to load all AFAICT)
      • yvanzo
        Or do you mean that lazy loading is implemented the same way for both the release editor and the release relationship editor?
      • reosarevok
        I mean neither has lazy loading now, and we should implement it for both :)
      • yvanzo
        (in beta)
      • reosarevok
        But that it is, IMO, a different feature than the collapsing / expanding option itselfd
      • *itself
      • And a different ticket
      • bitmap
        they both have lazy loading?
      • yvanzo
        bitmap: isn’t the beta release relationship editor doing lazy loading when there are too many medium?
      • reosarevok
        I mean, I assume the point is "let the user expand them all and load them in one go", because otherwise, both already do that :)
      • bitmap
        yes
      • yvanzo
        reosarevok: I cannot follow you.
      • reosarevok
        Ok, I'm not sure what the lazy loading issue is then :D
      • Sorry
      • I thought this was about having one button to lazy-load all mediums in one go
      • (Because as far as I can tell, it already lazy-loads each medium on demand)
      • So, sorry for the confusing talk :D
      • bitmap
        basically it will only load the first n mediums or tracks and the rest are only loaded once you expand them
      • yvanzo
        Example: Open https://beta.musicbrainz.org/release/434f8d49-e... Then go to the bottom, expand CD 4, it’s now loading.
      • reosarevok ^
      • reosarevok
        Yes, so what is the issue? :)
      • yvanzo
        You asked what is lazy loading.
      • bitmap
        the 'expand all' button is just a convenience feature for that, but not required for lazy loading
      • reosarevok
        Oh
      • Wait
      • Were you asking if we should *document* the feature with a ticket?
      • I thought there was a bug you were bringing up :D
      • For documenting that they lazy-load, sure, the same ticket works :D
      • But I'll add a ticket for expanding all :)
      • yvanzo
        There is a bug indeed, I’m just asking if there is a ticket for this new feature or if we should expand MBS-7919 to include this feature as these are closely related.
      • BrainzBot
        MBS-7919: Allow collapsing mediums in the relationship editor for big releases https://tickets.metabrainz.org/browse/MBS-7919
      • reosarevok
        Expand is fine
      • yvanzo
        Thank you
      • reosarevok
        Is the "bug" that "change all" doesn't make changes to unloaded mediums, or something else?
      • bitmap
        the fact that you can tick the checkbox when the medium hasn't loaded yet seems like a bug, at least
      • reosarevok
        Oh, ok
      • bitmap
        (but instead of disabling it, perhaps ticking it should load the medium)
      • reosarevok
        Yes, that sounds like a good idea to me
      • Checking -> load all and check it
      • yvanzo: does that seem like a good solution to you too? Or does it sound confusing?
      • bitmap
        since loading a 100 cd release takes a while though, you'd still be able to batch-add rels while it's loading (and they won't apply to all mediums)
      • reosarevok
        bitmap: what about shift-checking, load/expand all mediums in between?
      • yvanzo
        Probably but I’m not at solving issues for now, just trying to reference these.
      • reosarevok
        Hmm. Can't we disable batch-adding while stuff is loading?
      • bitmap
        I suppose we could
      • reosarevok
        That sounds like a recipe for issues, otherwise
      • yvanzo
        I’m leaving in ~1h from now, I hope to go through the community topic at least.
      • reosarevok
        So either remove the checkboxes when not loaded, or make them load it and check it but disable using them until loaded
      • I'll comment with that on the ticket once yvanzo opens it
      • (shift+tab not cycling inside the dialog but sending you out)
      • I'd probably expect it to cycle inside the dialog only, just not sure if it's a bug or an improvement :)
      • bitmap
        no, and there's an option to trap the focus so I think it might be easy to solve
      • assuming that doesn't affect being able to click on things or copy links outside of the dialog
      • reosarevok
        Ok. Adding a ticket for that
      • bitmap
        the 'change direction' button being moved seems to have gotten mixed reactions though
      • a keyboard shortcut might be a good idea
      • reosarevok
        I wouldn't be against that as well, if we're ok with starting to add shortcuts
      • I guess we don't currently have any?
      • Added MBS-12870 for the shift-tab issue
      • BrainzBot
        MBS-12870: Beta: Don't tab/shift-tab out of dialogs, but cycle inside them https://tickets.metabrainz.org/browse/MBS-12870
      • bitmap
        nope
      • reosarevok
        I keep writing the shit-tab issue, which might also be appropriate
      • bitmap
        lol
      • reosarevok
        I would talk to aerozol about shortcuts before adding them - I'm sure there's a lot that could be useful if we choose to go that way (e.g., expand/collapse all, lol)
      • But I'm always a bit worried about those because of sites that implement them in annoying ways which block basic features (sigh, discourse hijacking ctrl+f)
      • yvanzo
        bitmap: what is the threshold for not loading last mediums?
      • reosarevok
        Was it 100 total tracks?
      • Rings a bell, but
      • yvanzo
        (in the beta release relationship editor)
      • bitmap
        it loads up to 10 mediums or 100 tracks, whichever it hits first
      • reosarevok
        Adding a ticket for https://community.metabrainz.org/t/help-test-th... and the double siblings
      • bitmap
        i.e. if there's 150 tracks in the first medium it only loads one
      • reosarevok
        Oh, almost got it :D
      • bitmap
        but if there's 20 mediums each with 1 track it only loads 10
      • Sum has quit
      • regarding the autocomplete we should probably stop auto-selecting the first result when you focus
      • reosarevok
        MBS-12871 for the siblings issue
      • BrainzBot
        MBS-12871: Beta: relationships with the same phrase on both sides displayed split https://tickets.metabrainz.org/browse/MBS-12871
      • reosarevok
        bitmap: maybe. I guess that's actually new?
      • (or at least an autocomplete2-only thing)
      • bitmap
        yeah I think it's new
      • reosarevok
        Ok, I'll add a ticket for that too?
      • bitmap
        well, not quite