jasje_: You're only under members when you're here :) People disappear when they close IRC unless they use a permanent client like IRC Cloud
But the login is different from membership of a specific channel
jasje_
oh so i disappear too :(
yvanzo
jasje_: sorry, send HELP as direct message to NickServ
jivte_ has quit
jivte has quit
/msg NickServ HELP
reosarevok
Yes, but if you have registered your nickname, you can come back with the same one later and nobody else can take it
Check what yvanzo suggested, not sure what it tells you but it's probably of use :)
jasje_
hmm lets see
ill look into the docs
yvanzo
reosarevok: I was hoping for him to review this pull request first as I am self-convinced already :D
jasje_
That helps alot thanks reosarevok yvanzo
reosarevok
yvanzo: well, I think he's ok with adding testing (he has done so when I asked)
I was more wondering about the wording for the beginners :)
yvanzo
reosarevok: The two things we keep forgetting about are tests and docs.
I mentioned docs in the checklist, I thought tests would have their place there too, but it might be too elusive.
exactly, the template has to be a support for the beginners, not a barrier
reosarevok
Sure :) So I was wondering if the stuff I added under the new # Testing header seems like a good choice for beginners :)
*Adding* tests might actually be a good addition to the checklist, actually. While # Testing is more meant to be "what did you test when writing and checking the PR" even if you did not add a test for it :)
petitminion joined the channel
yvanzo
We could rephrase checklist to be not only "for draft" but for all needed steps before review?
reosarevok
Maybe? Wanna put up a PR with suggestions?
(or if you want, push something on top of mine)
yvanzo
Ok, I’ll push on top of it so we can backtrack if wanted.
reosarevok off for the day, can check something quick later in the evening if bitmap wants to deploy something to beta, otherwise more tomorrow
jasje has quit
rdswift
reosarevok, I can add something about MBID in the appropriate spots in the Picard docs regarding tags, including a link to the page on MB.org (but the link you provided shows as invalid for me).
jasje_ has quit
Also I just did a seach of the documentation on MB.org for "MBID" and it came back empty.
[musicbrainz-server] 14mwiencek merged pull request #2824 (03master…mbs-12874): MBS-12874: Don't split new relationships with one instrument or vocal https://github.com/metabrainz/musicbrainz-serve...
"<reosarevok> The doc links sometimes do a dumb." That must be what it's doing to me then because using your updated search url I still get an empty result. See https://imgur.com/a/WEzwb0D