#metabrainz

the goal is to toss the egregriously bad matches.

Mm.

I'd rather have no matches, than incorrect matches. the incorrect matches make us look bad.

We sure can have a chat about that. Maybe set up a test rig so that we can get more data on the quality of matches

yeah, lets do that.

If people want matches and we have none, they can link them to the MB recording :p

that

Yeah, it would be good to close that particular loop

[musicbrainz-server] 14reosarevok opened pull request #2933 (03master…MBS-10759): MBS-10759: Explain release data quality in editor https://github.com/metabrainz/musicbrainz-serve...

mayhem: about the first one, i had looked into it last week. it was already fixed in the new redesign so was waiting for the release to comment but then forgot.

mayhem: re the other answer, i guess it might make sense for some media players to distinguish on the track level instead of the recording level. however, with the canonical mapping stuff we have been going in the opposite direction in LB.

so i am not sure if it makes sense to allow feedback on the track level. especially since everything else in LB is based around recordings.

even for "album" level, we are preferred to go with a release group over release because that level of granularity is not suitable or expected by most LB users.

agreed.

will you rrespond to both?

sure

thanks.

hi reosarevok, please ping me when you are up for PR #2357

yvanzo: I'm aroundish, but probably going to eat a bit first. Ok in an hour or 1h30?

thanks

[listenbrainz-server] 14MonkeyDo opened pull request #2479 (03master…dont-load-userpageheading): Don't load UserPageHeading component https://github.com/metabrainz/listenbrainz-serv...

[troi-recommendation-playground] 14mayhem opened pull request #98 (03main…weekly-patches): Turn daily-jams patch into periodic-jams https://github.com/metabrainz/troi-recommendati...

[musicbrainz-server] 14reosarevok opened pull request #2934 (03master…MBS-13058): MBS-13057 / MBS-13058: Improve the application/revoke-access page https://github.com/metabrainz/musicbrainz-serve...

mayhem: is it going to be called periodic jams? If so, it has to be a periodic table but with jam jars, clearly

I think this classifies as boss-abuse.

yvanzo: around now

reosarevok: basically it is lacking test coverage

What test coverage would you want?

IIRC it had a fair amount of tests but maybe not wide enough

There are multiple cases mentioned in the PR and commit messages but untested.

reosarevok: Another thing: to allow an editor editing an edit note, shouldn’t we check ADDING_NOTES_DISABLED_FLAG?

Hmm. That sounds like a good point. I'll check

reosarevok: For your previous question: The section "Testing" of the PR should be used for test coverage.

[listenbrainz-server] 14MonkeyDo merged pull request #2479 (03master…dont-load-userpageheading): Don't load UserPageHeading component https://github.com/metabrainz/listenbrainz-serv...

From then we can figure which tests are missing and I can help with writing some too.

I guess I'm a bit confused about what you expect to see. Something like "test X in file Y tests method Z" for every thing?

If so, I guess I can try, I just haven't seen us do that before :)

We did that before

Maybe I just don't remember it then, my bad

It's not about "test file/method", it's about use cases.

Sure, but I thought the use cases were documented by actually adding detail on what is being tested and labels to tests

A single line about testing is fine for small patches only.

I guess when I opened this I expected that the CI tests kinda overrode that and the point was usually to specify in more detail what was tested manually when CI tests were not available / added :) I think the coverage in the ModifyNote CI test is fairly exhaustive, anyway, but if you see something I forgot you can let me know?

I can look at the edit note permissions suggestion first

thanks

yvanzo: it makes sense to block the blocked notes editor from editing their notes, should they be blocked from *deleting* them too?

In theory letting them remove seems sensible, but they can give a reason so maybe they'd do something dodgy there, I dunno

Maybe it's easier to just block changes entirely while edit note privs are off?

agreed, it seems safer and easier to block that too

[17:21] <reosarevok> mayhem: is it going to be called periodic jams? If so, it has to be a periodic table but with jam jars, clearly

+++

aerozol: get on that design :DD

yvanzo: added a commit blocking that

Welcome to Mondaying

Hope last Monday was nice and relaxed without having to put up with me here!

Let's see how the pause has affected everyone

My list for today is: reosarevok, bitmap, zas, mayhem, yvanzo, monkey, lucifer, akshaaatt, atj, CatQuest, Pratha-Fish, riksucks, jasje, jivte, kellnerd

I also have another mailed review from our dear sleeping beauty, aerozol! It says:

'''

Kia ora koutou!

I’ve still been busy with other stuff, so I haven’t done anything long-term in the last couple of weeks. But there were a couple of smaller tasks that I did as they came up.

The most noticeable one was jazzing up and differentiating our various MeB forum/ticket/wiki favicons and logos (MBH-542), making them look nice - and hopefully helping me/you navigate our ridiculous amount of open browser tabs. Nobody’s complained yet so I assume that was either a success or not very noticeable (which is also a success)

MBH-542: Replace wiki favicon with updated MB logo https://tickets.metabrainz.org/browse/MBH-542

I got access to our YouTube account (thanks for the help reosarevok and mayhem!) and uploaded about a million (well, 22) walkthrough/tutorial videos. These were made during our last doc sprint a while ago, so it’s nice to finally get them up. Looking forward to posting more on there as needed and keeping a side-eye on the stats/dashboard too.

In similar ‘social channels’ news, I asked for and was given mod access from the three different people that started the various MeB related subreddits out there (that I know of), and gave them a jush.

I’m not positioning them as official MeB channels, just giving them a tidy and made them look nice. And added links between them, and to our other channels (IRC and Wiki, + Discord for the kids). I’ll keep an eye on these as well.

If you want to have a peep you can visit the loneliest subreddit in the world, https://www.reddit.com/r/MetaBrainz/, or the two that actually see some use - https://www.reddit.com/r/listenbrainz/ and https://www.reddit.com/r/MusicBrainz/

I did the usual stuff as well. If you’re wondering what ‘usual stuff’ is for me, it’s something like: moderating critiquebrainz, doing some guideline drafting, keeping an eye on a bunch of socials, answering questions on IRC, minor ticket input.

As always please do bug me if you have something you need, or are getting annoyed at me sitting on a ticket forever.

'''

Always sleeping! ;)

yvanzo: wanna start? :)

Before I fall asleep? ;)

Maybe!

During the last two weeks, I released a new version of MusicBrainz Server.

Also started preparing the MusicBrainz database schema change.

Resumed testing the search indexer’s performances w.r.t. to settings.

Plus usual PR reviews, tickets triage, and support.

Fin, go bitmap!

Or reosarevok?

hello

(or not)

bitmap is good :)

(and good to go)

the last couple weeks I was mainly continuing with schema change testing and monitoring replication logs for https://github.com/metabrainz/musicbrainz-serve...

I was testing some of the changes in that PR inside the production-cron container. a few dbmirror2 packets are missing a pending_keys file, but I figured out why, and that file isn’t required to apply the packets, so I just modified the scripts to check if it exists first and tweaked some warning messages

otherwise I did a small amount of code review

fin! go mayhem

k

People left for today are: reosarevok, zas, monkey, lucifer, akshaaatt, atj, CatQuest, Pratha-Fish, riksucks, jasje, jivte, kellnerd

last week was all about finishing the datasets page, which we did.

week before that was the same, but we didn't finish, lol.

and of course dealing with GSoC, PRs and MeB Background tasks.

speaking of GSoC: Would anyone like to write a blog post about our students? if left to me, it might not happen...

and then today I finished three troi patches for our first release of recommendations: daily jams, weekly jams and weekly new jams.

thanks monkey !

hopefully we can get those released in the next couple of weeks!

fin. monkey !

Heya !

Last couple of weeks the main attraction was finishing implementation and deploying the new ListenBrainz redesign ! The feedback has been positive so far, most people prefer the new design, so that's good !

I worked on a few other user-facing features on LB: 


A multi-search component to search for a MB recording by track/artist name OR by pasting an MBID of MB url


Tag voting in the Listening Now page — the first step of more tags visible and votable in LB

Some minimal UX changes on the Fresh Releases page

I also helped mayhem push the updated MetaBrainz datasets page past the finish line.

Reviewed PRs and guidelines and did some general admin tasks for BB + looked into some issues reported on the forums.

And a few other bits and bobs !

That's me! akshaaatt go !

Hi Everyone!

I have been at home for the past few days and spent some quality time with family :)

Nice

I helped santiagofn with some MB revamp stuff. Looking forward to continuing on that

Helped review some LB android stuff and worked on some misc things..

That’s pretty much it for now. I’ve been learning cool stuff behind the scenes. Let’s see when I get to use those skills here!

Go lucifer!

akshaaatt, thanks for rescheduling dependabot for the andriod app outside of the weekly meeting.

My pleasure :)

Or zas?

hey

People left for today are: reosarevok, lucifer, atj, CatQuest, Pratha-Fish, riksucks, jasje, jivte, kellnerd

last week, I was planning to upgrade servers, but options are limited due to lack of space in our rack, so it's time to retire kiki & herb

but for that we have to move consul to new servers

so we did some work in this field with atj (consul will be managed by ansible)

hi! (internet issues here)

I updated serviceregistrator in this regard, and did a bunch of tests

I also managed a certificate renewal issue with Gandi (all cleared now)

plus usual Picard PRs reviews, MB edits, upgrades, and user support. fin, atj?

hi

last week I started learning a bit about consul and then write an ansible role to install and configure it. I then deployed it on rex, rudi and mingus so zas could perform some tests.

*wrote

I also added the vlan interface to mingus and made a few minor fixes and improvements to the various ansible roles.

and probably some other bits I've forgotten.

lucifer?

hi all

last week i worked on finishing up the listens table migration.

i also added a cron job and related setup to regularly update similarity datasets.

debugged some misc LB issues and had a meeting with rob and SoundCloud contact about integrating it in LB

reosarevok: next?

Hi!

Last couple weeks I spent a fair amount of time helping mayhem with the datasets pages

Which luckily are out now!

Additionally, I was (still am) working on testing and improving some schema change stuff