#metabrainz

/

      • BrainzGit
        [musicbrainz-server] 14mwiencek merged pull request #2937 (03schema-change-2023-q2…mbs-12107): MBS-12107: Enable replication with dbmirror2 by default https://github.com/metabrainz/musicbrainz-serve...
      • aerozol
        mayhem: If we’re not updating reports then shall we remove this link from the menu? It makes MetaBrainz looks like it’s not being maintained if it happens to be one of the first pages you visit: https://metabrainz.org/reports/2017
      • bukwurm joined the channel
      • outsidecontext
        aerozol: that apiseeds lyrics question is odd. They say they registered an API key on apiseeds.com, but this has not been available since 2 years, the Picard plugin also got removed 2 years ago. 🤔
      • aerozol
        outsidecontext: Yeah I clicked to that after looking at the Google translate results a bit closer. Maybe someone wants to tell them they’re out of luck in French :D
      • outsidecontext
        There was happi.dev as the successor, and even that shut down earlier this year
      • aerozol
        Yeah, lyrics sites aren’t worth putting heaps of effort into supporting imo, unless they’re some ma$$ive outfit like Genius
      • outsidecontext
        aerozol: indeed. there have been several lyrics plugins come and go. everything with an open API will have a short time span :)
      • I reactivated my old reddit account and answered in English
      • aerozol
        <3
      • Pratha-Fish
        Hey reosarevok would the codebase for the bot be on MetaBrainz's GitHub profile, or my own GitHub profile? Just confirming
      • reosarevok
        Probably MeB, I can open a repo at some point
      • Then you can work on your fork and send PRs against the MeB one as needed
      • BrainzGit has quit
      • BrainzGit joined the channel
      • aerozol has quit
      • aerozol joined the channel
      • Hobbyboy|BNC joined the channel
      • pbryan8 joined the channel
      • Hobbyboy has quit
      • DjSlash has quit
      • KassOtsimine has quit
      • yvanzo has quit
      • pbryan has quit
      • riksucks has quit
      • pbryan8 is now known as pbryan
      • kgz has quit
      • KassOtsimine joined the channel
      • yvanzo joined the channel
      • Hobbyboy|BNC is now known as Hobbyboy
      • DjSlash joined the channel
      • riksucks joined the channel
      • KT03 joined the channel
      • aerozol
        reosarevok: Do we have a media at metabrainz email? Just making a generic comms/marketing form to fill out, and need a default email. I know you check the community manager email but not sure if that’s quite right
      • KT03 has quit
      • kgz joined the channel
      • antlarr has quit
      • antlarr joined the channel
      • lucifer
        mayhem: hi! I had filled the Soundcloud form to change redirect uri about 8-9 days ago but haven't received any response. should we reach out to the person we had a meet with the other day? also, can we request him to make one more application for us that we can deploy on test.lb for testing.
      • yvanzo
        About one hour of downtime is expected starting from 5pm UTC to upgrade to the MusicBrainz database to its latest schema.
      • aerozol
        mayhem: busy week last week, so put my foot on the gas today re. making noise
      • davic has quit
      • Could you case your eyes over the following docs for me, and I’ll review tomorrow, before putting it all into actions with the datasets news
      • saturday7 has quit
      • saturday7 joined the channel
      • Marketing/comms form, hopefully easy for anybody to fill out (will also do a fillable PDF version): https://docs.google.com/document/d/1Jj40bPIpy9r...
      • davic joined the channel
      • atj
        aerozol: can you put your foot on the gas and then circle back to confirm we have synergy?
      • aerozol
        mayhem: the previous two + a media contact/email list: https://docs.google.com/document/d/1ZvgcROSXTFu... (viewable by MeB emails only)
      • atj: Is synergy a joke to you???
      • atj
        i prefer to pivot and then touch base to make sure we're in lockstep
      • aerozol
        everyone: I’m putting together a list of news sites to send news to - where do you get your tech/open source/music information from, that might suit us? Especially smaller nerdy outfits. New-fangled podcasts and youtube channels, etc, qualify just fine.
      • mayhem: maybe those docs are a good start re. stuff for Rassami to look at and feed back on or add to
      • okay, bed time for me. Hope the schema change goes well all!
      • yvanzo
        Good night, same hope!
      • davic has quit
      • davic joined the channel
      • BrainzGit
        [metabrainz.org] 14mayhem opened pull request #412 (03master…remove-annual-reports-link): Remove the reports link https://github.com/metabrainz/metabrainz.org/pu...
      • mayhem
        aerozol: done ^^ (removing the reports link)
      • lucifer: go ahead and contact jordan directly, no problem.
      • aerozol: will have a look at the docs today.
      • BrainzGit
        [musicbrainz-server] 14yvanzo opened pull request #2939 (03master…mbs-13083-fix-comment): MBS-13083: Fix code comment https://github.com/metabrainz/musicbrainz-serve...
      • Maxr1998 joined the channel
      • Maxr1998_ has quit
      • bukwurm has quit
      • bitmap
        reosarevok: yvanzo: hey, I finished running upgrade.sh against a clone of the production DB (musicbrainz_schema_change_2023_q2 on aretha) last night, and didn't have any issues
      • yvanzo
        👍
      • reosarevok
        <3
      • bitmap
        also, I was checking the consistency of the first-release-date data
      • yvanzo
        I set up a mirror using Docker Compose to be able to test upgrade after main server has been upgraded in proudciton.
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #2485 (03master…LB-1274): LB-1274: Small usability improvements of the MBID mapping modal https://github.com/metabrainz/listenbrainz-serv...
      • bitmap
        release_first_release_date is identical to a query that computes it from scratch, which is good
      • yvanzo
        (very proudly)
      • bitmap
        I did notice that some first-release-date data in release_group_meta and recording_first_release_date is wrong/inconsistent, but then checked the production DB, and those problems already exist there. so it appears to be unrelated to withdrawn releases or the upgrade script
      • and I think I know why the recording ones are wrong, but it'll have to be a future schema change
      • yvanzo
        Oh, it's that bad? :/
      • bitmap
        well, I'm pretty sure we're missing a trigger for medium updates - when releases are merged using the append strategy, some medium.release columns are updated, which affects all of those mediums' recordings' dates
      • yvanzo
        I see
      • Fortunately this can be changed in production ahead of the next schema change release since it doesn't require any change on mirror side.
      • bitmap: Why is it recommended to restart Redis for the schema change (last year at least)?
      • I guess it was related to some change but couldn't find it. Not sure it is still needed this year.
      • bitmap
        I'm guessing just in case there are any code changes that affect cached entities (like changing the Moose entity models)
      • right, it may not be needed this year
      • reosarevok
        Do mirrors get the date info from us or do they calculate it with their own triggers? I forget
      • yvanzo
        Good question, not sure.
      • bitmap
        release_group_meta is replicated, but the other two materialized tables (release_first_release_date, recording_first_release_date) are not and are updated by triggers on mirrors.
      • we could rebuild recording_first_release_date as part of our upgrade steps and recommend mirrors do too. though it will lengthen upgrade process by a little bit and won't fix the underlying issue, just existing data.
      • reosarevok
        Yeah, that's what I was thinking
      • How hard is that fix?
      • (as in, is there any chance we can offer a way to fix it for schema change users if they want to fix it as part of this SC even though it was not announced, or is it hard and we should wait with it anyway?)
      • bitmap
        well, I don't think writing the trigger will be hard, but would rather wait to test it properly. we could always mention the upgrade script in future MBS/docker release notes
      • yvanzo
        I would just wait with it, we can probably come with a workaround to fix existing first release dates before the next schema change.
      • reosarevok
        I'm sure we can, it's just they'd need to run it repeatedly :)
      • But I guess there's no reason we can't say that we'll publish an updated trigger later
      • And they can install it outside the schema change themselves
      • Now properly behind my screen too
      • duncan has quit
      • CatQuest joined the channel
      • CatQuest has quit
      • CatQuest joined the channel
      • yvanzo: https://github.com/metabrainz/docker-server-con... why should JSON dumps not be updated?
      • bitmap
        they use a separate mirror DB which has to be upgraded separately
      • reosarevok
        Oh, ok
      • I forgot that part, sorry
      • bitmap
        (test.mb too, though that's a standalone DB)
      • rozlav has quit
      • rozlav joined the channel
      • rdswift has quit
      • yvanzo
        bitmap: did you stop json-dump container already?
      • bitmap
        yup, just crossed that one
      • I also started the pg_dump of musicbrainz_db on aretha just now.
      • yvanzo
        Ok
      • bitmap
      • yvanzo
        reosarevok ^
      • bitmap
        rn we're at the point where we should be merging the schema change branch into master soon
      • reosarevok
        I'd like to because I feel any issues are minor enough to be resolved later, but I'm checking one last bit yvanzo brought up
      • (the "Cancel" button also fails to submit if a required field is empty)
      • yvanzo
        reosarevok: Are you testing a fix or are you looking for a fix?
      • reosarevok
        has_field 'cancel' => ( type => 'Submit' ); is the same as in many other forms, but I guess this is the first one with an actual required field, heh
      • rdswift joined the channel
      • Looking for, but this is a very minor issue too - so I think it'd be fine to amend it on next release tbh
      • But as you two feel :)
      • bitmap
        lucifer: hi, are there any LB cron jobs using the MB database? they can be stopped whenever you're able
      • reosarevok
        I'm also ok with putting the SQL out today to prod, and the implementation later today in beta
      • Or tomorrow
      • That might even be better since I bet users will find some more small issues :)
      • yvanzo: does that sound like a good idea to you?
      • yvanzo
        reosarevok: I agree, I’ve edited the PR description to update the condition #4 and to add the condition #5.
      • reosarevok
        BTW, does monkey have to stop something for BB?
      • yvanzo
        We can even add more small patches to beta tomorrow, and have a release next week.
      • lucifer has
      • reosarevok
        Sounds good to me. bitmap?
      • monkey
        I think BB should be fine, apart from logging in
      • bitmap
        the beta release sounds like a good idea to me
      • monkey
        But I will check once you start the procedure and take it down if anything doesn't work
      • reosarevok
        Ok, let's do that then :)
      • Then we should be good to merge the schema change branch into master (since you said you cherry-picked the SQL into it)
      • bitmap
        I'll merge schema-change-2023-q2 into master then
      • yvanzo
        Thank you both
      • reosarevok
        bitmap: You cherry-picked it *after* I changed it to change_editor as you asked?
      • bitmap
        yeah, it's all good
      • reosarevok
        Ok :)
      • Yay
      • yvanzo
        double-checked
      • ChannelNick joined the channel