#metabrainz

yvanzo, bitmap: getting ready to release prod

Releasing prod

yvanzo: blog post and docker release drafted, can you review and publish them if they look ok?

[musicbrainz-server] 14reosarevok merged pull request #2974 (03master…MBS-13153): MBS-13149 / MBS-13153 / MBS-13156 / MBS-13157: More guess case changes https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #2976 (03master…MBS-13115): MBS-13115: Move annotation preview button to the left of Enter https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] 14reosarevok merged pull request #2979 (03master…MBS-13160): MBS-13160: Rename "legal name" on artist page to "performance name of" https://github.com/metabrainz/musicbrainz-serve...

outsidecontext: this doesn't seem ideal - note the time difference between second and third lines https://www.irccloud.com/pastebin/zTchO550/

Picard was completely unresponsive during that 20 seconds and no window contents were drawn. I killed the process a couple of times before starting manually with debug mode and waiting a bit longer

atj: is it reproducible? does this happen every time you start Picard?

the log does not really give information what it was picard was doing at that time. did it have files loaded?

it was reproducible until I let whatever was blocking the startup from completing, not it starts as normal

s/not/now

the exact 20 second time difference between the lines is suspicious

do you have the full log of that start?

no sorry, I accidentally closed the terminal. I see the second log message originates here: https://github.com/metabrainz/picard/blob/11051...

i'll see if i can reproduce it and if so give a full log

it could be the config file locking, yes. but that would require the config file being locked by some other process. did you have another picard running in paralell?

[musicbrainz-server] 14reosarevok opened pull request #2980 (03master…MBS-13168): MBS-13168: Add autoselect for BookBrainz series https://github.com/metabrainz/musicbrainz-serve...

it could also be something totally different, though. if the main thread is blocked because it is doing something long you won't see other log output from that thread there

'moin :D

reosarevok: Sorry for not showing up a lot in the past week lol. I was travelling a lot for some personal reasons. On the positive side tho, the network issues are finally fixed :DD

Pratha-Fish: if you're in india it's a bit late for the morning :D

param: I just spam 'moin whenever I first enter the IRC in hopes that someone in the chat has a morning going on in their timezone 🤣

lmao

param: good to see you in the IRC tho :))

Working on something interesting :eyes:

*?

hoping to finish this one

Noicee

Love the fact that you come here to do your contributions even with another full time job ❤️

best of luck!

thanks, but i assume most open source is people contributing on the side, no? :D

FWIW, Moin is a greeting which is not only used in the morning: https://en.wikipedia.org/wiki/Moin

oh wow til

lmao https://xkcd.com/2788/

param: Yes it is. And that's exactly the most wholesome part about it IMO

Noice comic tho :D

Hi param !

kellnerd: my friends from near Sylt explained that moin actually refer to an old sailor's greeting, wishing not a good day, but good wind for sailing.

Interesting, I had not heard that explanation yet.

[musicbrainz-server] 14reosarevok opened pull request #2981 (03master…MBS-13162): MBS-13162: Handle Threads links https://github.com/metabrainz/musicbrainz-serve...

^ this reminds me, aerozol, mayhem: are we going to dabble into possibly-slightly-better-twitter?

(better only inasmuch as ignoring war crimes is slightly better than promoting war crimes I guess)

erh what

hey reosarevok, would it be possible for us to discuss the updated project timeline tomorrow instead of before/after today's meeting? I've actually got an interview scheduled around the same time, so there's a chance I wouldn't be able to attend the meet. I'll definitely be present if the interview ends early tho :)

Pratha-Fish: works for me if it works for bitmap

Is anyone experiencing a crash on the LB android app?

And if not we'll find another day, don't worry about today

sounds good :)

Sentry shows a few crashes but I’ve not been able to reproduce it nor heard about it from anyone

reosarevok: while we're at it, I just wanted to ask if it's a good idea to specify a running order for python tests?

I've heard it creates dependencies and stuff - which is not a good idea

I just wanted to order tests to be able to run tests in the following order:

1. Create user

2. Create area

3. ...

4. Delete area

5. delete user

6. reset test_db

I wouldn't mind resetting the test_db after every test script either, but that's slowing the tests down significantly

Hi mayhem:

mayhem: Hi! Can I deploy a PR to LB.test or are you using it for the tags stuff?

Pratha-Fish: reosarevok: tomorrow works for me too

monkey: Thank you for your review

👍

monkey: I am trying to implement a search artist feature on my project similar to search track or MBID that already exists. Do you have any suggestions on how I should proceed. Will it be possible to make changes to it or I should start from scratch

Definitely better to try to reuse existing components

Off the top of my head, we'll need to make it possible to call another search URL, and accept different types of responses, which might not be very straightforward

Mmmmm, had a look at the component, I think you'll be better off cloning it as a starting point and replacing some of the search functionality

That's great thanks

I will make a new one and try to take inspiration from it

bitmap: thanks!

See you guys tomorrow then :)

Monkey use beta plz

reo I've also sent you a mailed in review as I might not be able to attend the meeting today

k

mayhem: I was looking into the search recording feature for playlists and saw it used an endpoint in LB and not from MB. For my project we need a similar thing but for artists.

So do we make a new endpoint or use the one in MB

I have added developer token and music user token. once the user is logged in the token is synced with the backend and the user does not need to link Apple Music account again.

riksucks: ^

lucifer: ^

Also updated PR with the same.

I thought we were supposed to revisit this week? Not so in the end?

arsh: We'll use the MB API endpoint

that. thanks monkey

reosarevok: only after some progress

Ok

monkey: Do I need to change the toggle buttons because I am facing problems with positioning them and not their working for the time being. Secondly, the magicsharebutton needs 4 props should I just leave then empty for the time being?

monkey: 👍

It's me, reosarevok

You might remember me from such meetings as last Monday's

Today we have two mailed-in reviews

which monday is it today, reosarevok?

The next one after last

Pratha-Fish says:

'''

Hi all!

Last week was mostly traveling (so sick of traveling at this point 💀), so I mostly just tweaked my tests, tried a few methods to reset my test_db for the tests, and I am currently recursing over it to make sure the tests don't take like 5 mins to complete :D

I also learned a little bit about docker on the side, and I was finally able to solve a few of my docker issues on my own! Super happy about that advancement. I hope it saves us some time in the long run :))

Lastly, as my project is running a little behind the clock, I am making a revised timeline for my project. (any advice would be welcome as I am not that good at planning things wayy in advance as things tend to go out of schedule every damn time 🗿)

'''

Pratha-Fish: always assume things will take one time and a half as long as you hope is my only advice really

reosarevok, Pratha-Fish: if you point me to the tests, i can help you speed those up.

<3

monkey is on his way to a concert, and says:

'''

Hello everynyan!

Last week I continued working on tags and tag voting in ListenBrainz, including some useful feedback from reosarevok, thanks !

oook

While testing that PR, I ran into an issue (with consul?) where the website was restarting again and again, an issue that was affecting a good number of our containers it turns out. Helped investigate and trace the cause of the issue.

Apart from that, kept an eye on the GSOC projects and reviewed PRs, some GSoC-related and some not.

That’s it for me, go someone else !