I'm not really happy about the patch, but can you check if it matches expectations regarding behavior? I added 2 test cases: one simulating the refresh (double loading), one loading new metadata with one series removed
But I still don't get why this is necessary at all. Wouldn't a refresh be expected to get the same result as a load and hence work on orig_metadata rather then metadata?
2023-08-21 23348, 2023
outsidecontext
I haven't looked into the details of refresh loading yet, but this seems suspicious. Same issue might happen with other data as well
2023-08-21 23305, 2023
zas
refresh doesn't actually reset the data, it is passed as key argument to force refreshing the json, but metadata isn't actually resetted it seems
2023-08-21 23345, 2023
zas
for most tags it isn't an issue since they are replaced, but yes, that's weird
zas: the conservative approach is of course to just make the series be reset before written as you attempted. maybe this is really the best for now. Resetting the entire object probably has some side effect we don't think about
[musicbrainz-server] 14yvanzo merged pull request #3022 (03master…rec_padding): MBS-13241 (hotfix): Add top padding to track/recording position and buttons. https://github.com/metabrainz/musicbrainz-server/…
2023-08-21 23357, 2023
Maxr1998_ has quit
2023-08-21 23304, 2023
Maxr1998 joined the channel
2023-08-21 23314, 2023
Sophist-UK has quit
2023-08-21 23300, 2023
Sophist-UK joined the channel
2023-08-21 23307, 2023
v6lur has quit
2023-08-21 23349, 2023
reosarevok
yvanzo: ApeKattQuest asked if he can go early today
2023-08-21 23359, 2023
reosarevok goes back to waiting for his plane
2023-08-21 23306, 2023
yvanzo
<BANG>
2023-08-21 23308, 2023
ApeKattQuest
ops
2023-08-21 23316, 2023
yvanzo
Hi everyone!
2023-08-21 23327, 2023
yvanzo
Happy World Senior Citizen's Day!
2023-08-21 23304, 2023
yvanzo
Welcome to this weekly MetaBrainz meeting in the middle of the summer.
2023-08-21 23314, 2023
yvanzo
received two reviews sent by email. The first one comes from aerozol:
2023-08-21 23327, 2023
yvanzo
"""
2023-08-21 23327, 2023
yvanzo
Just the usual last week.
2023-08-21 23327, 2023
yvanzo
I’ve been keeping an eye on the socials for a while now and am comfortable - it would now take a negligible amount of my time to cross-post to and keep an eye on one or many alternatives to twitter (note: *not* channels like Tik-Tok or Instagram, which do better with unique content). Something for you all to ponder, I may raise it as a future meeting topic soon.
2023-08-21 23327, 2023
yvanzo
"""
2023-08-21 23348, 2023
yvanzo
He would certainly have added “reosarevok: Would you mind to continue?” to introduce the second and last mailed-in review:
2023-08-21 23348, 2023
yvanzo
"""
2023-08-21 23348, 2023
yvanzo
Hi! I'm currently in Spain, either waiting to board or on a plane, since my brother decided to get married. Thanks yvanzo for covering for me!
2023-08-21 23348, 2023
yvanzo
Last week I worked on more URL tickets (including autoselects for our new ticketing page relationship), I had meetings with Pratha-Fish and the MBS team, and I spent a lot of time dealing with vandals and spammers.
2023-08-21 23348, 2023
yvanzo
I'll be in Spain for the whole week, although I'll still keep an eye on emails and possibly also work on code a bit. I'll also have to miss the next meeting, so I'll see you all in two weeks.
People up for reviews: ApeKattQuest, monkey, pixelpenguin, mayhem, kellnerd, bitmap, atj, Pratha-Fish, akshaaatt, ShivamAwasthi, lucifer, arsh, zas, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.
2023-08-21 23342, 2023
Pratha-Fish hops in
2023-08-21 23303, 2023
yvanzo
ApeKattQuest: It seems that you are starting with our real-time reviews ^ :)
2023-08-21 23308, 2023
ApeKattQuest
Arararara~! hi!
2023-08-21 23318, 2023
ApeKattQuest
thanks yvanzo!
2023-08-21 23320, 2023
ApeKattQuest
we did a lot of instrument images, working on updating the instruments and adding descriptions♌
2023-08-21 23330, 2023
ApeKattQuest
fin, go Pratha-Fish 🐟
2023-08-21 23334, 2023
Pratha-Fish
Hi all!
2023-08-21 23340, 2023
Pratha-Fish
Yesterday was my birthday :))
2023-08-21 23354, 2023
jasje
happy belated birthday Pratha-Fish !!
2023-08-21 23355, 2023
ApeKattQuest
🎉congrats!🎊
2023-08-21 23357, 2023
monkey
Happy birthday Pratha-Fish !
2023-08-21 23357, 2023
vscode_
Happy birthday!
2023-08-21 23309, 2023
kellnerd
Congratulations ✨
2023-08-21 23315, 2023
yvanzo
Happy birthday fish!
2023-08-21 23320, 2023
ShivamAwasthi
happy belated birthday Pratha-Fish!
2023-08-21 23335, 2023
arsh
Happy birthday 🐟
2023-08-21 23338, 2023
Pratha-Fish
Over the week, I spent some time fixing PR #4 on the musicbrainz-bot, and currently I am working on the ujpcoming PRs, as well as looking forward to wrapping up some with with the musicbraiz bot and moving ahead with the project!
2023-08-21 23339, 2023
ApeKattQuest
🐟 🎂
2023-08-21 23351, 2023
Pratha-Fish
Thankyou all for your warm wishes! ^_^ ❤️
2023-08-21 23322, 2023
Pratha-Fish
Well, that's all for me for tday!
2023-08-21 23331, 2023
Pratha-Fish
Fin 🐟
2023-08-21 23347, 2023
Pratha-Fish
ApeKattQuest: would you like to go next? :)
2023-08-21 23357, 2023
Pratha-Fish
Oh wait you've already gone havent you?
2023-08-21 23302, 2023
kellnerd
*loop detected*
2023-08-21 23305, 2023
Pratha-Fish
arsh: would you like to do the honors?
2023-08-21 23314, 2023
arsh
Sure, thanks
2023-08-21 23318, 2023
arsh
Hi everyone
2023-08-21 23343, 2023
arsh
Last week I was finally able to integrate my project in the LB codebase
2023-08-21 23322, 2023
arsh
Had to do a few changes based on the reviews but everything is working fine now
2023-08-21 23303, 2023
arsh
I am just left with the MusicBrainz integration for my project and will be finishing it up by tomorrow
2023-08-21 23318, 2023
arsh
That's all from my side
2023-08-21 23320, 2023
yvanzo
People still up for reviews: monkey, pixelpenguin, mayhem, kellnerd, bitmap, atj, akshaaatt, ShivamAwasthi, lucifer, zas, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.
2023-08-21 23327, 2023
arsh
go lucifer:
2023-08-21 23334, 2023
lucifer
hi all!
2023-08-21 23315, 2023
lucifer
last week, i mostly worked on PR reviews, GSoC discussions and testing.
2023-08-21 23322, 2023
lucifer
that's it for me. monkey next?
2023-08-21 23326, 2023
monkey
Hello
2023-08-21 23334, 2023
monkey
Last week I finally had enough of our flaky deprecated testing framework (Enzyme) and decided to take the bull by the horns and start migrating to one that actually supports React 16+ (React Testing Library).
2023-08-21 23301, 2023
monkey
It went quite well at first, installing and converting one test file went pretty smoothly. I'm looking forward to using the better testing style it provides
2023-08-21 23315, 2023
monkey
However I'm hitting some more random failures and issues with Enzyme, having had to update our test runner Jest as well. Will figure out this week how to move forward on that front, but it might just require converting some more test files now rather than in follow-up PRs.
2023-08-21 23325, 2023
monkey
Apart from that, I worked on reviewing GSoC projects, as some of them are drawing to a close.
2023-08-21 23332, 2023
monkey
I also putzed around on some small LB design tickets and as usual reviewed some PRs
2023-08-21 23342, 2023
monkey
And that's me! zas your turn
2023-08-21 23349, 2023
zas
Hey
2023-08-21 23300, 2023
yvanzo
People still up for reviews: vscode_, pixelpenguin, mayhem, kellnerd, bitmap, atj, akshaaatt, ShivamAwasthi, jasje, yvanzo. If other people want to share their own reviews, please let me know directly ASAP.
