outsidecontext: about https://tickets.metabrainz.org/browse/PICARD-745, what about implementing our own dialog and finally merge Open Files & Directories, something like https://github.com/borgbase/vorta/pull/2237 could work. It would mean we totally get rid of native dialogs, but at least we will have an unified dialog for all platforms that work for both multiple files & directories
outsidecontext[m joined the channel
outsidecontext[m
<zas[m]> "outsidecontext: about https://..." <- Would be fine for me, if we keep the option to use the native dialog. We can even make the custom dialog the default. But I personally would prefer to use the native one. Also native dialogs can offer access to system specific locations and bookmarks and stuff. So we should offer users an option to fall back to this if they have such requirements.
vorta is GPL3, though. I think that means we could take their code, but it would technically cause Picard to be distributed as GPL3. Which I think we could do because of the "or later" clause.
elomatreb[m] joined the channel
elomatreb[m]
as a user I would strongly hate a custom dialog that misses all the system integration (such as Recent files) just to save a single button in the UI
outsidecontext[m
zas: my suggestion would be to get rid of the current "allow multiple directories selection" option. We use the custom dialog for allowing to select directories and files with only a single "Add" button. We but add a new option to use native dialogs, which will then show the two buttons we already have and use native dialogs.
kellnerd[m] joined the channel
kellnerd[m]
To be honest, I don't even remember the last time I used the file dialog... I always use the file tree panel on the left or drag and drop.
kepstinbrainz joined the channel
kepstinbrainz
Note that for running in flatpak, using the system file dialogs (portal) allows you to read files from locations which aren't permitted automatically by the flatpak manifest
(saving is another issue, picard really needs static permission to write to the save directory, which users might have to add manually)
* save directory, if configured to move files, which users
* save directory, if configured to move or rename files, which users
outsidecontext[m
That's another reason to still support the native dialogs, yes
