#musicbrainz

/

      • PopperBruda joined the channel
      • Jormangeud has quit
      • Jormangeud joined the channel
      • aerozol
        oh man I used to love all the Rockbox stuff :D
      • all the firmware customs
      • Vacuity has quit
      • Vacuity joined the channel
      • ttpcodes has quit
      • ttpcodes joined the channel
      • MRiddickW has quit
      • fhe joined the channel
      • alexrelis1 joined the channel
      • alexrelis has quit
      • alexrelis1 is now known as alexrelis
      • ainola has quit
      • ainola joined the channel
      • timo joined the channel
      • kaliko0 joined the channel
      • evelyn joined the channel
      • Jormangeud^ joined the channel
      • Clint_ joined the channel
      • alexrelis has quit
      • Jormangeud has quit
      • ttree has quit
      • Goldmaster has quit
      • ssam has quit
      • Clint has quit
      • timo- has quit
      • ev has quit
      • kaliko has quit
      • derwin has quit
      • ijc has quit
      • kaliko0 is now known as kaliko
      • timo is now known as timo-
      • alexrelis joined the channel
      • ttree joined the channel
      • ijc joined the channel
      • ttree has quit
      • ainola has quit
      • otisolsen70 joined the channel
      • otisolsen70 has quit
      • otisolsen70 joined the channel
      • G0d joined the channel
      • xsteadfastx joined the channel
      • iceman1415 joined the channel
      • CatQuest reads walkman discussion with interest
      • CatQuest
        >and it's not portable
      • >>NOT Portable
      • ?????????
      • whahahaha a walkman that's not portable, lmao
      • fail
      • xsteadfastx has quit
      • ssam joined the channel
      • zer0bitz joined the channel
      • xsteadfastx joined the channel
      • loujine
        CatQuest: sorry, I saw your message last week about adding languages, didn't have time to do it yet, probably over the week-end
      • same for reosarevok 's suggestion for improve relationships cloning on a group of track, that's written but I need to test it a bit more
      • reosarevok
        <3
      • xsteadfastx has quit
      • alexrelis has quit
      • xsteadfastx joined the channel
      • zer0bitz has quit
      • zer0bitz joined the channel
      • xsteadfastx has quit
      • zer0bitz_ joined the channel
      • zer0bitz has quit
      • MRiddickW joined the channel
      • Clint_ is now known as Clint
      • CatQuest
        loujine: no worries, take all the time you need :)
      • atj
        nice updates to the cover art script ROpdebee
      • reosarevok: I recall you were talking about changing the annotation column the other day. Would that change fix the issue where when you delete an annotation it says "Add release annotation", doesn't display the previous version and says "This annotation is empty.".
      • reosarevok
        Not directly at least
      • Do you mean the edit or?
      • Annotations are always done as "add", whether you delete or edit or add, rn
      • Which is a bit weird, admittedly
      • atj
        reosarevok: well, I'm editing a releasing and deleting the entire disambiguation.
      • s/releasing/release
      • it would be nice to show the previous version of the annotation in the edit summary
      • reosarevok
        Yeah, I can see that. I don't remember why we don't do it - bitmap, do you?
      • bitmap
        I guess 'cause like you said, annotations are always "add" edits, so we don't have any display code for an "edit annotation" edit type
      • you mean the "add" display should show the previous version if one exists? that could work
      • ainola joined the channel
      • atj
        yeah that would fix the main issue.
      • bitmap
        we'd just have to keep track of which version of the annotation the user has loaded/is editing, and store that in the edit
      • reosarevok
        At least a *link* to it probably wouldn't hurt
      • atj
        I assume annotations are treated differently because they are TEXT fields (or something)?
      • bitmap
        otherwise it may differ from the version when the edit is submitted or applied
      • reosarevok
        But we could just store the whole thing
      • (the revisions are stored in history, so it should be trivial to just store the ID either way)
      • atj: I honestly dunno why this was implemented like this - I guess because it's meant to be a bit like a wiki it wasn't really thought of as a "proper field" with diffs and stuff?
      • But Wikipedia has diffs and stuff :D
      • atj
      • reosarevok
        I forgot we even had that! :D
      • atj
        yeah, I only just realised
      • reosarevok
        No clue why we're not using this on the edit display
      • atj
        never used that functionality before
      • PopperBruda has quit
      • reosarevok
        bitmap: any reason we shouldn't be using that?
      • atj
        Feels like setting an annotation to the empty string should be treated as a deletion
      • reosarevok
        As in, destructive edit? the idea is that it can be reverted by just copy-pasting from history
      • atj
        Yeah, that's what I meant
      • reosarevok
        But it's hard to do so if the history isn't even displayed, so that'd be a good start :)
      • atj
        isn't that true for all text fields in MB really?
      • :P
      • bitmap
        any reason we shouldn't be using the Annotation comparison in the edit? I don't think so
      • PopperBruda joined the channel
      • reosarevok
        atj: kinda, but for this we have a better way to just see and copy it as it was at any time in the past I guess :)
      • (we don't have, say, a "show all changes to the name and the name only" in the same way)
      • Plus the annotation is not seen as "data", but more like it's commentary
      • atj
        I suppose I'm just thinking that deleting the entire disambiguation should require a vote, whereas at the moment it doesn't
      • reosarevok
        (they're also not part of the core data dump IIRC? might be mistaken though)
      • atj
        You lose some context with edits like this: https://musicbrainz.org/edit/86733939
      • Anyway, obviously not a priority issue, the current behaviour just seems a little inconsistent, but I understand why.
      • bitmap
        reosarevok: not in the core dump, no. in the derived one
      • otisolsen70 has quit
      • reosarevok
        atj: ticket? :) at least for showing / linking / comparing the previous version
      • Second one for the distinguishing between types (add/delete/edit) if you want
      • atj
        reosarevok: sure, will do, probably won't be today though
      • reosarevok
        Sure
      • ROpdebee
        atj: <3
      • evelyn
        atj: I keep encountering a bug where it zeroes out annotations without me making any changes
      • not had it happen on an annotation where there was any content [yet]
      • reosarevok
        evelyn: I found the bug and have code to fix it :)
      • Assuming it's on releases
      • evelyn
        ooh, nice one
      • furq_ joined the channel
      • furq has quit
      • dseomn has quit
      • bitmap has quit
      • Neopolitan has quit
      • Neopolitan joined the channel
      • pbnoxious has quit
      • pbnoxious joined the channel
      • dseomn joined the channel
      • bitmap joined the channel
      • ttree joined the channel
      • MRiddickW has quit
      • otisolsen70 joined the channel
      • alexrelis joined the channel
      • Lotheric_ joined the channel
      • Lotheric has quit
      • Lotheric joined the channel
      • Lotheric_ has quit
      • Lotheric has quit
      • Lotheric joined the channel
      • furq_ is now known as furq
      • zer0bitz_ has quit
      • G0d has quit
      • otisolsen70 has quit