bookbrainz-site/master 6521d0b Seán de Búrca: Move all other preloads to middleware
2015-04-13 10316, 2015
ruaok_ joined the channel
2015-04-13 10318, 2015
Freso
Leftmost: We don't just cover books either, but written word seems broader than books anyway. (It seems to be more common to have something written not in a book than a book without anything written in or on it.)
2015-04-13 10329, 2015
Freso joined the channel
2015-04-13 10332, 2015
ruaok joined the channel
2015-04-13 10357, 2015
Leo_Verto
Leftmost, wow, that's quite the commiting spree there :P
2015-04-13 10337, 2015
kepstin-laptop joined the channel
2015-04-13 10306, 2015
zero_coder joined the channel
2015-04-13 10356, 2015
zero_coder joined the channel
2015-04-13 10359, 2015
zero_coder joined the channel
2015-04-13 10308, 2015
zero_coder joined the channel
2015-04-13 10303, 2015
zero_coder joined the channel
2015-04-13 10324, 2015
yeeeargh joined the channel
2015-04-13 10308, 2015
zero_coder joined the channel
2015-04-13 10314, 2015
bookzombie
bookbrainz-site/reactify 078f558 Ben Ockmore: Converted profile editor to use new editing flow.
2015-04-13 10352, 2015
bookzombie
bookbrainz-site/reactify 1c428d3 Ben Ockmore: Removed profile editor JS in templates - no longer needed.
2015-04-13 10339, 2015
LordSputnik joined the channel
2015-04-13 10310, 2015
ruaok joined the channel
2015-04-13 10320, 2015
LordSputnik has left the channel
2015-04-13 10356, 2015
zero_coder joined the channel
2015-04-13 10325, 2015
Leftmost
Freso, agreed, but I still think it's better to be wrong in just the one way than wrong in a bunch. :-P
2015-04-13 10346, 2015
Leftmost
Leo_Verto, I may have written some code here and there... :-P
2015-04-13 10314, 2015
Leo_Verto
I still like literature because it still covers everything we index
2015-04-13 10356, 2015
Leftmost
I don't think it actually does, as we want things that are just pictures as well, and I still strongly dislike it on the basis that its interpretation by native English speakers will suggest a much, much narrower meaning, and I'd still rather be wrong in just the one way.
2015-04-13 10318, 2015
zero_coder has left the channel
2015-04-13 10315, 2015
Freso
Leftmost: Can you show me a "book" that is _just_ pictures?
2015-04-13 10309, 2015
Leftmost
Not off-hand, but they certainly exist. Coffee table books and the like.
2015-04-13 10304, 2015
Freso
I haven't seen any.
2015-04-13 10310, 2015
Freso
They usually have a title.
2015-04-13 10319, 2015
Freso
And a note with who made the pictures.
2015-04-13 10327, 2015
Freso
Possibly edition data.
2015-04-13 10358, 2015
Leftmost
And a title and credits is sufficient for the book to fall under "the written word"?
2015-04-13 10335, 2015
Freso
Why not?
2015-04-13 10321, 2015
Leftmost
Because no one is going to call the title of a book or its photograph credits "a stellar example of the written word".
2015-04-13 10341, 2015
kepstin-laptop
sure, but nobody's going to say that about twilight either ;)
2015-04-13 10347, 2015
Leftmost
If we say we're a database of "literature" or "the written word", we're making a statement about the content of the editions or works we catalogue, not the boilerplate around them.
2015-04-13 10358, 2015
Leftmost
kepstin-laptop, I've heard people say just such things. :-P
2015-04-13 10356, 2015
Freso
If we make a statement we're a database of "books", we're making a statement about the boilerplate around what we catalogue, not the content.
2015-04-13 10301, 2015
Leftmost
Yes.
2015-04-13 10329, 2015
Freso
Which, like the reverse, is going to be false for a lot of it.
2015-04-13 10347, 2015
Leftmost
Right. I'm not arguing in any way that "book" is fully accurate. I just don't think we'll find something both concise and accurate, and since I believe that to be true, I would rather be inaccurate in an established way rather than introduce new inaccuracies.
Should I add a format field to editions? Paperback, Hardcover, Ebook?
2015-04-13 10359, 2015
Freso
Audiobook (digital/MP3, CD, tape, …)
2015-04-13 10314, 2015
Leftmost
Yeah, those were just examples.
2015-04-13 10302, 2015
Freso
I suppose a magazine article would be a work with the magazine being the edition?
2015-04-13 10331, 2015
Leftmost
Yes.
2015-04-13 10304, 2015
Freso
Are we still only at 16 accounts?
2015-04-13 10305, 2015
Leftmost
Nope, up to 17.
2015-04-13 10355, 2015
Freso
Only 6 to go then!
2015-04-13 10358, 2015
Freso
*5
2015-04-13 10338, 2015
Leftmost
Until?
2015-04-13 10347, 2015
Freso
I can register and get 23.
2015-04-13 10317, 2015
Freso
And start adding stuff.
2015-04-13 10341, 2015
Leftmost
bitmap, ping
2015-04-13 10349, 2015
bitmap
pong
2015-04-13 10321, 2015
Leftmost
Hey. I got in touch with the CA and they've given me a code for generating a new cert to cover www. I should just need to send you the new generated cert, right? Provided I use the same private key.
2015-04-13 10342, 2015
bitmap
I think so
2015-04-13 10345, 2015
Leftmost
Alright. I'll get that taken care of.
2015-04-13 10310, 2015
Leftmost
Hmm. Looks like they want a different key, but that shouldn't be a problem. I'll send it along as well.
2015-04-13 10350, 2015
LordSputnik joined the channel
2015-04-13 10306, 2015
LordSputnik
I don't think we should store audiobooks
2015-04-13 10316, 2015
LordSputnik
MusicBrainz already does that, and it's more in that domain
2015-04-13 10331, 2015
Leo_Verto
hm
2015-04-13 10349, 2015
Leo_Verto
we could use pseudo-entities though
2015-04-13 10323, 2015
Leo_Verto
because audio books tend to be related to a BB work
I think it would be ideal if we could link the MB releases to our BB works
2015-04-13 10345, 2015
Leftmost
LordSputnik, our focus wouldn't be on the audio aspect of it but the book aspect.
2015-04-13 10347, 2015
LordSputnik
But I don't think we should be adding audio releases to BB as editions
2015-04-13 10316, 2015
LordSputnik
Just like a TV dramatization of a book wouldn't fit in BB
2015-04-13 10321, 2015
Leftmost
I do. They're still books in some sense, they often have ISBNs, they can be translated, etc.
2015-04-13 10356, 2015
LordSputnik
ruaok: any thoughts on this blurry line?
2015-04-13 10300, 2015
Leo_Verto
this sounds like something we could discuss at the next MB meeting
2015-04-13 10321, 2015
Leftmost
I tend to think they should be stored both places and that different information about them can be stored.
2015-04-13 10336, 2015
Leftmost
MB stores information about the audio, we store information about the book.
2015-04-13 10337, 2015
Leo_Verto
hmm, duplicates with strong links?
2015-04-13 10334, 2015
LordSputnik
Leftmost: but we already have that information if we're storing the work
2015-04-13 10335, 2015
Leo_Verto
as much as I hate redundancy, that seems like the best solution right now
2015-04-13 10341, 2015
Leftmost
LordSputnik, we'll have the ISBN?
2015-04-13 10330, 2015
Leo_Verto
and the relationships
2015-04-13 10331, 2015
Leo_Verto
author, work, translator, etc.
2015-04-13 10331, 2015
LordSputnik
It's a tricky one
2015-04-13 10342, 2015
Leo_Verto
It is, definitel meeting material.
2015-04-13 10348, 2015
Leo_Verto
*definitely
2015-04-13 10350, 2015
LordSputnik
You're right that there's book-related information we could store in a structured way which doesn't really fit in MB
2015-04-13 10313, 2015
LordSputnik
So perhaps it makes sense to have editions for audiobooks then
2015-04-13 10352, 2015
LordSputnik
Leftmost: btw, I agree with you about socket.io, I think we can manage fine with express endpoints
2015-04-13 10342, 2015
Leo_Verto
Mhm, we don't really need bidirectional synchronous communication.
2015-04-13 10344, 2015
Leftmost
Okay. I was thinking about maybe having different auth middleware for endpoints which will be accessed primarily by ajax.
2015-04-13 10323, 2015
Leo_Verto
Maybe /ajax?
2015-04-13 10332, 2015
LordSputnik
The existing auth stuff works OK
2015-04-13 10352, 2015
LordSputnik
The session cookie is included in the JS requests
2015-04-13 10313, 2015
Leftmost
I just mean that instead of redirecting on missing auth and making the ajax code catch the redirect, we can just return 401 or something.
2015-04-13 10334, 2015
LordSputnik
Oh yeah, that's definitely an improvement
2015-04-13 10303, 2015
Leftmost
Could possibly even do that based on headers with the existing middleware.
2015-04-13 10309, 2015
Leftmost
Hmm, that might be even better. I'll look at that.
2015-04-13 10310, 2015
Leftmost
That way we could use the same middleware auth check and behave differently if for some reason the user has to fall back to traditional form submission (which I think we should do).
2015-04-13 10346, 2015
Leo_Verto
can't we implement some kind of heartbeat via ajax?
2015-04-13 10358, 2015
Leo_Verto
something like "am I still logged in?"
2015-04-13 10302, 2015
LordSputnik
Leo_Verto: I was thinking about something like that earlier today
2015-04-13 10336, 2015
LordSputnik
There are definitely ways we could manage the session better to prevent logging out in the middle of things
2015-04-13 10306, 2015
LordSputnik
For example - store the credentials in the session server-side, and automatically re-request the access token if the user is still using the site when it expires
2015-04-13 10339, 2015
LordSputnik
We could also postpone the session expiry while the user is still authenticated and making requests
2015-04-13 10347, 2015
Leo_Verto
Request sent by client or server?
2015-04-13 10355, 2015
Leo_Verto
The token one
2015-04-13 10309, 2015
LordSputnik
The site would re-request from the WS
2015-04-13 10350, 2015
Leftmost
We can improve our session management, but in the end we still want to be prepared for the eventuality that the user will not be logged in and tries to submit data.
2015-04-13 10325, 2015
Leo_Verto
Different options here include: client initates keep-alive, server initiates keep-alive or no keep-alive but client checks if still logged in
2015-04-13 10307, 2015
Leftmost
We want to be careful about how we do it, I think. We don't want to leave a session open indefinitely while the user forgets it's there.
2015-04-13 10332, 2015
Leftmost
I could easily see myself doing some editing, getting distracted, and coming back a week later and saying "Oh, edits!"
2015-04-13 10330, 2015
Leftmost
Anyhow, I'll work on improving our handling of that eventuality and see if I can't make it sparkling and shiny and wonderful.
2015-04-13 10347, 2015
LordSputnik joined the channel
2015-04-13 10312, 2015
Leftmost
LordSputnik, did you see the middleware-related work I pushed yesterday?
