hi! Do i need to close and restart the local server each time i make changes in files, using command ./develop.sh up to show these changes or is there another method. Cause it is taking too much time to close and load the server.
mshahnawaz1[m] has quit
mshahnawaz1[m] joined the channel
elkiensad[m] has quit
JuliaHusar[m] has quit
rustynova[m] has quit
elkiensad[m] joined the channel
JuliaHusar[m] joined the channel
rustynova[m] joined the channel
terinjokes has left the channel
terinjokes joined the channel
lucifer[m]
mshahnawaz1: it should automatically update.
sparksphereinspi
I've just submitted a PR titled 'Show 'No data available' message for empty feed'. When do you think it might get reviewed and merged? Let me know if there's anything I should improve.
COMPL_EXE has quit
COMPL_EXE joined the channel
mshahnawaz1[m]
Yeah! It was taking some time to update.👍
suvid[m]
lucifer: I accidentally clicked delete on the proposal
can i repost it? 😢
on the forum
mayhem please help 😢
nvm, I have reposted it as I was not finding any option to undelete it :(
Hello, I’ve just submitted a PR titled 'Show 'No data available' message for empty feed'. Whenever you get a chance, could you please take a look and let me know if there’s anything I can improve?
vardhan_ joined the channel
kto456dogkeirono has quit
mshahnawaz1[m]
sometime it reloads automatically but sometime it does not show changes (simple changes in frontend) even if i wait for like 10 minutes.
lucifer[m]
can you tell what changes did you make to which files and share docker logs?
mshahnawaz1[m]
I am making changes in listenbrainz-server\frontend\js\src\settings\layout.tsx , adding { to: "add-data/", label: "Submitting data" },
in music section.
running ./develop.sh logs gives very long list of logs.
* I am making changes in listenbrainz-server\frontend\js\src\settings\layout.tsx , adding { to: "add-data/", label: "Submitting data" },... (full message at <https://matrix.chatbrainz.org/_matrix/media/v3/...>)
zer0bitz- has quit
zer0bitz- joined the channel
mshahnawaz1[m] uploaded an image: (98KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/FCjLXTwnFUSXufVEyphKeqSq/image.png >
also when running , server these files are modifies, is this expected behaviour
terinjokes has left the channel
Guest16 joined the channel
Guest16 has quit
lucifer[m]
are you on windows?
vardhan_ has quit
mshahnawaz1[m]
Yes, using wsl with git bash
YoMo12[m] has quit
lucifer[m]
hmm i see, its likely due to that.
the line endings issue can be fixed using autocrlf settings. look that up.
and the files not showing up is also likely a wsl issue, look up that or file watchers not working on wsl somesuch.
mshahnawaz1[m]
Thanks i will look that up.
For the changes in file to be seen on server, how long does it takes usually.
suvid[m]
I would suggest you to spin up a VM real quick and try in it
* I would suggest you to spin up an Ubuntu VM real quick and try in it
