HI, I was looking into a [ticket](https://tickets.metabrainz.org/projects/LB/issues/LB-1778?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC) is there any method to retrieve the `artist_name` from `artist_mbid` for a single artist or will have to use `load_artists_from_mbids_with_redirects`
lucifer[m]
holycow23: ah, i already have a fix for it. had forgotten to open a PR, will do it today.
holycow23[m]
<lucifer[m]> "holycow23: ah, i already have..." <- Are you done with the ticket, I had already started working on it actually
mayhem: i have reviewed the changes already and it lgtm.
mayhem[m]
lucifer[m]: in reference to what was this message?
lucifer[m]
ah sorry. that was meant was m.amanullah7
s///, s/was/for/
COMPL_EXE has quit
COMPL_EXE joined the channel
holycow23[m]
monkey: Could you review [LB-1776](https://tickets.metabrainz.org/projects/LB/issues/LB-1776?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC) and [LB-1777](https://tickets.metabrainz.org/projects/LB/issues/LB-1777?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC) whenever possible
* monkey: I was working on two of the tickets related to artist-origins, could you review them whenever possible:
[LB-1776](https://tickets.metabrainz.org/projects/LB/issues/LB-1776?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC) and [LB-1777](https://tickets.metabrainz.org/projects/LB/issues/LB-1777?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC)
mamanullah7[m]
<lucifer[m]> " ah sorry. that was meant was m..." <- Thanks lucifer i'll update this website!
I think it was supposed to have some other changes as well right?
monkey[m] joined the channel
monkey[m]
I've decided to leave it for another PR as I still need to work on the fetching. So I merged this PR as a temporary fix with no loss of functionality, and will work on improving with proper event loading. I anticipate some small complications that might take me a bit of time to finish up correctly, but wanted to push this fix out.
suvid[m]
ohh I see
monkey: I didnt reply to your message asking me to review as I responded on chat here 😅
Also, I couldnt find any bug or something
is that fine right?
* monkey: Sorry, I didnt
monkey[m]
For your curiosity, it is the front-end fetching aspect which isn't exactly clear to me. Since showing the event under the thank you is done using a filtering method on already-loaded events, it's not clear how I am going to programatically trigger fetching of the missing event.
suvid[m]
monkey[m]: I think what we can do is
when we are fetching already-loaded events, we can fetch the thank you events using the id as well
monkey[m]
If you want, you can create a ticket for this missing improvement, now that I've determined it's not trivial to solve
suvid[m]
this way, we won't have to change our existing implementation
s/thank/thanked/, s/you//
* I think what we can do is
when we are fetching already-loaded events, we can fetch the thanked events using their IDs as well
monkey[m]
suvid[m]: Not clear how to do that, since we currently load by pages. Maybe some post-processing step after loading a page of events than ensures all required events are somewhere in the results. But I have to investigate how to do that properly.
suvid[m]
yes so when we load events of a page, we see all the thank you events and load the thanked events as well from their IDs
idk if its possible tho as I haven't looked at that code propoerly
s/propoerly/properly/
monkey[m]
Right, that's what I'm saying, it's not clear where loading the extra events is going to happen in the lifecylc eof the react component
suvid[m]
and this process gets repeated when we click load more events right?
as it loads events of the next page
monkey[m]: ohh ok
yea will have to figure that out
i think i'll look into it in a few days
monkey[m]
Yes, this needs to happen again if we load more events (check for thank-you events, check if original event is in cached results, if not load the event using ID)
The complicated part is combining fetching a single event by ID and fetching events by page+count.
suvid[m]
but I think you mentioned that fetching a single event by ID is trivial and you had implemented it
so ig that part is done right?
monkey[m]
The API side of it is trivial, and I have it implemented locally
Yep
suvid[m]
yea
monkey[m]
We already had method for fetching a single event by its ID, so a new API endpoint to wrap that up was easy to implement.
suvid[m]
ohh 👍️
ok so i'll look into it asap
sounds like an interesting problem
monkey[m]
and by 'fetching', I meant getting it from the database
