#listenbrainz

/

      • terinjokes joined the channel
      • holycow23[m]
        lucifer: Are you done with this [ticket](https://tickets.metabrainz.org/projects/LB/issues/LB-1778?filter=allopenissues&orderby=created+DESC%2C+priority+DESC%2C+updated+DESC), I had actually started working on it but was stuck at finding the `artist-name` from the `artist-mbid`
      • lucifer[m]
        holycow23: yeah i forgot to open a pr the other day but let me just test it quickly on test.lb and open a PR. there's two things to do here actually: group artists based on artist mbid instead of the artist name. this would sort of fix the the issue of splitting into multiple artists. however, as then the question would be which artist name to use in case of conflicts. so the right way would be to query the artist metadata cache in
      • LB for those artists.
      • there is also another issue here that distinct artists can have the same name, therefore the grouping should be done on artist mbid if available.
      • here is an example on how to query the artist metadata cache, https://github.com/metabrainz/listenbrainz-serv....
      • also ideally this stat should be generated on the spark with the final data stored in LB couchdb, to avoid making these queries everytime at runtime.
      • TheCivvie joined the channel
      • TheCivvie has quit
      • TheCivvie joined the channel
      • holycow23[m]
        <lucifer[m]> "also ideally this stat should be..." <- If you want I will look into it once the dump for Spark is done for local testing
      • <lucifer[m]> "holycow23: yeah i forgot to open..." <- Yeah that was my approach too but got stuck at fetching the `artist-name` from the `artist-mbid`.
      • fettuccinae[m] has quit
      • mshahnawaz1[m] has quit
      • vardhan joined the channel
      • shisma[m] joined the channel
      • shisma[m]
        Sometimes i would like Recommend Song A to everyone who likes Song B
      • * Sometimes i would like to Recommend Song A to everyone who likes Song B
      • Could be more abstract like recommend Artist A to everyone who likes Release group B and so on
      • monkey[m]
        That sounds pretty cool, not sure how feasible it is with our current setup, but it would be worth opening a ticket for it in Jira if you are so inclined
      • julian45[m] joined the channel
      • julian45[m]
        agreed that it sounds pretty cool - thinking about the implementation side, i think it'd be prudent to limit use of that feature at least a little bit to reduce spam/DoS risks
      • lucifer[m]
        holycow23: i've opened https://github.com/metabrainz/listenbrainz-serv... with a fix, its currently deployed on test.listenbrainz.org for testing. there is one more related change that i would like to make but haven't yet as i am not much familiar with nivo charts, so if you would like to work on that let me know.
      • lucifer[m] uploaded an image: (11KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/chatbrainz.org/UWKdaCjzWHKsyUETZtwmaVSt/image.png >
      • adding links on the x-axis ticks, . if an artist mbid is available for that artist.
      • s/.//
      • TheCivvie has quit
      • monkey[m]
        Also while in there, I think we might want to remove the artist name in the tooltips, considering it only repeats the same info that is already below. For long album titles I think it'll make a difference
      • TheCivvie joined the channel
      • zer0bitz- has quit
      • zer0bitz- joined the channel
      • vardhan has quit
      • suvid[m] has quit
      • TheCivvie has quit
      • TheCivvie joined the channel
      • TheCivvie has quit
      • TheCivvie joined the channel
      • TheCivvie has quit
      • TheCivvie joined the channel
      • rustynova[m] has quit
      • TheCivvie has quit
      • TheCivvie joined the channel
      • TheCivvie has quit