#metabrainz

/

March 20th 2025

      • BrainzGit
        [musicbrainz-server] 14mwiencek opened pull request #3500 (03production…unnecessary-genre-loading): Remove some unnecessary code from `Controller::Role::Tag` https://github.com/metabrainz/musicbrainz-serve...
      • lucifer[m]
        bitmap: i see. also, recording core completed fine for me.
      • BrainzGit
        [listenbrainz-server] 14amCap1712 opened pull request #3231 (03master…popularity): Fix popularity data generation - II https://github.com/metabrainz/listenbrainz-serv...
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | BookBrainz: #bookbrainz | Channel is logged and not empty as it is bridged to IRC; see https://musicbrainz.org/doc/ChatBrainz for details | Agenda: Reviews, defending our sites (zas)
      • lucifer[m]
        bitmap: also, i fixed the issue you were facing on macOS in the latest changes today. it happens only on macos and windows because multiprocessing using spawn there instead of fork to create new processes. but python intends to change the default for linux to spawn as well starting in 3.14. i have added point fixes but i would prefer to restructure some of sir code later to do this properly. once the initial python migration is done.
      • also, mayhem ^ all of the multiprocessing code that we have in LB or otherwise might break when we migrate to 3.14 and that part is usually not tested so we'll have to do it carefully.
      • reosarevok[m]
        Sounds like you have time in advance to schedule some test writing! 😜
      • lucifer[m]
        or fix it when it breaks in prod ;)
      • its not exactly easy to write tests for, because you have to start multiple processes in tests and then make sure they actually test what you want to test. because some issues don't show up the small test db.
      • but we can probably find a middle ground and add some tests where possible.
      • aerozol[m]
        LB team, if someone has time to look at this bug report via Mastodon: mastodon.social/@leodurruti@puntarella.party/11...
      • lucifer[m]
        aerozol: hmm i see what the issue is but it will take some time to resolve.
      • aerozol[m]
        Oh, nice. Can I help with making a ticket or anything?
      • lucifer[m]
        sure you can just make a ticket with details and assign it to me
      • reosarevok[m]
        bitmap: oh, meh, but if we use child order for `artist_release_group` then we should probably rename the `primary_type` and `secondary_types` columns? Or should we store the type ids as well? Are those used somewhere?
      • lucifer[m]
        reosarevok: do you have access to jenkins admin?
      • i think i forgot my password again
      • reosarevok[m]
        Seems so (I had no idea)
      • lucifer[m]
        alternatively if you have regular access and could fix a line in sir's test config that would work too for now.
      • reosarevok[m]
        Solved :)
      • lucifer[m]
        yup, thanks again!
      • aerozol[m]
        lucifer: done, I will let the user know: https://tickets.metabrainz.org/browse/LB-1767
      • BrainzBot
        LB-1767: Incorrect listen > stat matches
      • mayhem[m]
        <lucifer[m]> "also, mayhem ^ all of the..." <- What multiprocessing do we have besides fast_fuzzy?
      • lucifer[m]
        mbid mapper and some of the metadata caches iirc.
      • although those might be just thread pools and not process pools now that i think of it.
      • mayhem[m]
        Exactly
      • And fast_fuzzy is a dead end currently. Python is too limited to be fast enough
      • lucifer[m]
        oh :/
      • mayhem[m]
        Will likely require a drastic syntax change...
      • BrainzGit
        [listenbrainz-server] 14amCap1712 merged pull request #3231 (03master…popularity): Fix popularity data generation - II https://github.com/metabrainz/listenbrainz-serv...
      • lucifer[m]
        reosarevok: hi! can you please share the search doc with me? the link in chatlogs fails to open for me
      • nvm, found it.
      • mayhem[m]
        "Your Hetzner Cloud load_balancer "moon" in project "Default" has used more than 75% of its included traffic of 20.0 TB. "
      • That means that we're shoveling nearly .8TB/day in bandwidth. 🤯
      • lucifer[m]
        yvanzo: reosarevok i have documented the solr options at https://docs.google.com/document/d/1vQBiHdxO_qk...
      • yvanzo, bitmap, reosarevok: do you want to do another search meeting tonight or tomorrow to discuss next steps? iiuc we have achieved all of the pending things discussed last time.
      • BrainzGit
        [listenbrainz-server] release 03v-2025-03-20.0 has been published by 14github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...
      • [musicbrainz-server] 14derat opened pull request #3501 (03master…doc_link_fragment): MBS-13967: Make doc_link macro pass literal path https://github.com/metabrainz/musicbrainz-serve...
      • monkey[m]
        ansh: I went for the cheap and easy fix for the dompurify test issues, since we don't actually test the functionality: https://github.com/metabrainz/listenbrainz-serv...
      • Frontend tests passing again 🫣
      • julian45[m]
        <mayhem[m]> "That means that we're shoveling..." <- Cursed scrapers…
      • mayhem[m]
        I think the scrapers caused us to hit our limit several days earlier this month.
      • but the extra TBs? they are OMFG so expensive!!
      • (1€/TB 😆)
      • ansh[m]
        <monkey[m]> "ansh: I went for the cheap and..." <- > <@monkey:chatbrainz.org> ansh: I went for the cheap and easy fix for the dompurify test issues, since we don't actually test the functionality: https://github.com/metabrainz/listenbrainz-serv...
      • > Frontend tests passing again 🫣
      • That's great. We'll have another look at it if we want to actually use it and mock it later.
      • monkey[m]
        Yep, my thinking too. I don't expect we'll be wanting to test dompurify's functionality anytime soon...
      • mayhem[m]
        reosarevok: what are MB's ratelimits on the API now? still 1 req/s/ip? or faster now?
      • reosarevok[m]
        AFAICT, it's still the same
      • mayhem[m]
        1 req/s/ip ?
      • reosarevok[m]
        Yeah
      • mayhem[m]
        k
      • reosarevok[m]
        https://musicbrainz.org/doc/MusicBrainz_API/Rat... should still be up to date unless I forget something
      • elkiensad[m]
        I bet the scrapers are for AI and I hate them
      • mayhem[m]
        elkiensad[m]: very likely.
      • reosarevok[m]
        Very likely that they are for AI, certain that we hate them :D
      • julian45[m]
        We have exported datasets right there on the MeB site, and yet…
      • oy.
      • mayhem[m]
        yea, dumbasses.
      • is it possible to block a whole country? can we just block all of china?
      • reosarevok[m]
        The scraping IPs are coming from all sorts of countries anyway
      • bitmap[m]
        <lucifer[m]> "bitmap: also, i fixed the..." <- can confirm it works for me now. you rock! do have any links with more info about what changed in 3.13 to cause this? because it was previously working fine in 3.11/3.12. I reviewed the changelog for 3.13 but didn't see anything obvious
      • BrainzGit
        [musicbrainz-server] 14reosarevok opened pull request #3502 (03master…MBS-13768): [WIP] MBS-13768: Add MBIDs to mediums https://github.com/metabrainz/musicbrainz-serve...
      • bitmap[m]
        also, the full reindex completed without issues on hip too
      • reosarevok[m]
        bitmap: Should we start a schema change branch to point stuff to?
      • bitmap[m]
        yes, can you make one?
      • reosarevok[m]
        Sure
      • bitmap[m]
        <reosarevok[m]> "bitmap: oh, meh, but if we use..." <- we use those for filtering so you'd have to add new columns for the child_order
      • reosarevok[m]
        Oh, ok, so then the implementation needs to change anyway
      • Added https://github.com/metabrainz/musicbrainz-serve... based on master and changed the base for my open PRs then
      • bitmap[m]
        <lucifer[m]> "yvanzo, bitmap, reosarevok: do..." <- I'm available today or tomorrow too. the only thing I'm testing now is running indexing with cpu/mem limits on the sir/search containers
      • adhawkins_ is now known as adhawkins
      • adhawkins_ is now known as adhawkins
      • adhawkins_ is now known as adhawkins
      • adhawkins_ is now known as adhawkins
      • BrainzGit
        [listenbrainz-server] 14MonkeyDo merged pull request #3227 (03master…fix-volume-slider): UI Improvement: Fixed volume slider https://github.com/metabrainz/listenbrainz-serv...
      • [listenbrainz-server] 14MonkeyDo merged pull request #3226 (03master…lastfm-check-username): LB-1765 Check if user exists on last.fm while connecting last.fm username https://github.com/metabrainz/listenbrainz-serv...
      • yvanzo[m]
        Hi lucifer, bitmap, reosarevok: Tomorrow works for me.
      • lucifer[m]
        same time? 5 pm utc?
      • yvanzo[m]
        yes, any time works for me
      • that's probably not too early for bitmap
      • if we can start earlier that's good too
      • reosarevok[m]
        Earlier would be lovely if it's not too early for bitmap, to start the weekend earlier :D
      • bitmap[m]
        I should be around earlier too, I'll ping when I appear
      • lucifer[m]
        cool sounds good.
      • BrainzGit
        [sir] 14yvanzo merged pull request #143 (03master…release-doc): Document releasing a new version, step-by-step https://github.com/metabrainz/sir/pull/143
      • yvanzo[m]
        I will be available during the CET day too.
      • *daytime
      • mayhem[m]
        bitmap: reosarevok I have a question for you about the rate limit headers emitted by the MB API: https://gist.github.com/mayhem/91ef1abfb3beb66c...
      • I have script that makes 10 calls to LB API and 10 to MB.