#metabrainz

Anyway, changed from test to master which seems better

I think https://github.com/metabrainz/sir/pull/160 is fine now?

btw, the artist_release_group table was empty on test.mb, I'm building it now but you might want to test the child_order triggers again once that's done

since they weren't actually doing anything before

Oh, well good to see sort by slow worked too then :p

yvanzo: if https://github.com/metabrainz/sir/pull/160 seems fine now we can merge and then I'll rebase your PR on top and keep fixing any issues

mostly removing steps that were for the PG v16 upgrade

Thanks. I thought I got rid of most but guess not :D

looks like there was also one change to a sir trigger, search_release_packaging_update

instead of dropping/recreating all of them I can just add a command to update that one

actually it's safe to just update it in production now, so I'll do that

[sir] 14yvanzo opened pull request #161 (03master…2to3-fixes): SEARCH-594 (fixes): Various fixes to the Python 3 upgrade https://github.com/metabrainz/sir/pull/161

SEARCH-594: Port Search Index Rebuilder (SIR) to Python 3 https://tickets.metabrainz.org/browse/SEARCH-594

bitmap, lucifer, reosarevok: Sorry but that one must go first ^ :)

Thanks lucifer !

and bitmap !

[sir] 14yvanzo merged pull request #161 (03master…2to3-fixes): SEARCH-594 (fixes): Various fixes to the Python 3 upgrade https://github.com/metabrainz/sir/pull/161

SEARCH-594: Port Search Index Rebuilder (SIR) to Python 3 https://tickets.metabrainz.org/browse/SEARCH-594

pure spitballing, may be worthless for now, but: just out of curiosity, i wonder if there might be any benefit in trying `uv`; i know other projects have seen benefit in terms of substantially faster image builds when using `uv pip` vs plain `pip` for example.

the team behind it also made ruff, which is a good & performant linter that i've been happy with (and i think zas was too when he tried it in picard?)

Oh that was quick :D

Thanks yvanzo

[sir] 14yvanzo opened pull request #162 (03master…schema-30): SEARCH-740: Upgrade MB DB schema version to 30 - 2025 Q2 https://github.com/metabrainz/sir/pull/162

SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740

reosarevok: I picked up, split, documented, and completed some of your commits for this one. ^

I just saw, thanks

Checking it

But it won't work as-is unless you also add my changes adding medium gids from https://github.com/metabrainz/sir/pull/160

(well I expect it will work, just the tests won't)

reosarevok: Correct, I will move it to your PR then.

Works for me as well

you also need https://github.com/metabrainz/mbsssss/pull/69 for that

otherwise solr will error about the mediumid property

Is it what you did for test.mb.o?

reosarevok: Updated your PR. Can you please update the status of your tickets (with PR links if needed)?

Sure!

[sir] 14yvanzo closed pull request #162 (03master…schema-30): SEARCH-740: Upgrade MB DB schema version to 30 - 2025 Q2 https://github.com/metabrainz/sir/pull/162

SEARCH-740: Update mbdata / Sir to MBS schema 30 (2025 Q2) https://tickets.metabrainz.org/browse/SEARCH-740

yvanzo[m]: for test.mb, I had merged the medium gid for sir, but not the one for mbsssss (it was just using the mb-solr v4.0.0 tag as-is). so reindexing was succesful except for errors about `mediumid`

bitmap: Ok, thank you.

(that was an oversight, I had forgotten about the mbsssss PR)