#metabrainz

`git checkout -b <new branch name> master` this will create a new branch from master

then `git checkout master`, `git reset origin/master --hard`

<lucifer "then `git checkout master`, `git"> This I understand

<lucifer "`git checkout -b <new branch nam"> With this, how do I make a PR of that branch now?

Since the branch just exists that way. The commits won't be highlighted?

just push to you github fork and open a repo.

*open a PR

i didn't understand your query.

Oh! I always commit first and then push so I was confused of what to do next. As you told, I can directly push now hah!

outsidecontext: Amazing work you did all these years back!

I will now just extract the Client to the MB App and make the necessary changes. Other than this a PR to your app has also been made.

Tbh your app was straightforward as is. No boilerplate code. Everything is useful for us straightaway

outsidecontext: Should we add a callback feature to the app from Picard?

akshaaatt[m]: how exactly do you mean?

Like after the file is properly tagged there, the app displays it?

But we are doing this on the tagger already

So yeah we can do it from the app's client already

Ah, I wouldn't do such callbacks in this direction for now

<outsidecontext "lucifer, akshaaatt: btw, I'd lik"> Okay if it's just the sending part, I'll add it asap

Cool

monkey: Hi! I'm working on the pin recording popup modal for LB, could i run it by you and get your suggestions on how to improve the UI?

Sure, shoot !

(Its very similar to the new report user modal)

In my mockup I had the listenbrainz logo and the "Pin This Recording to Your Profile" heading centered at the top, what do you think?

Looks pretty good ! I would suggest a couple of changes with the wording (maybe in a PR review?), but nothing major.

Okie great. Thanks!

I think we should standardize on one look for the modals. I think this looks fine for now; perhaps you'll be interested in making a reusable modal component with the logo and and modified header

But I don't see that as a priority

Yeah, makes sense

One small thing: I think we use green buttons for this type of user actions

(for the Pin button)

outsidecontext: what does the url "http://%s:%d/openalbum?id=%s" signify?

I'll change it to green :)

Picard is listening there. So you'll need local ip of the desktop. Port usually is 8000, but is displayed in Picard window. id is a release MBID

Right!

So in the app even we'll have to add a setting where the user can add their IP and the port

Best try it on an actual Picard. If you open Picard on your desktop then try opening http://127.0.0.1:8000/openalbum?id=

With an actual MBID of course

Yes, exactly, this needs to be configurable

Understood

Coool!

You can also make a request to just / to check if Picard is listening

The answers changed a bit in Picard 2.6, though. Earlier versions always answered to all requests with the same text "Nothing to see here"

Newer return JSON results

Niceee!

ruaok: gaga seems to be overloaded

Oh oh. That doesn't seems good.