It look good to me, though I made some further edits to simplify some of the language. I don't think all of it is, but some of the sentences started getting a bit long and "impressive" in a chatGPT-style (for instance, I removed a reference to all the "incredible music" in the database, since I take pride in MB containing a lot of really shit music as well!). But with those tweaks I think it's a great improvement.
aerozol[m]
Though this para needs a quick fact check from the team, please, to make sure nothing incorrect was added: "Most of the data in our database — any factual elements describing the who, what, when and where — is published using the Creative Commons Zero 1.0 Universal license, which puts it into the worldwide public domain and allows anyone to download the data and use it however they like. Remaining data is released under the terms
aerozol[m]
of the Creative Commons Attribution-NonCommercial-ShareAlike 3.0 license, which makes it easy for everyone to access while ensuring that all our hard work doesn't become the story of yet another Gracenote."
holycow23[m]
lucifer: Hey, I was working to build a `test_get_era_activity` at `/listenbrainz_spark/stats/user/tests/test_user_stats.py` but I tried printing the messages from `messages = list(get_era_activity("all_time"))` but nothing is being printed for some reason, could you help me with the same
milkii has quit
milkii joined the channel
lucifer[m]
will take a look.
d4rkie_ has quit
d4rk-ph0enix joined the channel
DjSlash has quit
DjSlash joined the channel
ansh[m] has quit
petitminion joined the channel
reosarevok[m]
bitmap: left a question for you in MBS-14111 (not urgent)
[metabrainz.org] 14mayhem merged pull request #523 (03metabrainz-notifications…bug-fix): Fix a server error bug when all notifications are marked as important. https://github.com/metabrainz/metabrainz.org/pull…
petitminion has quit
petitminion joined the channel
reosarevok[m]
<mayhem[m]> "I would stick to the classic "..." <- aerozol: ^ can you reword it a bit? :)
d4rkie has quit
petitminion has quit
d4rkie joined the channel
lucifer[m]
holycow23: have you pushed the latest changes to the era activity PR?
suvid[m] joined the channel
suvid[m]
lucifer monkey
suvid[m]
The UI is also functional now
suvid[m]
date select is also working and listens are being successfully imported!!!
suvid[m]
i had merged the backend branch to frontend locally
suvid[m]
now pushing on github
suvid[m]
Just have to make sure the errors are shown as toast messages
suvid[m]
and display import status and previous imports as well
and suggested some changes that we have to keep it separate right ? Like wanted to ask in another pr or the one which is left for the review this one :>https://github.com/metabrainz/listenbrainz-server/pull/3316
rayyan_seliya123
And what about next how should I proceed further as queried you earlier !
mamanullah7[m] has quit
petitminion joined the channel
SigHunter has quit
SigHunter joined the channel
adhawkins joined the channel
lucifer[m]
rayyan_seliya123: the BP integration won't be merged until monkey is around. do you have any questions about it or is the PR pending review?
rayyan_seliya123
<lucifer[m]> "rayyan_seliya123: the BP..." <- Yeah no prblm about merging but wanted a review from u fir the api part and the store.py fiel I have made on that pr I am doing it properly or not and talking about further implementation wanted to ask where should I put my search bar Integration for IA metadata cache like we have to have a feature like other players like soundcloud apple or youtube like any recordings user want to
rayyan_seliya123
listen he will just search the track name or artist name or something on the official manual addition search bar and will have successfully submit the listen and can hear it am I right ?? So for this I am asking how to proceed
lucifer[m]
can you point me to what search bar you are referring to?
rayyan_seliya123
* Yeah no prblm lucifer: about merging but wanted a review from u for the api part and the store.py file I have made on that pr I am doing it properly or not and talking about further implementation wanted to ask where should I put my search bar Integration for IA metadata cache like we have to have a feature like other players like soundcloud apple or youtube like any recordings user want to listen he will just search the
rayyan_seliya123
track name or artist name or something on the official manual addition search bar and will have successfully submit the listen and can hear it am I right ?? So for this I am asking how to proceed
rayyan_seliya123
lucifer[m]: Wait
rayyan_seliya123
like i am asking where to place ia search logic in which folder like https://github.com/metabrainz/listenbrainz-server… or we have to add IA as a search source so i am confused where to put that logic
rayyan_seliya123
* lucifer: like i am asking where to place ia search logic in which folder like https://github.com/metabrainz/listenbrainz-server… and we have to add IA as a search source so nah , so i am confused where to put that logic
lucifer[m]
yes but where is the search bar in the UI that you are referring to?
rayyan_seliya123
lucifer[m]: like for other songs we are manually adding by searching thier name i was referring about that search box !
lucifer[m]
do you mean manual addition of listens?
rayyan_seliya123
lucifer[m]: Yeah it is the part of the project nah ?
lucifer[m]
that is completely different.
adhawkins has quit
rayyan_seliya123
Ooh I think I am have misunderstanding then
lucifer[m]
that searches MB for tracks and not apple music/spotify etc.
rayyan_seliya123
What's the remaining part of my project then
rayyan_seliya123
lucifer[m]: Ooh !
lucifer[m]
when you play a song using BrainzPlayer, it searches for the track in various music sources. Spotify/Apple Music/Soundcloud etc.
lucifer[m]
You need to create an Internet Archive data source for BrainzPlayer and implement searching for tracks in that.
rayyan_seliya123
lucifer[m]: That part is done like I can now play recordings which matches the data logic of ia ! But I have done it manually using submit_listens.py !!
lucifer[m]
submit_listens is only for submitting the listens to ListenBrainz. it doesn't matter how the listen is submitted, if your brainzplayer logic is correct it should work for all listens that are available in IA metadata cache.
lucifer[m]
so sounds fine to me.
lucifer[m]
in that case, you can work on the backend side of things again.
lucifer[m]
add logic for searching more tracks for the given artists/creators using IA api and add those results to process queue.
lucifer[m]
the spotify/apple music cache already do this. so take a look at it on how to implement it.
rayyan_seliya123
So talking about the frontend thing it's this much only !! What I have done so far ??
lucifer[m]
i'll check the PR but seems to me like yes
rayyan_seliya123
lucifer[m]: Sure thx !
rayyan_seliya123
lucifer[m]: Like I should focus on getting more stream_urls for the respective artist/ creators ?
lucifer[m]
yes.
lucifer[m]
you need to find more metadata items from the artist and creator of existing items.
lucifer[m]
you should use a cache/dict to not query the same artists again and again.
rayyan_seliya123
lucifer[m]: Sure and what about the limit we have set for the seeding logic should I have to increase that also ?
lucifer[m]
the spotify cache does it automatically.
rayyan_seliya123
lucifer[m]: Like the notes or other fields we have done it earlier or only focus on extraction of stream_urls ?
rayyan_seliya123
lucifer[m]: Sure will follow this approach!
lucifer[m]
no.
lucifer[m]
use the IA search API with queries filtering on creator/author field to find new metadata items. add the items ids to the processing queue. then the crawler will process them normally.
lucifer[m]
for the seeding logic, we should change it to using the collections' rss feed.
lucifer[m]
or instead of a numerical limit we can use a datetime limit (last 7 days example).
lucifer[m]
read through the spotify metadata cache code, it handles all of these thing and will probably clear things up.
rayyan_seliya123
So for these backend refactor I jave to make new pr ??
lucifer[m]
yes
adhawkins joined the channel
rayyan_seliya123 uploaded an image: (175KiB) < https://matrix.chatbrainz.org/_matrix/media/v3/download/matrix.org/UoagopWcIqxnIEdvzCMsDKPh/Screenshot%202025-08-01%20190228.png >
rayyan_seliya123
lucifer[m]: Sure will do it ! And yeah if u get some moments help me review that front-end pr too ! And asking about this page we have to add a text for internetarchive also ? like youtube has !
lucifer: Should i create new pr for fw test or continue in that only! i think except test its ready to merge! for matching of tracks was on my list now its also done and working fine!
mamanullah7[m]
one more thing db_conn parameter explicitly passed in all others services /db/.py i think i also have to pass will be used in test?
mamanullah7[m]
how to run the specific test file? ./test.sh and then filename?
petitminion has quit
revi joined the channel
petitminion joined the channel
lucifer[m]
same PR.
petitminion has quit
lucifer[m]
Yes that's the right way to run specific tests. And yes you need to pass db_conn in the same way.
mamanullah7[m]
Thanks!
kojitsu[m] joined the channel
kojitsu[m]
Hello ! I try to to create an artist using seeding. I have my URL, i use GET for artist but i receive a login page. How to manage to go thru ?
kojitsu[m]
in header, i wrote my application, the version and a mail but i'm still stuck with the login page when i send my request
texke joined the channel
lusciouslover has quit
bitmap[m]
kojitsu: you're required to login so that you can review and submit the changes
kojitsu[m]
how to do it with in my code ?
lusciouslover joined the channel
kojitsu[m]
s/with//
bitmap[m]
with seeding you're supposed to log in yourself and review each change before submission to ensure data quality
what kind of bot are you working on? i.e. what data are you planning to submit and where is it sourced from
kojitsu[m]
artists and releases from discogs that doesnt exist in musicbrainz
revi has quit
bitmap[m]
ah, those are the kinds of submissions seeding is designed for. we wouldn't allow bot submissions for those, except perhaps in very narrow circumstances where the data is pre-vetted, since a human is required to check for duplicates and ensure the data follows our guidelines
d4rkie has quit
d4rkie joined the channel
mamanullah7[m]
lucifer: we dont need `write` scope for funkwhale? `read` only we need. i'm updating scoped to `read` which includes all like `read:profile` etc! removed manual addition in the beginning i was getting some error so used specific scopes now its working!