#metabrainz

/

      • reosarevok
        Anyway. BilleeKhoj: go?
      • BilleeKhoj
        Meow! `😺`
      • gci hype!
      • I actually finished saron! 🎉
      • We asked D4RK-PH0ENiX to translate the irom message.
      • trying to figure out what to do with the rebab in-between gci tasks -
      • it's A LOT of alots easier this year as I have help from c1e0 (cleo) and mzfr[m] (Mehtab) doing stellar work on instrument tasks. In-fact they have consistently been so effective that initially I had almost no work to do 😹
      • aaah youth :wipes tear:
      • ...
      • aaand, well it's my birthday today! 🎂😸
      • :D
      • aidanlw17
        Happy birthday!!
      • Mr_Monkey
        🎉
      • Freso
        Tillykke :)
      • BilleeKhoj
        :D
      • thank you everyone
      • hmm who next 🤔
      • zas?
      • zas
        Hey
      • sbvkrishna
        :p
      • BilleeKhoj
        uh.. what?
      • zas
        Usual supervision, upgrades, mess prevention
      • jbs1 joined the channel
      • ruaok
        mess prevention.
      • that should be on your business card. :)
      • zas
        I also reviewed quite a lot Picard PRs (thanks to phw being uber active those times)
      • Freso
        Is that part of the War on Christmas?
      • BilleeKhoj
        ...
      • BilleeKhoj celebrtes jul, not christmas, but
      • zas
        apart that, trying to cope with MB edits stack...
      • fin. bitmap ?
      • bitmap
        hey
      • last week I was doing a lot of code review for GCI
      • Freso
        (Only sbvkrishna and (maybe?) iliekcomputers left on my list. Last call for others who may want to give a review!)
      • bitmap
        helping with changes to the UserCollections/react-table PR to help get it merged
      • BilleeKhoj
        Freso: and cyna?
      • bitmap
        making fixes to my MBS-7678 PR and the one for the release recording merge display issues (that one's merged now)
      • BrainzBot
        MBS-7678: Combine display of multiple relationships to the same entity https://tickets.metabrainz.org/browse/MBS-7678
      • Freso
        BilleeKhoj: Cyna went.
      • BilleeKhoj
        oh they went
      • Cyna
        Yea me here
      • bitmap
        fixing/reviewing some other misc. PRs and updating beta
      • then working on MBS-10497 (annoying cache issue) and doing more code review
      • BrainzBot
        MBS-10497: Internal server error when editing artist and credits https://tickets.metabrainz.org/browse/MBS-10497
      • bitmap
        fin! sbvkrishna go!
      • sbvkrishna
        Hey
      • My Last week was entirely filled with GCI :D
      • It's super fun guiding young students doing some great stuff !
      • Freso
        :)
      • sbvkrishna
        Planning to work on new task(s) this week
      • Fin!
      • iliekcomputers: ping?
      • Freso
        And… no sign of life from iliekcomputers.
      • So I guess they’re not around…
      • Mr_Monkey
        !m sbvkrishna
      • BrainzBot
        You're doing good work, sbvkrishna!
      • sbvkrishna
        Thanks :D
      • Freso
        So I think that’s all for reviews. If iliekcomputers pops up, they can do review in 20 seconds when I finish talking about…
      • Freso: Google Code-in
      • Just want to report that Google Code-in is off to a pretty good start. Lots of students, lots of activity, and it seems a lot of mentors are fairly busy keeping up with tasks.
      • !m GCI mentors – and students
      • BrainzBot
        You're doing good work, GCI mentors – and students!
      • Freso
        fin.
      • No iliekcomputers, so let’s call the meeting.
      • Thanks for your reviews everyone!
      • And everyone, thank you for your time!
      • </BANG>
      • ruaok
        thanks freso.
      • sbvkrishna
        Thank you!
      • yvanzo
        Thanks!
      • ruaok
        pristine__: we should talk about the testing PR a bit. Should we do it now or in a few days?
      • Mr_Monkey
        Fracias !
      • Cyna
        Thanks Freso :)
      • yvanzo
        bitmap, reosarevok: can you please check this beta pr https://github.com/metabrainz/musicbrainz-serve... ? probably nice to have for release.
      • reosarevok
        yvanzo: oh, sorry, missed that
      • bitmap
        sure
      • reosarevok
        Re: grey, we don't usually do that I think for removed/merged entities in a merge
      • bitmap
        I need to put up a fix for MBS-10511 real quick
      • BrainzBot
        MBS-10511: Regression: Modbot edit references are no longer linkified https://tickets.metabrainz.org/browse/MBS-10511
      • reosarevok
        Maybe we should, but that should be more general
      • I feel [removed media] makes it sound like something went wrong, while it just means it worked fine and is now merged
      • Honestly, we should probably just store the data with the edit so that we can display whatever was true when it got merged (greyed out)
      • But for now I just want to get it to match what we had before
      • bitmap
        the entity link should already specify it was removed right?
      • but yeah, it'd be nice if we stored it in the edit
      • rahul24 has quit
      • rahul24 joined the channel
      • reosarevok
        rahul24: left a comment, btw :)
      • bitmap: Well, it does say it, but it might be confusing if we suddenly had all the info there again
      • BilleeKhoj back to partying.
      • BilleeKhoj
        I'll make nomfood! \o/
      • reosarevok
        Enjoy!
      • BilleeKhoj
        I watched The lego movie part 2 :D it was interesting nad i liekd the message of "wne gorwing up don't forget to still keep your childish creativity and softness :)
      • yvanzo
        reosarevok: I suggested grey but actually wanted to refer to the style of medium label, see “The Man Who Sold the World” in screenshot attached to MBS-10512.
      • BrainzBot
        MBS-10512: [missing media] always shown on release merges with append strategy https://tickets.metabrainz.org/browse/MBS-10512
      • rahul24 has quit
      • yvanzo
        reosarevok: why is this row displayed then?
      • reosarevok
        The row should be there just to know what got merged away when looking at the history
      • But showing [missing media] (or even [removed media]) is misleading IMO - the first suggests there weren't ever any, the second that they got removed for some reason
      • "[media merged away]" would be clear enough, but not sure if of any use
      • yvanzo
        it would help with knowing what this row is about
      • BilleeKhoj
        +1 to changing a "merged" message if that's what happened
      • wait is that waht "mossing media" means?
      • erh missing
      • rahul24 joined the channel
      • rahul24
        reosarevok: fixed!
      • c1e0 has quit
      • reosarevok
        BilleeKhoj: no. I mean, it can be, in this specific case
      • But it was meant to indicate that the release being merged has no media
      • (so, unknown tracklist)
      • It's just after the merge completes, that's apparently true of all releases, from what the edit knows :)
      • BilleeKhoj
        ye, disambiguiating what is actually "merged" is very good
      • reosarevok
        rahul24: I didn't mean *all* of them :) Just the ones where you're already splitting it
      • Ok, I see you mostly did that
      • (just saw the line $container.find('div.voteopts').each(function () { got split, which is probably fine as-is)
      • No big deal either way