#metabrainz

/

      • github has left the channel

        • 2015-09-15 25844, 2015

      • alastairp
        Gentlecat: I think I asked about this before: https://github.com/metabrainz/listenbrainz-server… is this really the recommended way of doing templating?

        • 2015-09-15 25858, 2015

      • alastairp
        I’d really like to see templates in a separate place to code

        • 2015-09-15 25813, 2015

      • alastairp
        (but not in separate files that have to be http loaded)

        • 2015-09-15 25829, 2015

      • Gentlecat
        I think react is supposed to be the view layer

        • 2015-09-15 25820, 2015

      • Gentlecat
        they include template code in all of their examples

        • 2015-09-15 25800, 2015

      • Gentlecat
        it's also done like that in musicbrainz https://github.com/metabrainz/musicbrainz-server/…

        • 2015-09-15 25811, 2015

      • alastairp
        I just get terrible flashbacks to php

        • 2015-09-15 25809, 2015

      • Gentlecat
        the only logic there is how to render things on the screen

        • 2015-09-15 25810, 2015

      • diana_olhovik_ has quit

        • 2015-09-15 25825, 2015

      • Gentlecat
        data comes from the API

        • 2015-09-15 25822, 2015

      • github joined the channel

        • 2015-09-15 25822, 2015

      • github
        [listenbrainz-server] gentlecat pushed 1 new commit to listens: https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25822, 2015

      • github
        listenbrainz-server/listens 2aab76f Roman Tsukanov: Show incorrect value with the error message.

        • 2015-09-15 25822, 2015

      • github has left the channel

        • 2015-09-15 25830, 2015

      • github joined the channel

        • 2015-09-15 25830, 2015

      • github
        [listenbrainz-server] gentlecat pushed 1 new commit to listens: https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25830, 2015

      • github
        listenbrainz-server/listens 41bdca5 Roman Tsukanov: Swap artist<->track.

        • 2015-09-15 25830, 2015

      • github has left the channel

        • 2015-09-15 25807, 2015

      • alastairp
        \o/

        • 2015-09-15 25834, 2015

      • Gentlecat
        ruaok: is there a version of this logo without text https://github.com/metabrainz/metabrainz-logos/bl…

        • 2015-09-15 25835, 2015

      • Gentlecat
        that's a nope

        • 2015-09-15 25846, 2015

      • Gentlecat
        guess I have to cut one myself

        • 2015-09-15 25823, 2015

      • ruaok
        :(

        • 2015-09-15 25853, 2015

      • Freso
        I've cut logos myself as well... maybe someone should go and make a PR adding cut logos?

        • 2015-09-15 25816, 2015

      • Gentlecat
        maybe

        • 2015-09-15 25836, 2015

      • ruaok
        someone should also check to make sure that we're finally pedantically happy.

        • 2015-09-15 25840, 2015

      • ruaok
        then cut everything.

        • 2015-09-15 25858, 2015

      • github joined the channel

        • 2015-09-15 25858, 2015

      • github
        [listenbrainz-server] mayhem created new-schema-fixes (+1 new commit): https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25858, 2015

      • github
        listenbrainz-server/new-schema-fixes 4f3a6bc Robert Kaye: Interim commit. Will continue from home.

        • 2015-09-15 25858, 2015

      • github has left the channel

        • 2015-09-15 25823, 2015

      • ruaok has quit

        • 2015-09-15 25815, 2015

      • ruaok joined the channel

        • 2015-09-15 25835, 2015

      • madmouser1
        plugin question: if I have a new plugin stored under the user defined plugin folder ( .config/MusicBrainz/Picard/plugins/bpm/ui_options_bpm.py) how would the module import look e.g. "from picard.plugins.bpm.ui_options_bpm import Ui_BPMOptionsPage" but I know that is not the correct location ... picard.plugins.bpm

        • 2015-09-15 25800, 2015

      • github joined the channel

        • 2015-09-15 25800, 2015

      • github
        [listenbrainz-server] mayhem pushed 1 new commit to master: https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25800, 2015

      • github
        listenbrainz-server/master ae2681f Robert Kaye: Bye bye starfield. Sorry sam. Fixes LB-18

        • 2015-09-15 25800, 2015

      • github has left the channel

        • 2015-09-15 25827, 2015

      • ruaok
        Gentlecat: LB-8 is going to be fixed with your branch, right?

        • 2015-09-15 25832, 2015

      • Gentlecat
        yep

        • 2015-09-15 25859, 2015

      • Gentlecat
        can cherry-pick commits if you want to merge fix earlier

        • 2015-09-15 25805, 2015

      • ruaok
        naw.

        • 2015-09-15 25823, 2015

      • ruaok
        I'm just sifting through the bugs getting a better idea of what needs fixing.

        • 2015-09-15 25803, 2015

      • Freso
        (Btw, I'm really excited about ListenBrainz. :))

        • 2015-09-15 25818, 2015

      • ruaok
        Freso: glad to hear that. me too.

        • 2015-09-15 25830, 2015

      • ruaok
        if you have time to help out a little, we could use some help. :)

        • 2015-09-15 25800, 2015

      • Freso
        If you have anything specific (which isn't coding), let me know.

        • 2015-09-15 25855, 2015

      • Gentlecat
        cutting logos?

        • 2015-09-15 25802, 2015

      • Freso
        Heh.

        • 2015-09-15 25834, 2015

      • zas
        madmouser1: "from picard.plugins.bpm.ui_options_bpm import Ui_BPMOptionsPage" is correct, check other plugins @ https://github.com/musicbrainz/picard-plugins/tre… ie. replaygain which has an ui too

        • 2015-09-15 25857, 2015

      • alastairp
        ruaok: that js file loads the image from imgur. we should point it to static

        • 2015-09-15 25805, 2015

      • Freso
        Gentlecat: Should I do squares or with as little whitespace as possible?

        • 2015-09-15 25823, 2015

      • Gentlecat
        yeah

        • 2015-09-15 25807, 2015

      • ruaok
        alastairp: ok, will take care of it now.

        • 2015-09-15 25807, 2015

      • Gentlecat
        I think we need one with the biggest logo and a tiny for favicon (current is not square)

        • 2015-09-15 25855, 2015

      • alastairp
        (Meta|Acoustic|Book|Critique|Listen|Messy)Brainz + CoverArtArchive

        • 2015-09-15 25801, 2015

      • alastairp
        anyone see anything missing?

        • 2015-09-15 25843, 2015

      • Gentlecat
        nah

        • 2015-09-15 25848, 2015

      • ruaok
        hah. :)

        • 2015-09-15 25853, 2015

      • Gentlecat
        we nuked that project today, remember>

        • 2015-09-15 25854, 2015

      • ruaok
        that might've been intentional.

        • 2015-09-15 25855, 2015

      • Gentlecat
        ?

        • 2015-09-15 25820, 2015

      • mfmeulenbelt joined the channel

        • 2015-09-15 25814, 2015

      • ruaok
        Gentlecat: have you or are you planning to check in a whole logo as it was on the scraper?

        • 2015-09-15 25846, 2015

      • Freso
        alastairp: VideoBrainz? GameBrainz?

        • 2015-09-15 25800, 2015

      • Gentlecat
        ruaok: does it have the text?

        • 2015-09-15 25807, 2015

      • Gentlecat
        I don't remember

        • 2015-09-15 25809, 2015

      • ruaok
        yes

        • 2015-09-15 25848, 2015

      • Gentlecat
        ok, then I guess you can replace one that we already have with SVG version

        • 2015-09-15 25817, 2015

      • ruaok
        I don't see that in the img dir.

        • 2015-09-15 25819, 2015

      • Gentlecat
        so no, no plans right now

        • 2015-09-15 25841, 2015

      • Gentlecat
        oh, sorry

        • 2015-09-15 25848, 2015

      • Gentlecat
        navbar logo is different

        • 2015-09-15 25857, 2015

      • ruaok
        I'll check the full one in then

        • 2015-09-15 25813, 2015

      • Gentlecat is too tired to think

        • 2015-09-15 25832, 2015

      • ruaok
        I just got my second wind.

        • 2015-09-15 25847, 2015

      • ruaok
        loud music always helps.

        • 2015-09-15 25854, 2015

      • alastairp
        can someone make a messybrainz favico as well?

        • 2015-09-15 25800, 2015

      • ruaok
        Freso ?

        • 2015-09-15 25826, 2015

      • Gentlecat
        strange, my commits didn't show up here

        • 2015-09-15 25805, 2015

      • Freso
        I was doing some other things. Checking out logo repos now.

        • 2015-09-15 25809, 2015

      • ruaok
        Freso: thanks.

        • 2015-09-15 25813, 2015

      • Gentlecat
        bitmap: do you know if there's an easy way to modify URL parameters without reloading the page?

        • 2015-09-15 25814, 2015

      • Freso
        Slow clone is slow. :)

        • 2015-09-15 25817, 2015

      • ruaok
        I just pushed a branch too and didn't get a notification

        • 2015-09-15 25838, 2015

      • Gentlecat
        :(

        • 2015-09-15 25841, 2015

      • ruaok
        https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25846, 2015

      • bitmap
        Gentlecat: from js?

        • 2015-09-15 25850, 2015

      • Gentlecat
        yep

        • 2015-09-15 25815, 2015

      • bitmap
        you'll have to use location.hash no matter what, I think

        • 2015-09-15 25822, 2015

      • bitmap
        er, not hash

        • 2015-09-15 25809, 2015

      • bitmap
        I don't know of any API for query strings, sadly

        • 2015-09-15 25829, 2015

      • bitmap
        there's probably a bunch of things on npm for it

        • 2015-09-15 25838, 2015

      • Freso
        40%... 70 KiB/s...

        • 2015-09-15 25846, 2015

      • Gentlecat
        I see, ok

        • 2015-09-15 25824, 2015

      • alastairp
        Gentlecat: what kind of parameters? after the `?` ?

        • 2015-09-15 25813, 2015

      • Gentlecat
        I guess both /foo/<page_number> and /foo?page=<page_number> would work?

        • 2015-09-15 25837, 2015

      • Gentlecat
        sorry, I don't remember exact name of each part

        • 2015-09-15 25809, 2015

      • bitmap
        is the paging all done in js? might be easier to use location.hash in that case

        • 2015-09-15 25823, 2015

      • alastairp
        with /foo/<page number> you can use https://developer.mozilla.org/en-US/docs/Web/API/…

        • 2015-09-15 25831, 2015

      • alastairp
        no, no hash

        • 2015-09-15 25832, 2015

      • Gentlecat
        yes, it's all in react

        • 2015-09-15 25850, 2015

      • LordSputnik joined the channel

        • 2015-09-15 25803, 2015

      • Gentlecat
        I guess pushState would work

        • 2015-09-15 25820, 2015

      • alastairp
        well, this is what it’s for

        • 2015-09-15 25849, 2015

      • Freso
        Uhm. It feels kind of hackish to just crop them without using AI to do it. :/

        • 2015-09-15 25816, 2015

      • bitmap
        if you want to maintain history with pushState, I'm pretty sure you'll need a popstate handler so it knows what to do when you go back

        • 2015-09-15 25838, 2015

      • Gentlecat
        Freso: artificial intelligence? :)

        • 2015-09-15 25814, 2015

      • ruchiranga has quit

        • 2015-09-15 25830, 2015

      • Freso
        Gentlecat: Adobe Illustrator, I'm guessing.

        • 2015-09-15 25840, 2015

      • Gentlecat
        bitmap: I think it should be easy to attach a handler like that https://github.com/metabrainz/acousticbrainz-serv…, right?

        • 2015-09-15 25857, 2015

      • Freso
        All the logos seemlike they're exported from .ai equivalents.

        • 2015-09-15 25858, 2015

      • diana_olhovik_ joined the channel

        • 2015-09-15 25807, 2015

      • ruaok
        alastairp PR 13 updated.

        • 2015-09-15 25828, 2015

      • bitmap
        Gentlecat: right, or if you have jquery, $(window).on('popstate', function (event) { }) should work too

        • 2015-09-15 25839, 2015

      • Gentlecat
        perfect

        • 2015-09-15 25816, 2015

      • kahu joined the channel

        • 2015-09-15 25803, 2015

      • alastairp
        ruaok: fyi, I think you could probably use url_for, since we are going through templating

        • 2015-09-15 25825, 2015

      • ruaok
        ok, lemme do that.

        • 2015-09-15 25827, 2015

      • UmkaDK has quit

        • 2015-09-15 25814, 2015

      • alastairp
        it needs another parameter - um

        • 2015-09-15 25846, 2015

      • alastairp
        https://github.com/metabrainz/listenbrainz-server… https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25854, 2015

      • alastairp
        use static and _extenral=Ture

        • 2015-09-15 25827, 2015

      • ruaok
        for the svg?

        • 2015-09-15 25851, 2015

      • alastairp
        yes

        • 2015-09-15 25802, 2015

      • ariscop has quit

        • 2015-09-15 25830, 2015

      • Gentlecat
        where do you need _extenral? in the importer script?

        • 2015-09-15 25804, 2015

      • Gentlecat
        oh, yep

        • 2015-09-15 25848, 2015

      • Freso tries wrangling Inkscape >_<

        • 2015-09-15 25837, 2015

      • ruaok
        Freso: for a favicon, I would just open the svg in a browser

        • 2015-09-15 25843, 2015

      • ruaok
        then get a screenshot of it.

        • 2015-09-15 25847, 2015

      • ruaok
        crop, save.

        • 2015-09-15 25858, 2015

      • ruaok
        favicons can't be svg can they?

        • 2015-09-15 25809, 2015

      • Gentlecat
        there's actually a png

        • 2015-09-15 25833, 2015

      • Freso
        ruaok: For a favicon, I'd use the already available no text ListenBrainz_logo_icon.png

        • 2015-09-15 25840, 2015

      • Gentlecat
        so you can just add some pixels on the sides

        • 2015-09-15 25849, 2015

      • ruaok
        ok, you're not doing the favicons then. :)

        • 2015-09-15 25836, 2015

      • mfmeulenbelt
        Could someone explain what "orderable direction" means on pages like https://beta.musicbrainz.org/relationship/ea6f069… ?

        • 2015-09-15 25854, 2015

      • ruaok
        > @user_bp.route("/lastfmscraper/<user_id>.js")

        • 2015-09-15 25809, 2015

      • ruaok
        I guess that is why the space in username problem exists. :)

        • 2015-09-15 25821, 2015

      • mfmeulenbelt
        I personally don't care that much but I can't translate it if I don't understand it.

        • 2015-09-15 25810, 2015

      • alastairp
        ruaok: it should work - it’ll just %20 it

        • 2015-09-15 25817, 2015

      • ruaok
        mfmeulenbelt: this might be a better question for the #musicbrainz channel :)

        • 2015-09-15 25820, 2015

      • mfmeulenbelt
        ok, I'll check there then

        • 2015-09-15 25852, 2015

      • Freso
        PR #1! https://github.com/metabrainz/metabrainz-logos/pu…

        • 2015-09-15 25833, 2015

      • ruaok
        svg-logo updated

        • 2015-09-15 25837, 2015

      • github joined the channel

        • 2015-09-15 25837, 2015

      • github
        [listenbrainz-server] mayhem pushed 1 new commit to svg-logo: https://github.com/metabrainz/listenbrainz-server…

        • 2015-09-15 25837, 2015

      • github
        listenbrainz-server/svg-logo 72cf0fb Robert Kaye: Use url_for.