Not sure I like a dot in the URL of the version. I think a simple number is sufficient.
2015-09-16 25932, 2015
RJ2
a separate endpoint for submissions is fine too imo, not RESTful, but it's not quite 100% rest anyway so what's the point. /1.0/submit-listen
2015-09-16 25942, 2015
RJ2
yeah number is fine, just an example
2015-09-16 25937, 2015
ruaok
/1/listen/user/<user> ?
2015-09-16 25948, 2015
ruaok
slightly more resty?
2015-09-16 25923, 2015
RJ2
what does the url for "top artists for RJ" look like?
2015-09-16 25928, 2015
RJ2
once that exists
2015-09-16 25943, 2015
ruaok
/1/artist/$arid/listens
2015-09-16 25951, 2015
ruaok
as you suggested?
2015-09-16 25955, 2015
RJ2
not global, for my top artists
2015-09-16 25959, 2015
RJ2
as in personal charts
2015-09-16 25906, 2015
RJ2
/1/user/RJ/(listens|topartists|etc)
2015-09-16 25920, 2015
RJ2
hence why i like user before listen in the path, the listens belong to the user
2015-09-16 25923, 2015
RJ2
and also why i don't care for pure REST for most apis.. you don't post to topartists. (nor do you post the entire list of all listens every time, so it's clearly not rest anyway)
2015-09-16 25923, 2015
ruaok
ok, I grok.
2015-09-16 25903, 2015
ruaok
alastairp: /1/user/RJ/(listens|topartists|etc) ? you ok with that?
listenbrainz-server/master 5eec2c6 Robert Kaye: Merge pull request #18 from metabrainz/navbar-reorder...
2015-09-16 25917, 2015
github has left the channel
2015-09-16 25944, 2015
alastairp
ruaok: sorted?
2015-09-16 25905, 2015
ruaok
the discussion around URLs hasn't concluded.
2015-09-16 25918, 2015
ruaok
but at least I know the difference between its and it's.
2015-09-16 25940, 2015
Gentlecat
can we remove merged branches?
2015-09-16 25941, 2015
ruaok
now that I know what is up, I'll have to work hard to keep doing it wrong. even if only to keep Freso entertained.
2015-09-16 25947, 2015
Gentlecat
it's getting kind of noisy
2015-09-16 25948, 2015
ruaok
Gentlecat: sure
2015-09-16 25934, 2015
ruaok
Gentlecat: on PR 16, your comment about one part not working properly. what are you referring to? Does your PR not work correctly or the PR exists because it doesn't work correctly?
no time for that today, could have a look tomorrow.. probably doesn't need much more work
2015-09-16 25905, 2015
ruaok
alastairp: my long lunch will include Ikea. :(
2015-09-16 25918, 2015
alastairp
RJ2: we're ok for now - since it's deployed sketchyops-style
2015-09-16 25918, 2015
ruaok
how about a long lunch on monday?
2015-09-16 25926, 2015
RJ2
heh yeah
2015-09-16 25933, 2015
alastairp
so no rush to get it going for development
2015-09-16 25945, 2015
alastairp
let's take our time and then roll it out on the main server too
2015-09-16 25952, 2015
RJ2
i wanted to chef up some process supervision too
2015-09-16 25959, 2015
ruaok
daemontools?
2015-09-16 25910, 2015
ruaok
that is out poison of choice for that.
2015-09-16 25935, 2015
RJ2
yeah, although for some things where you want multiple of the same process running, like the python that writes kafka->cassandra perhaps, daemontools isn't suitable
2015-09-16 25946, 2015
RJ2
altho on single-node, 1 proc is fine
2015-09-16 25914, 2015
RJ2
i tend to use runit, and supervisord when mutliple procs are needed
Freso closed a couple of oold (5+ years) chat logger bugs... now all http://tickets.musicbrainz.org/browse/OTHER/component/10027 should actually be applicable ← Leo_Verto, LordSputnik ;)
2015-09-16 25953, 2015
RJ2
i'd say listens for get
2015-09-16 25959, 2015
RJ2
and submit should be a totally different url
2015-09-16 25913, 2015
RJ2
since it's not rest. /1/submit-listen or something
2015-09-16 25955, 2015
ruaok has no strong feelings, but knows others do
2015-09-16 25924, 2015
ruaok
but, you still need the user name in the URL, RJ.
2015-09-16 25935, 2015
ruaok
because it isn't in the payload/json
2015-09-16 25938, 2015
RJ2
username would come from the authentication
2015-09-16 25947, 2015
alastairp
ruaok: technically we dont - we can get token -> username
2015-09-16 25900, 2015
alastairp
which is pretty normal
2015-09-16 25929, 2015
ruaok
yay more code to re-write.
2015-09-16 25939, 2015
Freso
alastairp RJ2: R U (i)Nit(ee)
2015-09-16 25900, 2015
RJ2
important to get urls right early on though :)
2015-09-16 25919, 2015
ruaok nods and cries a little
2015-09-16 25953, 2015
RJ2
once the basic url schema is sorted, it should be obvious where to add new bits
2015-09-16 25940, 2015
alastairp
ruaok: I currently have no listens. Should I test and try and do an import, or believe that it'll work tomorrow and do the demo directly into my account?
