#metabrainz

stanislas: didn't have to close it, btw :)

if you force push, it will just get updated

Though, by and large, I'd recommend against force-pushing.

Leftmost: what would be the alternative ?

should be fine on feature branches if you are the only one working on it

but definitely not on master, beta, etc. unless something really bad happened

stanislas, in this case it's probably fine, but force-pushing destroys history and can cause problems for other people using the branch, so if you're on a shared repo, it should be avoided.

Leftmost, Gentlecat: Don't worry. After deleting my whole system once, i am seriously rethinking doing every command with sudo or --force :) I've made a local copy before.

there's usually a way to recover, but don't get to that point

stanislas, don't tell me you fell for "sudo rm -rf /"?

it was apt-get, and i placed * in the wrong place

Eek.

wow

Gentlecat: it closed itself

Gentlecat: because tabulations showed different on my computer and in github i had to force push about 6 times

Gentlecat: I hope it is ok now.

Gentlecat: i've seen your comments and solved new issues

zas: search is borked. I'm on it.

did the text in the wiki get smaller? stupid old age, <grumble grumble>

Back from the ACT... gotta get to work now :)

Project critiquebrainz build #140: STILL FAILING in 16 sec: http://ci.musicbrainz.org/job/critiquebrainz/140/

* stas.szczesniak: Added Cover Art Archive annotations on /artist and /release pages.

* stas.szczesniak: Added missing indents and changed "Cover arts provided by" to "Cover art

stanislas: can you mark https://codein.withgoogle.com/dashboard/task-in... as submitted?

CB: Add link to Cover Art Archive on artist and release group pages || 3 days || Code, User Interface || MetaBrainz Foundation || Currently claimed

because right now I can't approve it

GentleCat: of course

GentleCat: i just don't like situations that looks like this : 1.submit, 2.more work, 3. submit, 4. more work, 5 ...

*look

I'm not the one who designed GCI website :)

That's how a lot of code reviews look anyhow.

Gentlecat: But i should aspire to 1.submit 2.accepted :)

see Leftmost's comment

You should always aspire to that, but I've been coding since I was a wee lad and I still don't get there. :)

My tasks are pretty much that... Submit... more work. Rinse. Repeat

Gentlecat: Where ?

all over the place, really

Gentlecat: really sorry, but i have no idea what particular comment you are talking about

Gentlecat: :)

"That's how a lot of code reviews look anyhow."

got it

i thought that Leftmost left some additional comment on github or on gci page :)

which might be crucial to my task

"stanislas | GentleCat: i just don't like situations that looks like this : 1.submit, 2.more work, 3. submit, 4. more work, 5 ..." -- so wait with your first (or second, following a "more work") submission until you've got the "go ahead" in the PR.

Freso: that's actually a good idea :)

And if it looks like you're about to run out of time, we're at least 7 admins who can extend your deadline, and maybe the "mortal" mentors can too.

So just give us a heads up. (I try to keep my eye on task instances that are about to expire, but it's better to double check. :))

Freso: thanks for help

Leftmost, LordSputnik: I've done my second calibre plugin (the one about BBID search). What do you think ?

Link to my repo : https://github.com/stasszczesniak/CalibreBookBr...

I've added sync for identifiers, title, author, date published, publisher name, and languages

And I don't override the existing metadata if there is no metadata in BB too

stanislas: OK, that sounds good - is there any other metadata we can fill in?

LordSputnik: no

LordSputnik: there is, but it is not show

*shown

LordSputnik: it is in the database

only

stanislas: OK, I've just pasted a Work BBID and it finds something, but then when I apply the metadata it tells me "KeyError: u'release_data'"

I'd suggest filtering for Editions

are you sure it's release_data ?

not release_date ?

Oh yeah release_date, I mistyped

Also, if I use a BBID for an Edition, I get "Author" referenced before assignment - this is in the case where the edition has no relationships

And for the edition, https://bookbrainz.org/edition/7ec4c482-94c0-46...

LordSputnik: ok, i will try to debug it

but it work for 32f78c16-39d0-4595-afe0-974f89dd71ad

:)

stanislas: OK, got it working for hobbit as you say - it would be good if we could close the window when the data is applied

why ?

you can still change text to search and mark another book

OK, in that case, display something so thatSo that the user knows that something has happened

err, ... "so that the user knows something has happened"

At the moment, I pressed "Apply" but didn't see much going on until I looked at the book itself

I was even thinking about adding a progress bar, users like that

Perhaps a popup dialog saying "Metadata applied" would be best in this case?

This one would be easier than adding a progress bar

which one do you prefer ?

stanislas: I don't think we have enough information to do a good progress bar

Perhaps a spinner ^

I am looking in sequence for title, author, language, ... publisher (something like that)

I can change the progress bar after each of these

Ahhh OK, then yes, a progress bar would make sense for fetching data, and a dialog for applying

LordSputnik: you mean to show to user some other dialog with the changes i want to make ?

opatel99: do you know any spinner in pyQt5 ?

stanislas: actually, that's a good idea - show the current metadata vs the new metaata and get the user to confirm

I think that's doable

And should i do that in the same Dialog ?

stanislas: I may need some help. :) I could never get your first Calibre plugin to work at all, I think.

LordSputnik: I've some other idea, i can show to user his metadata and my actual metadata as i am downloading it and then make a button 'apply'

it wouldn't require a progress bar

Freso : The first one ?

Freso : how have you tried to install it?

like this : calibre -a CalibreBookBrainzPlugin_v1.0.0.zip ?

stanislas: No, via the GUI.

it can be done using GUI :) ?

Settings → Plugins → Install plugin from file

and you provided .zip ?

(Wording might be slightly different: I'm using a translation. :))

Yes.

from release or from "download zip" button on githyb

I can see it in the list as being installed.

From cloning the repository and .zip'ing it up myself. ;)

Freso: and you don't see the shortcut ?

stanislas: No. But I'm also not sure where I should be looking.

Freso: because you shouldn't

Freso: it is not possible to automatically add it

Yeah. So how do I confirm that the plugin is working?

(Same for BBID one now. :))

Freso: you should add it via preferences->toolbar

->main bar

i also use some other translation than english, so it might be slightly different

Yeah, I've been there, but I don't see anything that says anything "BookBrainz".

Or has the BB icon.

in fact, i didn't even got to this

when i try to add it using gui it says that The plugin in u'/home/stas/Pobrane/CalibreBookBrainzPlugin-master.zip' is invalid. It does not contain a top-level __init__.py file

which i am sure it does

i can ask about it on calibre dev forums tomorow

That's because you're using the GitHub download.

Which has all the files stored in a folder inside the .zip.

ah, that may be true

(So the __init__.py is at CalibreBookBrainzPlugin-master.zip/CalibreBookBrainzPlugin/__init__.py)

But as I said, I .zip'd it up myself to avoid this (it wouldn't even install using the GH d/l).

i am pretty sure what's happeniing

my old plugin doesn't work on the newest version of calibre, which i've learned today from the creator of calibre

:)

but the second should