#metabrainz

Gentlecat: Are you adding -195 and -196 as tasks?

no, I'm in the class

Alright. Want me to do it or should I leave them for you to add later? :)

do it! 🐱

Freso: and I don't know if we are going to allow to review releases

that's why it's an open question

though I think ideally you should be able to review all entities

search servers again, i'm on it

Thanks :)

Gentlecat: I agree. There I several URLs I want to write a review for! :U

*There are

Freso: I'd review "https://beta.musicbrainz.org/user/freso"

But users aren't entities yet. :/

but that's a URL, no?

moin zas, yay for the weekend being over?

:)

nothing new on this side, they still crash

last one is interesting, have a look at http://stats.musicbrainz.org/dashboard/db/searc...

check close-wait tcp conns (at the bottom)

both search servers stopped to answer at the same time @16:27 utc

Freso: i think i finally solved the issue about installing my plugin

Freso: restarting calibre (but not shutting it using ctrl-c) helps

zas: the CLOSE_WAIT... I still can't decide if that is a cause or a symptom.

it is a symptom

yeah, I think so too

search search still accepts connections while answering threads are blocked or smt

looks at established

do you have the stack trace for when things are borked?

i have one

I think we should continue on the path of creating the google doc that we started last week.

on ernie in /home/zas/

update with everything that has changed -- now we're able to really ask for help since we're not using Fred Flintstone's tools anymore.

yes

the stacktrace is much more varied this time.

last time they were all stuck in icu code, now a lot are stuck throwing an exception.

ok, the plot is thickening

a lot of threads are blocked in writing network IO.

which suggests a gateway (related) issue, not a search issue.

zas: around the time of search server crashes, have you looked at syslog on the active gateway?

so, if I read the stackdump correctly, it looks like it is dying trying to write the results to the caller.

which is nginx

zas: I think we may want to examine our nginx setup and see if we're running out of ... something.

zas: ping me when you're back please.

Mineo: I have to admit, I am stumped...

if you tell me why, maybe we can fix that :)

ELI5, what should I do? The threading seems straight forward, but the first portion of your comments was crypticto me. Should albums with MBIDs be clustered?

imho only if the option to ignore mbids is true

the automatic clustering would be most useful for files that are not associated with anything in MB yet

if there are already MBIDs in the files, the MBIDs are much better information than can be provided by the clustering

Ok... what if there is a combination?

of options?

of files with MBID and no MBID. Should I cluster the ones with no MBID and leave the MBIDs alone?

ah, I had not actually thought of that yet

:o

in that case, I think it would make sense to have an additional method on the tagger object like 'cluster_non_mbid_files' or something that goes through all unmatched files and collects the ones without MBIDs and clusters those

tl;dr: yes

Okay. Now what about that in combination with ignore MBIDs? If that option is selected, do everything?

yes, just cluster all files in that case

Cool. Giving it a shot.

Got any more Picard tasks up your sleeve btw? I am kinda useless here without Picard...

Hello again, when trying to import dumps for the first time with the command "./admin/InitDb.pl -- --createdb --import /tmp/dumps/mbdump*.tar.bz2 --echo", I get an error "psql: FATAL: role "musicbrainz" does not exist"

ruaok: i checked the nginx conf with bitmap, and we saw nothing wrong with it (that doesnt mean nothing is wrong)

Should I create a role or create a clean db (--createdb --clean) before?

understood.

there is an admin interface that we can get current stats from, yes?

opatel99: I was thinking of making a task to improve/rewrite https://picard.musicbrainz.org/docs/scripting/ because a lot of people struggle with scripting, but I'm not yet sure what exactly needs to be improved

I wonder if we should graph the number of buffers, number of connections, anything for the search* configurations.

this latest stacktrace really suggests that this is an internal configuration issue and not a lucene/java issue.

we can add whatever we can get numbers for

is the stacktrace available somewhere?

Mineo: hang on

Mineo: https://www.dropbox.com/s/gqqd0g13terr1fm/stack...

I'd love to get your read on the current state of things.

LordSputnik, Leftmost: I've done my second plugin. I would be grateful if you review my work. I've not submitted it on gci yet, I just want to know your opinion at this stage. Link to my repo : https://github.com/stasszczesniak/CalibreBookBr...

zas: this doesn't seem detailed enough for my desires, but let's start graphing:

Mineo: Where do I get 900 files from? :P

opatel99: You could expand your horizons! I'm about to add two more CB tasks, and there's a bunch of unclaimed beets tasks too, as I mentioned previously.

opatel99: https://archive.org/details/Best_of_8_Bit_Colle... should contain more than that

stanislas: I won't be able to try it out until tomorrow, but one thing you could do to improve would be to split out the bits of code that initialize the UI into separate functions, so the large methods you have at the moment become smaller and easier to maintain

^ +1 (even if I haven't actually looked at the code :))

ruaok: this is collected since some time already, if possible (=module enabled)

regarding the stackdump: I wonder why a lot of threads are in some EOFException, all coming from eclipse-persistence's JSONWriterRecord

LordSputnik. Ok, i will try to clean my code. Thanks. Maybe Leftmost is willing to review it today.

stanislas: hopefully! I'm willing, but universitry deadlines mean that I've not got the time this evening :(

I have exams this entire week... Gonna be so behind once I am done..

LordSputnik: Oh i understand, i have geometry exam tomorrow :)

stanislas: less coding, more studying! ;)

stanislas: I could add a day onto the task if you like, just in case we don't have it wrapped up by tomorrow evening?

regarding the bb plugin for calibre: you're aware that you're working around Qts event model by using urllib, right?

Mineo: yes, exactly that.

LordSputnik: seems like a good idea

Mineo: What do you mean ?

stanislas: I'll give it a whirl. :)

JSONWriterRecord sounds like the bog standard send the response to the caller and it gets stuck somehow.

and that somehow would be caused by nginx, since that is what is on the other end.

thus leading me to think we need to examine our nginx config.

Mineo: No, I don't.

Mineo: does that line of thinking make sense to you?

Mineo: I don't even understand what do you mean by "working areound Qts event model by using urllib"

ruaok: what's surprising to me is that none of the EOFExceptions are related to xml responses getting written, although I suspect the number of those to be way higher than the json ones

Mineo: Are you talking about my plugin ?

oh, wait, the website uses json as well, right?

yes.

IIRC

still, that is an interesting observations.

-s

stanislas: sorry, I didn't want to try having two conversations at once :-)

Mineo; ok

stanislas: calibre seems to be built on Qt which models everything i/o-related (reading files, sending data over the network etc.) as events with callbacks attached to them

this allows it to do other things while i/o is happening in the background without having to spawn a new thread for every action

by using urllib to request data from bookbrainz, everything else is blocked while the http request is in progress

this works if bookbrainz is responding fast, but doesn't work quite so well if the bookbrainz servers take a long time to respond or are completely offline

Mineo: Would doing all https requests in some other thread solve the problem ?

yes and no :P I would expect there to be some helper methods for plugins in calibre

Mineo: Can you explain why the upload for many files fails with auto cluster, but not without?

ruaok: we've been getting ISEs for cut-off JSON response from the search server since at least 2013, probably longer

opatel99: no, I don't really know why that happens, but I think the clustering engine is not meant to be called from multiple threads

bitmap: that is interesting.

So QSemaphore reserves threads?

how frequent are those?

I wonder if they happen due to index rotation or if they happen when the servers choke

can we graph the occurance of those, bitmap, zas?

we usually get a couple/few a day I think

opatel99: no, it allows you to count the number of active threads (which you can't just do by incrementing a normal variable in multiple threads)

they include the JSON and show where it gets cut off (then mbserver fails to parse it, hence the ISE)

ok, a few a day really seems to be related to the index rotation.

not too much we can do about that with the current setup

Mineo: Would http://doc.qt.io/qt-4.8/qwaitcondition.html not work?

I did not explore every possible option - if you think it works, give it a try :)

typhoe: what version of node.js do you have? I don't think Map() was added officially until 4.0

LordSputnik: the website says Map() needs a polyfill, not just the code transform http://babeljs.io/docs/learn-es2015/#map-set-we...

I think I'll just replace that with a plain object