reosarevok: I have a question about the task "CB: Add a note that will warn users that drafts are not private"; The related ticket has a link to a merged PR (6 days ago) .. I was wondering if that meant that the problem was fixed. Sorry about the long message
2015-12-21 35526, 2015
reosarevok
Gentlecat ^
2015-12-21 35545, 2015
Gentlecat
yes, that was fixed
2015-12-21 35549, 2015
reosarevok
But it might be - we have a couple cases of those, I think I hid them all from GCI but one might have remained behind
MB: Add username to verification mails [MBS-6407] || 3 days || Code || MetaBrainz Foundation
2015-12-21 35532, 2015
gcilou
Yes, I'm still looking
2015-12-21 35548, 2015
gcilou
reosarevok: That task looks interesting. I've looked at musicbrainz-server/root/account but I couldn't seem to find the page for the verification email. Would this be given if I claimed the task?
2015-12-21 35534, 2015
reosarevok
We can find it together, heh
2015-12-21 35545, 2015
reosarevok
I don't remember where it is, honestly, but I can give you the email text to git grep
2015-12-21 35556, 2015
reosarevok
That should find it
2015-12-21 35513, 2015
gcilou
OK, I'll claim it then. lol. git grep searches for files or something?
2015-12-21 35548, 2015
reosarevok
git grep searches for something inside the files in the repository
2015-12-21 35500, 2015
reosarevok
In this case... *looks for verification mail*
2015-12-21 35523, 2015
reosarevok
"This is a verification email for your MusicBrainz account"
2015-12-21 35533, 2015
gcilou
Right, so 'grep' is the git command ?
2015-12-21 35552, 2015
gcilou_ joined the channel
2015-12-21 35508, 2015
gcilou_
urg sorry, chrome just crashed
2015-12-21 35525, 2015
gcilou_
Sorry, I claimed the wrong task and then abandoned it
2015-12-21 35554, 2015
gcilou has quit
2015-12-21 35517, 2015
reosarevok
Yeah, just git grep "something"
2015-12-21 35538, 2015
gcilou_
Ok, how do I abandon a CB ticket?
2015-12-21 35527, 2015
chirlu`
Click “Assign”, then choose “Unassigned” as the assignee.
Leftmost, LordSputnik: When I change a gender using PUT, the gender in the database doesn't appear. None is in instance_of_creator.master_revision.entity_data.gender. Should I create some 'gender' object first ?
2015-12-21 35530, 2015
reosarevok
No :)
2015-12-21 35545, 2015
reosarevok
Although there's a chance you'll need to modify this too
2015-12-21 35549, 2015
reosarevok
This is a test file
2015-12-21 35511, 2015
reosarevok
Yeah, you'll need to change this too I think :)
2015-12-21 35529, 2015
gcilou_
Oh ok..that's what grep found..I'll try something else then
2015-12-21 35534, 2015
reosarevok
Basically anything in the /t directory is a test (I think)
Freso: I do have presentations. Mail me to remind me to make them public.
2015-12-21 35518, 2015
dpmittal has quit
2015-12-21 35512, 2015
gcilou_
reosarevok: I'm assuming that I have to add a line for username in the last link you gave, then add another based on the previous in the one I found..Is this correct?
2015-12-21 35553, 2015
dpmittal joined the channel
2015-12-21 35507, 2015
gcilou_
"usernm => $user_id " ; then " my $userid = $opts{usernm};" ?
2015-12-21 35531, 2015
reosarevok
I think you want $editor->name
2015-12-21 35523, 2015
reosarevok
(also feel free to write "username" in full, it makes things more clear when checking the code in the future)
2015-12-21 35550, 2015
gcilou_
for the second statement? Ok
2015-12-21 35529, 2015
reosarevok
Mind, I am not very familiar with this code and I'm a mentor there mostly because I entered the original feature request
2015-12-21 35553, 2015
reosarevok
So we'll want bitmap to take a look at this when he's around and make sure we're not doing stuff very wrongly :p
2015-12-21 35556, 2015
spideyonthego joined the channel
2015-12-21 35505, 2015
gcilou_
Alright
2015-12-21 35530, 2015
spideyonthego
Is there anyone here right now who has installed CB with vagrant?
2015-12-21 35553, 2015
Gentlecat
I tried to do that again yesterday and it worked fine
2015-12-21 35520, 2015
Gentlecat
stanislas might've done that before as well
2015-12-21 35544, 2015
Gentlecat
still same issues with downloading packages?
2015-12-21 35546, 2015
stanislas
spideyonthego: I did, thaks Gentlecat.
2015-12-21 35504, 2015
gcilou_
reosarevok: I see lower in the code that this statement is used " my $user_name = $opts{user}->name;" Is this the statement I should use too>
2015-12-21 35510, 2015
spideyonthego
Gentlecat: Yup.
2015-12-21 35522, 2015
spideyonthego
Gentlecat: This is all I do. I start the VM using vagrant up (after which a lot of files are downloaded). Then I use Putty to actually open the VM. And then when I try running run.py, it shows the errors.
2015-12-21 35533, 2015
stanislas
spideyonthego: Can you gist your error.
2015-12-21 35554, 2015
spideyonthego
stanislas: It's just that the werkzeug module couldn't be found.
2015-12-21 35503, 2015
reosarevok
gcilou_: Oh, that does seem like something similar to what you want. See also send_editor_report later
2015-12-21 35503, 2015
stanislas
Aaah.
2015-12-21 35513, 2015
spideyonthego
So, I installed everything from the requirements text using pip
2015-12-21 35522, 2015
spideyonthego
But still it doesn't work.
2015-12-21 35530, 2015
stanislas
spideyonthego: I've done the same, and it worked
2015-12-21 35550, 2015
stanislas
spideyonthego: pip install Werkzeug
2015-12-21 35526, 2015
spideyonthego
stanislas: But that's not the only one right? There are many more modules left.
So opatel99, this is the section in email.pm that i'm changing " my $ip = $opts{ip}; my $body = <<EOS; This is a verification email for your MusicBrainz account. Please click on the link below to verify your email address:" and here are my changes so far " my $ip = $opts{ip}; my $userid = $opts{user}->name; my $body = <<EOS; Hello [$userid], This is a verification email for your MusicBrainz account. Please cl
