#metabrainz

Discourse, probably.

AFAICT, it requires a JSON endpoint on MB and doing some configuration on the plugin.

chirlu`: Possibly, but the plugin's docs doesn't mention anything about it. :/

Freso: you have to derive a new class from the plugin, with custom authentication code

ok, what we should do is break this into separate actionable tickets.

then we can find the people who can handle those.

LordSputnik: Where do you see that?

Anyway, let's talk about this post-meeting?

ruaok, final topic?

ok, I just wanted to call more attention to chirlu`s work on the solr stuff.

he setup his sandbox (chirlu.mbsandbox.org) to use the new SOLR stuff.

I would urge everyone who cares about search to go take a look at it.

and report bugs to the newly created SOLR jira project.

(That's http://chirlu.mbsandbox.org for the lazy URL clickers out there.)

I'm going to be pushing hard to get these open bugs addressed and us migrating to the new infrastructure ASAp.

I spent too much time fixing search servers and so has zas. it is really hurting our site performance overall.

so, jump in now and report bugs.

^ +100

I know that people will still think it was too soon, but that is life. we need to move onward.

whoa, that's weird, adding more search terms gives fewer results rather than more

Re: too soon, that will depend on how well the web service search works.

that fixes the main complaint my casual user friend had :)

so, act now, speak up soon. then forever hold yer pickle.

fin.

Mm. Pickles.

THank you all!

</BANG>

thank you freso!

LordSputnik: From my reading of https://github.com/discourse/discourse-oauth2-b..., it sounds like one simply needs to walk into Mo^W^W^Wadd the relevant configuration entries.

Freso: There are two ways of doing things - without a JSON endpoint on MB, we'd need to do https://meta.discourse.org/t/login-to-discourse... which is what would require all the Ruby. If we can add a JSON endpoint to MB for authenticated users, then we can use the ready-made basic OAuth2 plugin (which is the easier option, IMO)

Ah, right.

Okay. :)

Then we agree. 🙌

(I would love to do a custom MusicBrainz OAuth2 provider module which we could also contribute upstream to Discourse, but I also agree the 2nd option is likely easier.)

Hm. Maybe we could lure some volunteer at Discourse to do the former option?

Not sure whether they'd see the value in that

opatel99: How's your Ruby? XD

(Poor opatel99 :p)

chirlu`: where can I find the patch you used to get solr to work with your sandbox yesterday?

Thanks!

sampsyo: PR fixed, changelog updated too

LordSputnik: https://github.com/mindvalley/omniauth-mindvall... is a customised Ruby plugin. Doesn't seem terribly daunting.

Freso: thanks for volunteering ;)

(it does look reasonably understandable though, yes)

Freso: do you know any Ruby?

LordSputnik: Nope. :p

Well, me neither, but it looks daunting enough :P

Also, even that plugin requires us to modify the MB OAuth code

How so?

Since it's assuming that "extra data" is provided

(data["first_name"] and data["email"] are coming from the OAuth access token response)

it wouldn't be hard to write a plugin that does an extra api call call to mbs to get that info, tho.

i think

weeksio_, Do you have a minute? I fixed the code and it compiles but I'm not sure how you deployed it to the server.

So, /ws/2 searches are also supported on my sandbox as of now. Please test.

CJ_: sure

one sec

Freso: it also requires us to be able to get the ID for an editor given their username, which I don't think it possible at the moment?

(at least not with the XML API)

CJ_: the solrwriter-0.0.1-SNAPSHOT-jar-with-dependencies.jar should be in the target folder.

weeksio_, Does that need to be copied somewhere? Are you able to connect to the server?

Freso: I've been working on bookbrainz-ws tests mostly. I am finishing all these testing tasks right now, adding some new features.

no can't connect until I'm back home

gcilou: you don't need `elif`, just `if`

it needs to be copied to....

OK

stanislas: The reviews are supposed to be for the meeting which ended 25 minutes ago. :)

also `spotify_mappings = mbspotify.mappings(entity_id)`

Freso: I didn't know that, I've assumed that it is still going on right now :)

CJ_: copy it to mbsssss/lib

LordSputnik: Have you seen my latest commit ?

Gentlecat, also, for the server to work, do I need to follow all of this? https://critiquebrainz.readthedocs.org/contrib/...

weeksio_, How do I restart the server?

gcilou: no, this is for manual installation

didn't you have it working yesterday? running `python run.py`?

in vagrant

CJ_: service solr restart

OK. Im still not sure that it is working correctly. yes, python run.py works but it tells me nothing

weeksio_, Trying now.

gcilou: what do you mean tells you nothing? it's not supposed to, apart from log output

if you can open local server from your browser, it's working

weeksio_, Odd. Both con and docs have values.

NM. Apparently it is only an occasional NPE.

weeksio_, For some reason there is not always a ResultContext.

CJ_: I really don't know much about what's happening in this code

I am not positive what this method is trying to achieve so I am not sure of the best resolution.

But the short term fix would be to check if con is null and then skip the rest of the code.

Mineo ^ ?

It looks like nothing would happen if there are no docs, so that should be a safe solution.

Gentlecat, Ok. Is the profiler supposed to say 'inactive'?

weeksio_, Without thoroughly digging through the entire infrastructure that is the best solution I have for you currently.

sounds good to me

LordSputnik: I forgot to add test_publication.py :) Sorry if you started the tests already.

Also, logging should be configured and used. printStackTrace should never be used.

weeksio_, I will take a look at this more tomorrow and see what I can come up with.

great....thanks again

No problem. :)

gcilou: you mean in the debug panel on the page?

Yes

yeah, you shouldn't need it

OK. So if when i press 'browse reviews', 'no reviews found' comes up, I'm assuming that that means im doing something wrong right?

why would it be wrong?

you modified review editor, so that's what you need to check

Freso: sorry I missed ^. Ruby was the first web framework I learned and I believe I have enough knowledge of it to get by. I am pretty confident i could definitely do some work if you need me to. Of course, that is dependent on the level of the assignment. I'd like to give it a shot at least

make sure that spotify player shows up on these pages

Right but I can't enter the review editor when there aren't any reviews, can I?

Or what am I missing?

*Discourse plugin

If you think it sounds doable/reasonable, let me know.

"editor" is creator as well

you can write a review and edit it

Do I need to sign in to do that?

stanislas: will take a look now

LordSputnik: test_publication is not commited

I've messed up with git recently

stanislas: your master branch on the repo looks OK to me, should be possible to just add the missing file

Can I make a separate commit and not reset the last two ?

I've found reseting the merge not very easy.

gcilou: yes

LordSputnik: It is easy, but after that I've incidentaly deleted all my non-commited changes.

that will require registering an app in MusicBrainz

see installation instructions

OK. Thank you I will try that

LordSputnik: Could you give me the line in /config/test.py which I should change, It erased itself after the merge.

Gentlecat, after following the instructions in the docs and at MusicBrainz, I recieved this error when trying to run `python run.py` socket.error: [Errno 98] Address already in use

Mineo: It might be better not to close SOLR issues that are fixed, but not deployed. (cc: yeeeargh)

Mineo: Could you look at/answer http://forums.musicbrainz.org/viewtopic.php?pid... ?

whoops :D

Freso: LordSputnik: I'm not sure how far did you get with the oauth2 plugin, but note that there already is a JSON endpoint that could work

based on https://github.com/discourse/discourse-oauth2-b... it should be usable for that

Nevermind, it fixed

chirlu`: what’s that count in all of those json results. the count: 5, in http://chirlu.mbsandbox.org/ws/2/release-group/... for example?

Freso: with omniauth?

yeeeargh: Generally, I have no idea. ;-)

I’m not actually involved in the search server part. MBS only forwards the requests.