-
LordSputnik
stanislas: there's no rush, I'm fine with you submitting now and then fixing it later
2016-01-25 02502, 2016
-
stanislas
So should I work on it before 17:00?
2016-01-25 02528, 2016
-
stanislas
Or it will be fine to continue doing it tomorrow evening ?
2016-01-25 02547, 2016
-
stanislas
2016-01-25 02555, 2016
-
Bookzombie
2016-01-25 02534, 2016
-
LordSputnik
stanislas: It'll be OK to keep working after 17:00
2016-01-25 02543, 2016
-
LordSputnik
Hmm
2016-01-25 02507, 2016
-
stanislas
Submitted.
2016-01-25 02515, 2016
-
LordSputnik
Actually, the rules do say that we can only accept work done until the 25th
2016-01-25 02558, 2016
-
LordSputnik
stanislas: I'll take a look now, and see what needs to be done to get it working, then comment on the task
2016-01-25 02507, 2016
-
stanislas
ok
2016-01-25 02509, 2016
-
stanislas
I am sorry for making you work that late.
2016-01-25 02503, 2016
-
LordSputnik
stanislas: it's OK :)
2016-01-25 02555, 2016
-
stanislas
Should I wait now or you would describe what I should do tomorrow and I would just do it before 17?
2016-01-25 02505, 2016
-
stanislas
LordSputnik: ^
2016-01-25 02545, 2016
-
LordSputnik
stanislas: don't wait ;)
2016-01-25 02505, 2016
-
stanislas
So you are going to describe what is wrong ?
2016-01-25 02508, 2016
-
LordSputnik
stanislas: I've got it rendering, but not entirely fixed yet
2016-01-25 02511, 2016
-
LordSputnik
Yes I will
2016-01-25 02512, 2016
-
stanislas
Ok. So I am going to sleep. Thank you very much. You are the best :)
2016-01-25 02550, 2016
-
dseomn has quit
2016-01-25 02534, 2016
-
dseomn joined the channel
2016-01-25 02553, 2016
-
Lingo joined the channel
2016-01-25 02505, 2016
-
Lingo has quit
2016-01-25 02546, 2016
-
bitmap has quit
2016-01-25 02541, 2016
-
bitmap joined the channel
2016-01-25 02558, 2016
-
Lingo joined the channel
2016-01-25 02510, 2016
-
Lingo has quit
2016-01-25 02525, 2016
-
Nyanko-sensei joined the channel
2016-01-25 02555, 2016
-
D4RK-PH0ENiX has quit
2016-01-25 02523, 2016
-
Nyanko-sensei has quit
2016-01-25 02551, 2016
-
D4RK-PH0ENiX joined the channel
2016-01-25 02534, 2016
-
rahulr joined the channel
2016-01-25 02539, 2016
-
Lingo joined the channel
2016-01-25 02500, 2016
-
Lingo has quit
2016-01-25 02510, 2016
-
typhoe has quit
2016-01-25 02550, 2016
-
typhoe joined the channel
2016-01-25 02558, 2016
-
opatel99 has quit
2016-01-25 02556, 2016
-
JonnyJD_ joined the channel
2016-01-25 02541, 2016
-
Lingo joined the channel
2016-01-25 02550, 2016
-
Lingo has quit
2016-01-25 02555, 2016
-
opatel99 joined the channel
2016-01-25 02532, 2016
-
regagain has quit
2016-01-25 02508, 2016
-
JonnyJD_ has quit
2016-01-25 02503, 2016
-
Nyanko-sensei joined the channel
2016-01-25 02557, 2016
-
d4rkie joined the channel
2016-01-25 02515, 2016
-
D4RK-PH0ENiX has quit
2016-01-25 02518, 2016
-
Nyanko-sensei has quit
2016-01-25 02520, 2016
-
Lingo joined the channel
2016-01-25 02540, 2016
-
Lingo has quit
2016-01-25 02558, 2016
-
ariscop has quit
2016-01-25 02523, 2016
-
Lingo joined the channel
2016-01-25 02541, 2016
-
Lingo has quit
2016-01-25 02518, 2016
-
Lingo joined the channel
2016-01-25 02513, 2016
-
github joined the channel
2016-01-25 02513, 2016
-
github
2016-01-25 02513, 2016
-
github
messybrainz-server/master b5d6136 Frederik “Freso” S. Olesen: Remove ETA for first data dump.
2016-01-25 02513, 2016
-
github
messybrainz-server/master 203688d Alastair Porter: Merge pull request #13 from Freso/master...
2016-01-25 02513, 2016
-
github has left the channel
2016-01-25 02525, 2016
-
Lingo has quit
2016-01-25 02527, 2016
-
Bookzombie
2016-01-25 02529, 2016
-
Bookzombie
2016-01-25 02546, 2016
-
opatel99 has quit
2016-01-25 02522, 2016
-
ariscop joined the channel
2016-01-25 02557, 2016
-
Lingo joined the channel
2016-01-25 02523, 2016
-
dpmittal joined the channel
2016-01-25 02558, 2016
-
Bookzombie
2016-01-25 02546, 2016
-
Lingo has quit
2016-01-25 02544, 2016
-
Bookzombie
2016-01-25 02557, 2016
-
stanislas
LordSputnik: I will fix the commit messages in some time.
2016-01-25 02505, 2016
-
stanislas
LordSputnik: (Merge all of them)
2016-01-25 02520, 2016
-
stanislas
LordSputnik: But I want to keep them as they are for a while
2016-01-25 02551, 2016
-
UmkaDK joined the channel
2016-01-25 02515, 2016
-
Bookzombie
2016-01-25 02513, 2016
-
adesh joined the channel
2016-01-25 02553, 2016
-
adesh has quit
2016-01-25 02551, 2016
-
UmkaDK_ joined the channel
2016-01-25 02523, 2016
-
UmkaDK has quit
2016-01-25 02502, 2016
-
demonimin has quit
2016-01-25 02538, 2016
-
d4rkie has quit
2016-01-25 02546, 2016
-
dpmittal has quit
2016-01-25 02507, 2016
-
D4RK-PH0ENiX joined the channel
2016-01-25 02543, 2016
-
zag joined the channel
2016-01-25 02549, 2016
-
alastairp
should I file tickets about xml format of search results under search or mbs/webservice?
2016-01-25 02521, 2016
-
alastairp
Issues: 48 created and 54 resolved <- musicbrainz hackers on fire. more resolved than created!
2016-01-25 02552, 2016
-
reosarevok
alastairp: search won't get touched, so :p
2016-01-25 02510, 2016
-
reosarevok
If you mean the new search, then dunno if MBS or SOLR
2016-01-25 02517, 2016
-
alastairp
no, old search
2016-01-25 02504, 2016
-
alastairp
2016-01-25 02506, 2016
-
alastairp
just in case
2016-01-25 02507, 2016
-
reosarevok
I guess add them to MBS. If they're not an MBS ticket they won't get done anyway, so
2016-01-25 02540, 2016
-
reosarevok
Hmm. Isn't XML supposed to show empty tags, or am I remembering wrong?
2016-01-25 02549, 2016
-
reosarevok
(to match the given structure schema)
2016-01-25 02512, 2016
-
alastairp
well, it's a valid tag
2016-01-25 02521, 2016
-
alastairp
but it doesn't show in the entity view, so I guess it's a bug
2016-01-25 02514, 2016
-
reosarevok
Yeah, they should probably be the same, just wondering which side is wrong :)
2016-01-25 02524, 2016
-
alastairp
search :)
2016-01-25 02547, 2016
-
Bookzombie
2016-01-25 02531, 2016
-
Bookzombie
2016-01-25 02500, 2016
-
stanislas
LordSputnik: Hi again. When I use the code, It routes me to the old version. Have I placed the routing things correctly ?
2016-01-25 02506, 2016
-
dpmittal joined the channel
2016-01-25 02528, 2016
-
LordSputnik
stanislas: scroll down a few lines - you'll want to move the routing code you've written into there to replace that "res.render" (after revision.user)
2016-01-25 02549, 2016
-
LordSputnik
(Line 308-312)
2016-01-25 02522, 2016
-
stanislas
2016-01-25 02506, 2016
-
LordSputnik
stanislas: delete line 300 and 305 - you're already inside a routing function
2016-01-25 02515, 2016
-
LordSputnik
(line 263)
2016-01-25 02539, 2016
-
LordSputnik
This entire file gets attached to the /revision endpoint, so "/:id" becomes "/revision/:id"
2016-01-25 02542, 2016
-
alastairp
Gentlecat: can you release messybrainz?
2016-01-25 02547, 2016
-
alastairp
I don't have my ssh key at work
2016-01-25 02501, 2016
-
Gentlecat
what server is it on again?
2016-01-25 02554, 2016
-
Gentlecat
babar?
2016-01-25 02517, 2016
-
Gentlecat
git pull & restart uwsgi?
2016-01-25 02543, 2016
-
stanislas
LordSputnik: Ok, working
2016-01-25 02530, 2016
-
LordSputnik
stanislas: good :) now just need to fix up stuff like the " " being rendered literally, if you haven't so far
2016-01-25 02543, 2016
-
stanislas
LordSputnik: Yeah, i see
2016-01-25 02549, 2016
-
stanislas
LordSputnik: I am working on it now
2016-01-25 02526, 2016
-
Gentlecat
alastairp: ^^
2016-01-25 02535, 2016
-
alastairp
Gentlecat: yes
2016-01-25 02543, 2016
-
alastairp
actually, it's just a template update
2016-01-25 02545, 2016
-
alastairp
so just git pull
2016-01-25 02501, 2016
-
Gentlecat
done
2016-01-25 02528, 2016
-
alastairp
thanks. Freso^
2016-01-25 02534, 2016
-
Gentlecat
looks borked
2016-01-25 02559, 2016
-
Gentlecat
2016-01-25 02552, 2016
-
Gentlecat
alastairp: when was the last time you deployed it?
2016-01-25 02517, 2016
-
alastairp
oh. perhaps not before we rewrote the postgres support :/
2016-01-25 02542, 2016
-
gcilou
Freso, Gentlecat, I uploaded screenshot to the PR
2016-01-25 02517, 2016
-
gcilou
*screenshots
2016-01-25 02527, 2016
-
gcilou
and ^LordSputnik (I had not seen until now that you were one of the mentors for that task ;) )
2016-01-25 02534, 2016
-
Gentlecat
alastairp: I can rollback to some other version, but don't know which one
2016-01-25 02552, 2016
-
Gentlecat
I'm also in a class, so this might have to wait a bit :P
2016-01-25 02516, 2016
-
alastairp
oh, heh
2016-01-25 02559, 2016
-
alastairp
we haven't added it to metabrainz sentry, right?
2016-01-25 02501, 2016
-
alastairp
is it still on yours?
2016-01-25 02512, 2016
-
Gentlecat
no
2016-01-25 02517, 2016
-
dpmittal_ joined the channel
2016-01-25 02522, 2016
-
alastairp
right. I see an error on your sentry :)
2016-01-25 02532, 2016
-
alastairp
is there a stacktrace in the log file?
2016-01-25 02539, 2016
-
alastairp
2016-01-25 02546, 2016
-
github joined the channel
2016-01-25 02546, 2016
-
github
2016-01-25 02546, 2016
-
github
messybrainz-server/master 78e9168 Alastair Porter: Switch db connection to sqlalchemy engine
2016-01-25 02546, 2016
-
github has left the channel
2016-01-25 02556, 2016
-
alastairp
(I just edited it on github, I didn't test it)
2016-01-25 02513, 2016
-
dpmittal has quit
2016-01-25 02527, 2016
-
Gentlecat
2016-01-25 02522, 2016
-
Gentlecat
another one now
2016-01-25 02510, 2016
-
dpmittal_ is now known as dpmittal
2016-01-25 02514, 2016
-
LordSputnik
gcilou: that looks good. Unless Freso or Gentlecat have specified it, "MetaBrainz Projects" might be a better title
2016-01-25 02547, 2016
-
LordSputnik
It may also look better to justify the text, so that the line lengths are the same
