and as you also saw, there were some problems with time resolution
armalcolite
we can directly make the script accessible using web interface as it requires just 2 params
yeah
7GHAAFKAV joined the channel
alastairp
yes, that’s definitely an idea that we originally had
however if we run the script on our server, there’s a possibility that last.fm will block us
armalcolite
alastairp: that is a serious issue.
alastairp
this is why we have not implemented the API reading yet
armalcolite
we can possibly provide option to distribute the script
and users can run it.
alastairp
right, but to who? our target audience for ListenBrainz are music fans, not technical people
and making a properly distributed system like that is very difficult to get right, and to prevent abuse
armalcolite
a simple app would be fine
alastairp
if people download an app, they will need an api key. this is also possibly difficult
in fact, lastfm still has problems with creating api keys since they released their new site
armalcolite
we can just ask for login and extract the key ourselves. easing out the process
alastairp
in fact, I don’t think it’s possible to do that
we shouldn’t ask people for their lastfm password (from our website), that’s a security issue and probably a breach of their terms of service
armalcolite
alastairp: agreed. i missed this part.
Lotheric_ joined the channel
alastairp
I think there’s 2 ways we could do this
1) have javascript like we currently have, but it uses the API instead of the website. If lastfm blocks the api key, we change it
2) have a server script like you proposed. if lastfm blocks us, we address that issue when we get to it
aron_kexp joined the channel
Lotheric has quit
for 1) we would have to distribute a lastfm api key to people’s browsers, and also verify that they have the correct access-control headers available for us to do it
I like 1) more, because it means that we will not become a bottleneck for scraping people’s data
but it does mean that we have to write the scraper in javascipt instead of pythong :(
python
armalcolite
alastairp: i know that part. javascriot not an issue
alastairp: but what about efficiency?
alastairp: this solution certainly works.
alastairp
part of the reason that the current javascript is inefficient is that it load html for every page in a user’s profile
and I think we (or the browser) keeps this in memory somehow
armalcolite
but bottleneck is we are dependent on ui, which is not reliable
alastairp
I think if we used the API it would be less of a problem
have you looked at the source code of the scraper?
armalcolite
not yet.
i just figured out that bookmarklet uses it.
alastairp
right
this was our trick to get around the API key requirement
armalcolite
it seems it just extracts data from DOM
alastairp
exactly
we make an ajax request to /library?page=x"
and then just read the dom
armalcolite
yeah. saw it
alastairp
I propose that we make a new bookmarkelet which uses the api instead
armalcolite
in that case if something changes, it gets broken.
rnikhil has quit
alastairp: ok. i can work on it.
alastairp
cool!
aron_kexp has quit
umeshksingla has quit
armalcolite: if you read that scraper you should be able to work out why it doesn’t work on your library either
armalcolite
alastairp: surely. my first task would be to understand and find out why it did not work.
travis-ci joined the channel
travis-ci
metabrainz/picard#1301 (master - 94bc68c : Philipp Wolfer): The build passed.
kartikgupta0909: commented on your PR. it looks really good so far. there’s a handful of stylistic things, and some suggestions on how to show the data better
ariscop joined the channel
yeeeargh has quit
Gentlecat
Freso: can you add categories for missing projects?
CB, LB
bitmap
Freso: can you also make the default email settings for new users not spam them about every new topic?
chirlu`
Preferably even all-off (even the weekly digest).
Gentlecat: Not sure what will happen to the flag – I clicked “Defer” for now since I don’t think the post is too problematic.
Phantomas joined the channel
If he is unwilling to read, well, not much that can be done.
Gentlecat
right, just kind of unfortunate to have this kind of attitude in first topics