LordSputnik, is anything currently using the {Creator,...}Revision.entity relation?
2016-04-14 10548, 2016
Leftmost
Wondering if we can revise it to fetch the full entity for that revision using the constrained relations trick.
2016-04-14 10530, 2016
D4RK-PH0ENiX joined the channel
2016-04-14 10537, 2016
D4RK-PH0ENiX has quit
2016-04-14 10545, 2016
LordSputnik
Leftmost: revision diffs are
2016-04-14 10505, 2016
D4RK-PH0ENiX joined the channel
2016-04-14 10516, 2016
D4RK-PH0ENiX has quit
2016-04-14 10522, 2016
D4RK-PH0ENiX joined the channel
2016-04-14 10517, 2016
LordSputnik
Leftmost: are you happy with the react cleanup stuff?
2016-04-14 10548, 2016
Leftmost
LordSputnik, mostly. I need to look a bit more closely, but I was waiting to merge until we were release-ready, as long as that makes sense to you.
2016-04-14 10533, 2016
LordSputnik
Aren't we release-ready apart from that?
2016-04-14 10514, 2016
Leftmost
I meant waiting until after the release. Are there any bugfixes in it, or is it just cleanup?
2016-04-14 10531, 2016
Leftmost
`GET /publication/095a221b-4c61-44d3-ab85-a98772dfd842/relationships` 404 trying to edit relationships.
2016-04-14 10543, 2016
LordSputnik
Leftmost: fixed
2016-04-14 10525, 2016
LordSputnik
Leftmost: any reason to delay? It should slightly improve performance and it should be easy to test
2016-04-14 10534, 2016
LordSputnik
(the react stuff)
2016-04-14 10548, 2016
Leftmost
I've almost got index revision fetching working well, but I don't have a clean way of getting the type of an entity associated with a revision at hand and it could probably use a bit of UI love, which I'll test now that rels are working.
2016-04-14 10508, 2016
Leftmost
I was delaying react mostly because of testing concerns, but I suppose there's not much call.
2016-04-14 10557, 2016
LordSputnik
Leftmost: If we can load last changed entities rather than recent revisions, that would be better
2016-04-14 10523, 2016
LordSputnik
I changed from recent revisions partly because a lot of revisions on one entity would flood the list with just that entity
2016-04-14 10543, 2016
LordSputnik
So it should only need constraining the current query to ensure that the list of entities returned is unique
2016-04-14 10528, 2016
Leftmost
I suppose so.
2016-04-14 10550, 2016
LordSputnik
I mean, we could load revisions and then filter so that there's only one of each entity bbid, but then the main problem is fetching the entities for those revisions
2016-04-14 10530, 2016
LordSputnik
So it seems simpler to get 5 lists of unique entities of each type sorted by master revision time and merge them
2016-04-14 10526, 2016
Leftmost
I'm not completely happy with that, but for now I'll just make it work and I can think more about it later.
2016-04-14 10556, 2016
Leftmost
LordSputnik, whatever is happening, directly setting the sortname field isn't triggering an update of the AliasRow component, so it never re-runs getValid().
2016-04-14 10528, 2016
Leftmost
I don't understand react well enough to know how that should be happening.
2016-04-14 10518, 2016
LordSputnik
Leftmost: yeah, setting the value as it's done at the moment isn't the right way to do it
2016-04-14 10527, 2016
anthony25 has quit
2016-04-14 10524, 2016
LordSputnik
The sort name input needs a value prop and an onChange prop to store the updated value in the AliasRow state
2016-04-14 10506, 2016
LordSputnik
guessSortNames then needs to update the stored value in the state, which'll trigger a re-render
2016-04-14 10518, 2016
Leftmost
And that value prop comes from state, and that state needs to be initialized?
