If there are any other topics, we'll cover those quickly after before finishing
2016-04-23 11440, 2016
LordSputnik
So I think we could use mostly the same endpoints as for the current WS
2016-04-23 11405, 2016
LordSputnik
I'd like to split sub-properties of entities back out into subdirectories, like <entity>/aliases
2016-04-23 11427, 2016
LordSputnik
And then we can POST/PUT to those endpoints for editing
2016-04-23 11446, 2016
LordSputnik
We could also implement a system like MB's for including subdirectories in the /<entity> response
2016-04-23 11450, 2016
Leftmost
Agreed on the endpoints. I'd still like to name lists in plural, and I think the bikeshed should be blue, but for the most part it seems sane.
2016-04-23 11410, 2016
Freso
(Btw, if you want to stick to 1h meetings, you have ~4 minutes left.)
2016-04-23 11420, 2016
LordSputnik
Leftmost: the bikeshed should be green
2016-04-23 11446, 2016
Leftmost
I think that makes sense. Anything that's not filled out in the /<entity> response can be a subresource, but also includable.
2016-04-23 11449, 2016
LordSputnik
Freso: eh not a huge concern
2016-04-23 11453, 2016
Freso
And the bikeshed should obviously be in your official MetaBrainx project colours.
2016-04-23 11458, 2016
Freso
*-Brainz
2016-04-23 11417, 2016
LordSputnik
Leftmost: plural lists makes sense
2016-04-23 11420, 2016
Leftmost
I tend to think most editing will happen on the /<entity>, but we can make it possible to edit on the subresource too.
2016-04-23 11432, 2016
LordSputnik
I'd also like to ignore trailing slashes, so that both URLs work
2016-04-23 11450, 2016
Leftmost
Agreed.
2016-04-23 11415, 2016
LordSputnik
Leftmost: I'd like to remove the editing of sets on /<entity>, because the current WS interface for set editing is horrible
2016-04-23 11409, 2016
Leftmost
LordSputnik, I think we can make it sane, and I feel like anything that can be displayed on an entity resource should be editable.
2016-04-23 11413, 2016
LordSputnik
"DELETE <entity>/aliases/1569" makes more sense than "POST <entity {aliases: [[1569, null]}"
2016-04-23 11435, 2016
LordSputnik
err "PUT" not POST
2016-04-23 11404, 2016
Leftmost
I agree, and we can encourage people to use that for small changes.
2016-04-23 11434, 2016
Leftmost
I just think it should be possible to PUT an entity whole cloth.
2016-04-23 11442, 2016
Freso
Can you refer /:entity/ to /:entity?
2016-04-23 11447, 2016
LordSputnik
The alternative would be to allow submission of the whole target alias set
2016-04-23 11453, 2016
Freso
*redirect
2016-04-23 11403, 2016
LordSputnik
Freso: hopefully... we used to
2016-04-23 11409, 2016
Freso
Okay. Good. :)
2016-04-23 11445, 2016
Freso is kind of annoyed by e.g., https://musicbrainz.org/user/Freso/edits/ not → https://musicbrainz.org/user/Freso/edits
2016-04-23 11402, 2016
Freso should maybe make a ticket, if there isn't one already
2016-04-23 11436, 2016
Leftmost
LordSputnik, well, I see PUT and PATCH both being useful for entities. PUT should be the whole cloth entity, in which case the alias set would replace the existing one (if it differs). PATCH would be the partial entity, and figuring out semantics for the sets would be a pain, so I see no problem making that "add-only" for sets or just making sets do nothing in PATCH.
2016-04-23 11408, 2016
Leftmost
For PUT, though, I think we definitely want to take a whole-cloth entity, sets and all.
2016-04-23 11458, 2016
LordSputnik
Leftmost: That's fine for PUT
2016-04-23 11428, 2016
LordSputnik
I think PATCH should also use whole sets, but allow editing of individual fields of the entity (be shallow rather than deep)
2016-04-23 11450, 2016
LordSputnik
POST /<entity>/set can also follow the whole set syntax
2016-04-23 11459, 2016
Leftmost
That makes sense.
2016-04-23 11440, 2016
LordSputnik
ah
2016-04-23 11442, 2016
LordSputnik
maybe not
2016-04-23 11448, 2016
LordSputnik
DELETE /<entity>/set/<id> can delete a single item, POST /<entity>/set/<id> can make a new item, and PUT /<entity>/set/<id> can update an item
2016-04-23 11452, 2016
LordSputnik
err
2016-04-23 11402, 2016
LordSputnik
"POST /<entity>/set" that is
2016-04-23 11428, 2016
Leftmost
Okay, yeah, that seems pretty RESTy.
2016-04-23 11446, 2016
LordSputnik
And we can PATCH items as well if there's any desire for that :P
2016-04-23 11417, 2016
Leftmost
I have a pretty complete picture of how I'd like entities to be represented as JSON, so I'll try to add that to Apiary this week and we can discuss it at the next meeting.
2016-04-23 11440, 2016
LordSputnik
any objections to copying the MB inc syntax?
2016-04-23 11407, 2016
Leftmost
Not offhand, but we can refine it later if need be.
2016-04-23 11411, 2016
LordSputnik
eg. "inc=recordings+labels"
2016-04-23 11439, 2016
LordSputnik
OK, all that sounds good then
2016-04-23 11455, 2016
LordSputnik
Any other topics to discuss today?
2016-04-23 11459, 2016
Leftmost
None from me.
2016-04-23 11414, 2016
stanislas_
LordSputnik: I meant filling the sample responses for requests at that time :)
2016-04-23 11455, 2016
Leftmost
</BANG>
2016-04-23 11444, 2016
LordSputnik
stanislas_: ahh OK
2016-04-23 11446, 2016
Leftmost
That felt like a very productive meeting to me. Some good concrete discussion of UI and the WS.
2016-04-23 11426, 2016
LordSputnik
stanislas_: We'll want to do that before we implement the WS, but no need to do it for now - just getting a general idea of the sort of thing that the request should return is the important thing at this stage
2016-04-23 11434, 2016
LordSputnik
Leftmost: :) yeah that's two in a row
2016-04-23 11440, 2016
LordSputnik
(productive meetings)
2016-04-23 11400, 2016
LordSputnik
So, for next week, I'll develop the UI mockups more, and try to get OAuth done
2016-04-23 11422, 2016
LordSputnik
And you'll try to get your entity ideas into apiary and work on the error prototype?
2016-04-23 11405, 2016
Leftmost
Yep. I'll try to check in on the mockups too if I have a chance.
2016-04-23 11418, 2016
Leftmost
LordSputnik, I'm also going to experiment with using JIRA tickets to organize my development work a bit more as well.
2016-04-23 11410, 2016
Leftmost
I'm also going to additionally use more tag words as well too.
2016-04-23 11426, 2016
LordSputnik
tag words?
2016-04-23 11458, 2016
Leftmost
Just making fun of myself for saying "also... as well".
2016-04-23 11453, 2016
LordSputnik
ahhhh OK
2016-04-23 11449, 2016
Freso
LordSputnik: PM again? :)
2016-04-23 11418, 2016
Leftmost goes to create a JIRA ticket about the error-handling.
2016-04-23 11439, 2016
Freso finally has access to @BB now as well 🙌
2016-04-23 11422, 2016
JesseW joined the channel
2016-04-23 11404, 2016
madmouser1 joined the channel
2016-04-23 11459, 2016
madmouser1 has quit
2016-04-23 11411, 2016
Leo_Verto
LordSputnik, I missed the meeting because I was playing KSP in fullscreen
2016-04-23 11427, 2016
Leo_Verto
But I've set a ping sound for hexchat now
2016-04-23 11411, 2016
Leo_Verto
I have an open PR on bookbrainz-user-guide, mostly updating the browser support table
Freso, a discourse admin question: is it appropriate to edit somebody else's post to add links?
2016-04-23 11404, 2016
kanha has quit
2016-04-23 11420, 2016
Freso
CallerNo6: I wouldn't do it. I would edit your posts to add s's to links so you know that it works if I'm too lazy or otherwise unable to come on IRC and poke you about it at that moment :)
2016-04-23 11415, 2016
CallerNo6
I noticed ^ :-)
2016-04-23 11445, 2016
Freso
That was the point ;)
2016-04-23 11429, 2016
Freso
Luckily it isn't possible to "shadow edit" posts, so original authors get notified and everyone can review what has been changed.
2016-04-23 11436, 2016
Freso
So I don't feel too bad about it.
2016-04-23 11439, 2016
LordSputnik
Leo_Verto: hmm, I actually think we should try to keep as close to CatCat's version as we can for the minimum for now
2016-04-23 11459, 2016
Freso
But I wouldn't outright add content to a post or otherwise significantly alter it.
2016-04-23 11403, 2016
LordSputnik
It may limit us but it keeps CatCat on board and his feedback is useful
2016-04-23 11414, 2016
Leo_Verto
He already has to use userscripts to limit the breakage of BB
2016-04-23 11455, 2016
Leo_Verto
and of course he can continue using an older version, it just won't be officially supported anymore
Freso, for context, I was going to linkify the word "ticket" in a post to point to the ticket in question, but I hesitated because it felt kinda wrong. The OP added a link while I was debating with myself.
2016-04-23 11402, 2016
kanha joined the channel
2016-04-23 11447, 2016
diana_olhovyk_ has quit
2016-04-23 11441, 2016
chirlu
Import has finished in principle, but indexes still have to be created.
2016-04-23 11415, 2016
chirlu
Currently, MBImport is wasting a lot of time due to an “ensuring editor information is present” bug.
2016-04-23 11403, 2016
chirlu
Oh, the no-op has just finished (took only 25 minutes).
2016-04-23 11410, 2016
JesseW joined the channel
2016-04-23 11448, 2016
UmkaDK_ joined the channel
2016-04-23 11442, 2016
hellska has quit
2016-04-23 11412, 2016
UmkaDK has quit
2016-04-23 11455, 2016
kanha has quit
2016-04-23 11414, 2016
chirlu
Gentlecat: Could you do MBS development in your own repository instead of the canonical MeB one?
2016-04-23 11429, 2016
chirlu
That way, any stale branches would remain with you. ;-)
2016-04-23 11407, 2016
Gentlecat
stale branches?
2016-04-23 11412, 2016
chirlu
(Unlike the >100 that the canonical repo has already accumulated over the past years.)
