ok, everyone, thanks for your time. and please keep patient when using mb.org, ok?
2016-06-13 16539, 2016
kartikgupta0909 joined the channel
2016-06-13 16543, 2016
ruaok
no shooting rampages, ok? had enough of those to last a lifetime.
2016-06-13 16553, 2016
kartikgupta0909
Freso: am I late for the meeting again?
2016-06-13 16500, 2016
ruaok
no, go!
2016-06-13 16509, 2016
ruaok
I was about to close,but we've got plenty of time
2016-06-13 16528, 2016
kartikgupta0909
So last week I worked on the server code for giving option to the user for evaluating the dataset on their own machines
2016-06-13 16501, 2016
kartikgupta0909
The PR seemed good to the mentors but needs some modifications.
2016-06-13 16541, 2016
kartikgupta0909
This week I plan to start writing the client which will make request to the server for getting all the pending jobs for the user
2016-06-13 16544, 2016
kartikgupta0909
fin :)
2016-06-13 16559, 2016
ruaok
\ø/
2016-06-13 16504, 2016
ruaok
ok, thanks everyone!
2016-06-13 16507, 2016
ruaok
</BANG>
2016-06-13 16540, 2016
armalcolite
this is weird.
2016-06-13 16505, 2016
armalcolite
this was the 1st time i was waiting for the Freso's queue as a call for the start of meeting.
2016-06-13 16537, 2016
armalcolite
and sadly it did not happen. :'(
2016-06-13 16506, 2016
hellska
gentlecat: I’m working a little bit more on the client side, but I already implemented the API endpoint to receive the datasets, still missing the evaluation part
2016-06-13 16537, 2016
Gentlecat
armalcolite: you can just set a reminder. it's happening every week at the same hour
2016-06-13 16523, 2016
colbydray has quit
2016-06-13 16544, 2016
armalcolite
i set a reminder for 2 hrs before meeting so i can get ready
2016-06-13 16514, 2016
armalcolite
then i engage in other stuff. (today was very critical one)
2016-06-13 16522, 2016
hellska
gentlecat: I think that the two PR I opened are becoming very big and I would like to discuss with you how to divide the future work in smaller chunks to permit faster merge
2016-06-13 16508, 2016
Gentlecat
server PR is fine
2016-06-13 16529, 2016
Gentlecat
I'd just prefer not to merge functions that are unused
2016-06-13 16546, 2016
Gentlecat
you can split up meaningful parts into commits
2016-06-13 16518, 2016
Gentlecat
I don't see the API endpoint btw
2016-06-13 16559, 2016
hellska
oh yes I wanted to add the dataset evaluation and then commit!
2016-06-13 16516, 2016
hellska
between tonight and tomorrow :)
2016-06-13 16516, 2016
Gentlecat
what's in dataset evaluation?
2016-06-13 16543, 2016
Gentlecat
I would suggest to focus on one thing at a time
2016-06-13 16553, 2016
Gentlecat
it would be easier to review and merge
2016-06-13 16513, 2016
Gentlecat
otherwise you are writing parts that depend on each other at the same time
2016-06-13 16529, 2016
Gentlecat
if one needs changes, others probably too
2016-06-13 16547, 2016
hellska
yes, this is why I had the feeling that the PR where becoming big
2016-06-13 16505, 2016
Gentlecat
that's not a problem
2016-06-13 16516, 2016
Gentlecat
the problem is that we can't merge any of them because they are unfinished
2016-06-13 16524, 2016
aron_kexp has quit
2016-06-13 16555, 2016
aron_kexp joined the channel
2016-06-13 16559, 2016
hellska
oh yes I agree, so I’ll try to reach a consistent point in next days
2016-06-13 16521, 2016
hellska
I’m very good in making things more complex that needed :P
2016-06-13 16524, 2016
Gentlecat
here's my suggestion: finish server changes first
2016-06-13 16534, 2016
Gentlecat
without them you can't do anything
2016-06-13 16529, 2016
hellska
yeah, it’s the second time you tell me that! :( I will focus on that untill I finish!!!
2016-06-13 16532, 2016
Gentlecat
then implement support for these features in the client
2016-06-13 16516, 2016
Gentlecat
if we are doing it backwards, then it will never get done
2016-06-13 16529, 2016
Gentlecat
merging everything at the end of gsoc is not going to work
2016-06-13 16548, 2016
hellska
…yes… I agree, by the way now I can focus on server and still have a ‘beta’ of the client to test the API endpoints!
2016-06-13 16519, 2016
Gentlecat
can you push your endpoint updates?
2016-06-13 16533, 2016
hellska
oh yes if you want, but it’s really basic, check if the input is a dictionary and returns a response to the client!
2016-06-13 16551, 2016
Gentlecat
if you want feedback on what you already have
2016-06-13 16547, 2016
alastairp
I definitely recommend to get what you've done uploaded as soon as possible
2016-06-13 16553, 2016
alastairp
especially for feedback
2016-06-13 16505, 2016
alastairp
not sure if if you've been following the discussions we've been having here
2016-06-13 16516, 2016
alastairp
but I said the same to kartikgupta0909 today
2016-06-13 16552, 2016
esmiurium has quit
2016-06-13 16503, 2016
hellska
yes I read the discussion today, that’s why I was thinking also to the size of the PR …
2016-06-13 16518, 2016
alastairp
we should try and get things merged in as soon as they're finished. especially many of the things that you are working on are very distinct from the existing site, so there will be no problem to release often
2016-06-13 16524, 2016
hellska
pushed the endpoint!
2016-06-13 16551, 2016
alastairp
open a pull request too
2016-06-13 16558, 2016
alastairp
it helps us keep all of our comments in the same place
2016-06-13 16538, 2016
alastairp
oh, is this the same branch that you had?
2016-06-13 16551, 2016
hellska
Yes it is in the same branch!
2016-06-13 16540, 2016
ruaok gets a sinking feeling
2016-06-13 16559, 2016
ruaok
our network future is in the hands of the USPS.
2016-06-13 16515, 2016
alastairp
how sturdily built is the switch? :D
2016-06-13 16522, 2016
ruaok
well, at least our switch is purported to be shipped.
2016-06-13 16536, 2016
ruaok
that is another aspect, yes.
2016-06-13 16542, 2016
diana_olhovyk_ joined the channel
2016-06-13 16554, 2016
ruaok
I'm more worried by the bizarre time-warp issues that seem to follow the USPS.
tracking entered into the system 3 days after delivery.
2016-06-13 16517, 2016
ruaok
or package arrives 3 days after the site said it was delivered.
2016-06-13 16544, 2016
LordSputnik
QuoraUK: ping
2016-06-13 16534, 2016
QuoraUK
LordSputnik: Pong
2016-06-13 16532, 2016
LordSputnik
QuoraUK: how has it gone today? :)
2016-06-13 16544, 2016
QuoraUK
Good I think, made some decent progress
2016-06-13 16553, 2016
QuoraUK
got a good start on the profile display for achievements
2016-06-13 16556, 2016
Freso
Hello from opatel99 :)
2016-06-13 16539, 2016
QuoraUK
started on the Creator Creator achievement, just trying to figure out how to get the number of Creators created out of the db, should have it done tommorow
2016-06-13 16553, 2016
QuoraUK
once I have it, i basically have a tonne of new ones for free
2016-06-13 16514, 2016
colbydray joined the channel
2016-06-13 16518, 2016
LordSputnik
hmm, you'd want to get creator revisions which have no parent
2016-06-13 16519, 2016
LordSputnik
QuoraUK: you started doing the achievement page with Jade, but if you want to be able to select achievements on that page to show on the profile, you'll probably need to use React and JS
2016-06-13 16552, 2016
QuoraUK
ahh, ok
2016-06-13 16508, 2016
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | MeB meeting agenda: Reviews, GSoC midterm eval (Freso)
2016-06-13 16510, 2016
QuoraUK
I change that tommorow :P
2016-06-13 16515, 2016
LordSputnik
Prototyping the HTML and CSS in Jade is probably fine though
2016-06-13 16528, 2016
QuoraUK
yeah, I at lease have an idea of how it will look now anyway
2016-06-13 16534, 2016
LordSputnik
But start learning React in the background so that you're ready for moving it over later in the week
2016-06-13 16546, 2016
QuoraUK
sure, can do
2016-06-13 16502, 2016
LordSputnik
good work on getting the refactoring done too
2016-06-13 16528, 2016
QuoraUK
wasn't as bad as I thought tbh
2016-06-13 16556, 2016
LordSputnik
And I think you're right on the VARCHAR vs. TEXT thing, having a limit helps ensure nothing crazy can happen with display
Let's make that 2000, to be on the safe side, and to make it easier to remember
2016-06-13 16540, 2016
QuoraUK
ok sure
2016-06-13 16546, 2016
LordSputnik
Then I'll merge the PR
2016-06-13 16512, 2016
QuoraUK
I was thinking, how will we store the chosen achievements?
2016-06-13 16526, 2016
QuoraUK
will we need another table? or something to add to another table
2016-06-13 16534, 2016
LordSputnik
Good point
2016-06-13 16538, 2016
QuoraUK
perhaps modify unlocks
2016-06-13 16510, 2016
LordSputnik
Yes, there are two ways to do that - add a "chosen" flag to the unlock table, or add a separate table to store the chosen ones
2016-06-13 16553, 2016
LordSputnik
In the past I would've said do the latter, but practically, the former is gonna lead to simpler code, so it's probably better
2016-06-13 16516, 2016
QuoraUK
I think I prefer that practically to be honest
2016-06-13 16527, 2016
QuoraUK
could perhaps rank them as well
2016-06-13 16547, 2016
LordSputnik
And if each person unlocks 50 achievements, and we have a million users, that's still only 50 MB even if PG is storing booleans as bytes
2016-06-13 16509, 2016
LordSputnik
Yeah, might as well rank them too
2016-06-13 16521, 2016
QuoraUK
ok, that sounds good :p
2016-06-13 16537, 2016
LordSputnik
so you could have a null value for not being displayed, and then a small integer giving the display order for those that are
2016-06-13 16515, 2016
QuoraUK
cool, Ill add that in with the 2000char limit and I think that should be it for sql
2016-06-13 16507, 2016
LordSputnik
OK good :) What's your plan for tomorrow?
2016-06-13 16559, 2016
QuoraUK
I'd like to work on the x_revisions achievements a little bit and see if I can figure it out
2016-06-13 16500, 2016
ariscop has quit
2016-06-13 16513, 2016
QuoraUK
have another look into ui
2016-06-13 16526, 2016
QuoraUK
do that sql stuff
2016-06-13 16543, 2016
QuoraUK
move over to react for the profile achievments
2016-06-13 16547, 2016
QuoraUK
actually, I still need to do the svg images, I could do that instead of ui perhaps
2016-06-13 16532, 2016
LordSputnik
OK
2016-06-13 16537, 2016
LordSputnik
That sounds good :)
2016-06-13 16501, 2016
QuoraUK
I have plenty to get on with anyway :P
2016-06-13 16509, 2016
jesus2099 joined the channel
2016-06-13 16524, 2016
Leftmost has quit
2016-06-13 16537, 2016
LordSputnik
Just wanted to add as a side note: It's always best to be careful when deciding whether or not to allow NULL, because it doesn't have any built-in meaning and complicates logic (see http://stackoverflow.com/questions/163434/are-nul…)
2016-06-13 16501, 2016
LordSputnik
But here, it's OK because the alternative would probably complicate the code even more
2016-06-13 16534, 2016
LordSputnik
And to be honest, some of the tables we currently have for this reason would be better off being merged (eg. suspended_users)
2016-06-13 16546, 2016
QuoraUK
alright fair enough, Ill keep that in mind :P
2016-06-13 16549, 2016
LordSputnik
Just so you know if you need it in future ;)
2016-06-13 16500, 2016
LordSputnik
Anyway, think we're done, anything you want to talk about?
2016-06-13 16516, 2016
chirlu has quit
2016-06-13 16518, 2016
QuoraUK
I think im good for today :D
2016-06-13 16545, 2016
LordSputnik
OK, great :) Speak tomorrow!
2016-06-13 16559, 2016
QuoraUK
alright, till tommorow :D
2016-06-13 16520, 2016
jesus2099 has quit
2016-06-13 16521, 2016
chirlu joined the channel
2016-06-13 16505, 2016
gcilou joined the channel
2016-06-13 16556, 2016
chirlu has quit
2016-06-13 16515, 2016
chirlu joined the channel
2016-06-13 16525, 2016
ruaok
oh well, first switch purchase went bad. it will arrive on wednesday.
2016-06-13 16533, 2016
ruaok
purchased another one from a more reputable place.
