that's the downside of using PO files but not "normal" substitutions - msgfmt doesn't know to complain about mismatches for those
2016-07-06 18809, 2016
Zastai
also looks like that should be ...entaire} (no trailing l)
2016-07-06 18841, 2016
Zastai
yeah, making it {vocal:|chant} fixes it
2016-07-06 18800, 2016
Zastai
the other thing (no "display at bottom" clicky) is probably the same issue that prevents the language dropdown from showing when the language isn't set to english; might just be a plackup vs real server thing maybe
I also though {vocal} {vocal:|vocals} was equivalent to {vocal:%|vocals}
2016-07-06 18857, 2016
bitmap
thought*
2016-07-06 18858, 2016
Zastai
chirlu: I did get the UI item once I set up multiple langs in DBDefs and restarted plackup
2016-07-06 18827, 2016
Zastai
js console has a few errors: Cannot find module 'jed-data', Cannot find module '16226aa',
2016-07-06 18841, 2016
Zastai
ReferenceError: MB is not defined; TypeError: document.getElementById(...) is null
2016-07-06 18852, 2016
chirlu
Did you (re-)run compile_resources?
2016-07-06 18805, 2016
Zastai
probably not
2016-07-06 18843, 2016
Zastai
doing so now
2016-07-06 18857, 2016
Zastai
that did it :)
2016-07-06 18835, 2016
Zastai
is there a coding style guideline for the terms used between {} in i18n strings? have set things up the way chirlu suggested (with the : again, but since it's translatable (and so are the comma-lists on either side) that can easily be made to look better in any given language)
2016-07-06 18854, 2016
Zastai
currently have l('{attributes}: {instruments-and-vocals}', ...)
2016-07-06 18813, 2016
Zastai
but if that needs to be underscored/shorter/whatever, that's fine by me
2016-07-06 18845, 2016
chirlu
Using hyphens breaks the => notation, so I wouldn’t do that unless necessary.
2016-07-06 18800, 2016
Zastai
nah, works fine when you quote the hash key
2016-07-06 18811, 2016
chirlu
I call that breaking the notation. :-)
2016-07-06 18857, 2016
Zastai
underscores it is
2016-07-06 18859, 2016
chirlu
I’d probably just use “instruments”.
2016-07-06 18815, 2016
chirlu
In the long run, the vocals are going to become instruments anyway.
2016-07-06 18814, 2016
Zastai
if there's ever a pass on the db to split/normalize old ARs that still have multiple instruments/vocals, it would be {instrument} singular too :)
2016-07-06 18827, 2016
chirlu
Depends on whether I get to finish MBS-7678 first.
2016-07-06 18833, 2016
Zastai
only thing I still haven't quite figured out is how to access $MusicBrainz::Server::Constants::XXX from a template (or where to add code to export them)
2016-07-06 18859, 2016
chirlu
You need to put them into the stash, from the controller.
2016-07-06 18835, 2016
chirlu
zas: It seems OSUOSL’s FTP server has stopped synchronizing with data.mb.o.
2016-07-06 18850, 2016
Zastai
so specifically for the artist controller? there's no easy way to just set it up so that every template can access mb_constants.MY_CONSTANT?
2016-07-06 18836, 2016
gcilou joined the channel
2016-07-06 18828, 2016
Zastai
I spy an artist
2016-07-06 18804, 2016
chirlu
In theory, you could probably put it into MB::S::View::Default. But generally, it’s the individual controller’s task to decide what to hand on to the view.
2016-07-06 18853, 2016
chirlu
Maybe the right place to separate the attributes would be in MB::S::Entity::Role::Linkable::appearances?
2016-07-06 18809, 2016
chirlu
Then the template wouldn’t need the constants at all.
2016-07-06 18819, 2016
Zastai
hmm. i suppose that would also be the place to change the axis of the table so that the template would get relationships grouped by target entity type
2016-07-06 18847, 2016
Zastai
so instead of [mix] followed by <recording> | additional, you'd have [recordings] followed by <recording> | additionally mixed, which would allow reusing the full i18n form
2016-07-06 18820, 2016
Zastai
doesn't strictly require the axis change of course, but without it you're duplicating the section text in each line
2016-07-06 18816, 2016
Zastai
have the constants exported now; diff is quite small this way, and low-impact so will add this change to the PR. If needed I can look at changing that appearances() method instead (I suppose it would just require adding another level of indirection to the returned hash)
2016-07-06 18842, 2016
creature has quit
2016-07-06 18811, 2016
creature joined the channel
2016-07-06 18811, 2016
creature has quit
2016-07-06 18811, 2016
creature joined the channel
2016-07-06 18821, 2016
chirlu
I‘m not sure what you mean by “grouped by target entity type”, actually.
2016-07-06 18832, 2016
Zastai
well, now the appearances are grouped by relationship type name (mix, performance, etc)
2016-07-06 18859, 2016
Zastai
to then have the full textified relationship text where we currently have attributes would duplicate a lot of that
2016-07-06 18854, 2016
Zastai
so instead, perhaps it would make sense to group them by source entity instead, so a section for works, releases etc; then the full localized relationship text duplicates nothing
2016-07-06 18826, 2016
Zastai
but of course, it becomes harder to see all mix credits together, for example
2016-07-06 18801, 2016
Zastai
and I have no real idea what specific uses people have for that page that relies on the current grouping
2016-07-06 18835, 2016
Zastai
nor do i know whether that repetition (having "mixed" in the colum for all lines under the "mix" heading) is really a bad thing per se
with my suggestion, it would have a "recordings" section and a "releases" section, for example. with the recorded at in the "description" column which would replace "attributes"
2016-07-06 18849, 2016
chirlu
Yes, that’s the bug, that the separate sections aren’t actually visible.
2016-07-06 18817, 2016
Zastai
well any ordering below phrase is not currently explicit in the code; that appearances() method just puts rels from an array into a hash by phrase
2016-07-06 18829, 2016
Zastai
nor does the template explicitly group the lines
2016-07-06 18853, 2016
Zastai
and what I meant was that that grouping by phrase would be _replaced_ by that per-entity grouping
2016-07-06 18843, 2016
Zastai
for that ticket, it would have made the distinction clearer; on the other hand, it would not provide an easy chronological overview of "recorded at" relationships (they'd be interspersed with "mixed at" and the like), which may or may not be an issue
2016-07-06 18858, 2016
JonnyJD joined the channel
2016-07-06 18820, 2016
Zastai
I'm not home this weekend, but I'll look at doing some reshuffling there in a separate branch next week to make it clearer what I mean
on a completely different note, with a significant number of dvd's already in the db, and a growing number of blurays (with companies like Square Enix releasing some game soundtracks exclusively on bluray), would it make sense to look at creating a discid variant for them?
2016-07-06 18815, 2016
Zastai
I'd have to look at what SCSI READ STRUCTURE commands return, but I imagine that title/chapter/length information (plus possibly a count/type-list of audio channels) could be used similarly to the current toc addresses
2016-07-06 18811, 2016
davic joined the channel
2016-07-06 18827, 2016
davic has left the channel
2016-07-06 18835, 2016
jnylen joined the channel
2016-07-06 18857, 2016
Zastai
would be for lookups only initially (which the average Picard user would probably appreciate); a given disc structure doesn't necessary have a fixed mapping to track count etc (e.g. when an album's 17 tracks contain stereo, instrumental and 5.1 mixes in 3 different channels) the way a cd toc does
2016-07-06 18803, 2016
Freso has quit
2016-07-06 18812, 2016
Freso joined the channel
2016-07-06 18812, 2016
diana_olhovyk_ has quit
2016-07-06 18851, 2016
Zastai has quit
2016-07-06 18815, 2016
gcilou has quit
2016-07-06 18833, 2016
regagain has quit
2016-07-06 18802, 2016
Mineo has quit
2016-07-06 18818, 2016
kartikgupta0909 joined the channel
2016-07-06 18813, 2016
ariscop has quit
2016-07-06 18803, 2016
Zialus has quit
2016-07-06 18817, 2016
Zialus joined the channel
2016-07-06 18837, 2016
yeeeargh has quit
2016-07-06 18842, 2016
ariscop joined the channel
2016-07-06 18824, 2016
Freso
Zastai: I would personally love to have something like that. If you try your hand at it, you may want to talk with the people from TheTVDb, TheMovieDb, the open movie db (or whatever it's called), etc. as they may want to use it too, and it'd be preferable if we all agreed on something. :)
2016-07-06 18816, 2016
JonnyJD has quit
2016-07-06 18837, 2016
modwizcode
Releasing soundtracks exclusively on Bluray? That seems like a good way to not sell it. Many laptops don't even have a disc drive much less Bluray.
2016-07-06 18809, 2016
Leo_Verto
o_O
2016-07-06 18829, 2016
modwizcode
Many laptops technically have no disk drive either, since SSDs technically contain no disk.
2016-07-06 18851, 2016
Leo_Verto
game soundtrack makes it slightly less bizarre, since gamers are more likely to have a PC with a bluray drive or a gaming console that can read blurays, but still
2016-07-06 18823, 2016
Leo_Verto
I didn't even know there was a standard for music on blurays
