PICARD-941: Check Windows Media Player not updating metadata in background
2017-01-24 02452, 2017
zas
clearly we'll not do that
2017-01-24 02457, 2017
samj1912
yeah we wont
2017-01-24 02414, 2017
samj1912
I was just wondering if we should add a wait for save thread pool to be done
2017-01-24 02438, 2017
samj1912
there have been issues about the UI freezing while saving even though we have a seperate save thread
2017-01-24 02454, 2017
samj1912
I think it is because they aren't completely seperated?
2017-01-24 02436, 2017
zas
frankly i don't know ;) i don't experience UI freezes on any on my systems
2017-01-24 02441, 2017
samj1912
maybe the save thread is blocking the main thread or vice versa?
2017-01-24 02402, 2017
samj1912
there was some ticket somewhere
2017-01-24 02405, 2017
zas
very likely, but it is an issue only when save is slow
2017-01-24 02416, 2017
samj1912
yeah
2017-01-24 02432, 2017
samj1912
that is more of a mutagen issue?
2017-01-24 02406, 2017
zas
imho we need to find a way to simulate a slow filesystem, and see how Picard behave
2017-01-24 02429, 2017
zas
because it is very likely issues are hidden when using a fast fs
2017-01-24 02441, 2017
zas
we have many reports about network shares
2017-01-24 02444, 2017
samj1912
also luks was of the opinion we should remove the monkey patching for insert bytes and delete bytes
2017-01-24 02450, 2017
SothoTalKer
might try windows? :)
2017-01-24 02401, 2017
D4RK-PH0ENiX joined the channel
2017-01-24 02408, 2017
zas
lol.
2017-01-24 02410, 2017
samj1912
yeah, the network share problems :\
2017-01-24 02431, 2017
zas
this monkey patching is useless or no ?
2017-01-24 02409, 2017
zas
luks said it is now; but are there cases it is still useful ?
2017-01-24 02429, 2017
zas
about PICARD-941, i wonder if we could simply check for file changes just before saving, and warn user (proposing to reload/merge changes if possible) ?
file monitoring using qfilewatch is a bad idea, i read about it, and basically most implementations just suck (but inotify/linux) and it is very likely to not work well on all platforms
2017-01-24 02430, 2017
zas
too many limitations (number of files) or performance issues (win/mac)
2017-01-24 02435, 2017
samj1912
hmmm
2017-01-24 02444, 2017
samj1912
we can check for date modified?
2017-01-24 02451, 2017
SothoTalKer
you ciuld check if file modification time has changed.
2017-01-24 02454, 2017
samj1912
that seems like the easiest way
2017-01-24 02415, 2017
zas
to start with, yes
2017-01-24 02445, 2017
samj1912
also zas, we should remove the compatid3 files and the monkey patching imo
2017-01-24 02404, 2017
SothoTalKer
maybe also check when picard was in background and has become the active window again?
2017-01-24 02418, 2017
samj1912
I had a discussion with lazka about compatid3 as well when I was having trouble with TSST/TMOO tags
2017-01-24 02454, 2017
zas
samj1912: i tend to agree, it looks to me it causes more issues than it solves
2017-01-24 02420, 2017
samj1912
yeah, plus its hard to isolate the issue, whether its with picard or mutagen :P
2017-01-24 02448, 2017
samj1912
so should we remove it now or 1.4.1?
2017-01-24 02454, 2017
samj1912
or later?
2017-01-24 02408, 2017
zas
not sure, looks like too important to do it now, but if it causes serious issues, so i would postpone it to 1.4.1
if it prevents possible file corruption we may include it in 1.4.0
2017-01-24 02427, 2017
alastairp
praisethemoon: are you downloading the VM image, or building it yourself?
2017-01-24 02436, 2017
alastairp
if you're just downloading the image, you don't need to do anything
2017-01-24 02437, 2017
praisethemoon
alastairp, downloaded the VM
2017-01-24 02446, 2017
praisethemoon
but I can't find pg
2017-01-24 02401, 2017
alastairp
what are you trying to do?
2017-01-24 02413, 2017
praisethemoon
connect to the Database from Host to Guest
2017-01-24 02423, 2017
praisethemoon
(Host Being Win10)
2017-01-24 02425, 2017
samj1912
zas, at max we can show an icon that a file has been modified while it is being saved?
2017-01-24 02433, 2017
zas
the question is what to do if we detect file changes, for sure we need to prevent any write
2017-01-24 02433, 2017
alastairp
the VM runs using docker inside the virtual machine, so you won't see a process running on the VM guest
2017-01-24 02452, 2017
praisethemoon
ah .. so how can I connect to it? ^^
2017-01-24 02457, 2017
alastairp
there was someone trying this on the forum last week
2017-01-24 02458, 2017
alastairp
let me see
2017-01-24 02408, 2017
praisethemoon
alright, thanks ^^
2017-01-24 02411, 2017
samj1912
an icon to show it is modified?
2017-01-24 02436, 2017
zas
samj1912: error icon and log ?
2017-01-24 02443, 2017
samj1912
yeah
2017-01-24 02431, 2017
zas
in any case we'll skip any save, we can use the same (hacky) stuff we use in case of network error, having an icon saying "problem" and more infos in Infos..
2017-01-24 02441, 2017
alastairp
praisethemoon: do you know how to forward ports to the host using virtualbox?
2017-01-24 02453, 2017
zas
keep it simple, we need first to test it actually changes anything for Sophist
2017-01-24 02406, 2017
zas
so skip save, and log an error
2017-01-24 02421, 2017
praisethemoon
alastairp, uhm, not really, but I can google how to do it
2017-01-24 02435, 2017
alastairp
I'm looking at the configuration for the musicbrainz installation, it looks like port 5432 should be available inside the virtual machine
2017-01-24 02455, 2017
alastairp
you should be able to forward that port to your host and connect to it
2017-01-24 02408, 2017
praisethemoon
alright, gonna try it right away
2017-01-24 02445, 2017
zas
also note that programs may not change the modification date (ie. Picard has such option), so it will not work in all cases
2017-01-24 02402, 2017
samj1912
but that forcibly preserves the earlier date right?
2017-01-24 02419, 2017
samj1912
for general cases it should work?
2017-01-24 02435, 2017
praisethemoon
alastairp, isn't user name "musicbrainz" and pwd "musicbrainz"?
2017-01-24 02402, 2017
zas
i hope so
2017-01-24 02416, 2017
alastairp
praisethemoon: sorry, I don't know
2017-01-24 02429, 2017
praisethemoon
okay :) I think it worked, just need to find the pwd
