#metabrainz

samj1912: https://tickets.metabrainz.org/browse/PICARD-933 was closed with invalid, but we have a PR for it... can you explain ? Is the PR is still valid (then it needs another ticket) ?

PICARD-933: MP3/ID3 Tags corrupted on save

samj1912: ping

zas yes

was away from the desktop

np ;)

PICARD-941: Check Windows Media Player not updating metadata in background

clearly we'll not do that

yeah we wont

I was just wondering if we should add a wait for save thread pool to be done

there have been issues about the UI freezing while saving even though we have a seperate save thread

I think it is because they aren't completely seperated?

frankly i don't know ;) i don't experience UI freezes on any on my systems

maybe the save thread is blocking the main thread or vice versa?

there was some ticket somewhere

very likely, but it is an issue only when save is slow

yeah

that is more of a mutagen issue?

imho we need to find a way to simulate a slow filesystem, and see how Picard behave

because it is very likely issues are hidden when using a fast fs

we have many reports about network shares

also luks was of the opinion we should remove the monkey patching for insert bytes and delete bytes

might try windows? :)

lol.

yeah, the network share problems :\

this monkey patching is useless or no ?

luks said it is now; but are there cases it is still useful ?

about PICARD-941, i wonder if we could simply check for file changes just before saving, and warn user (proposing to reload/merge changes if possible) ?

PICARD-941: Check Windows Media Player not updating metadata in background https://tickets.metabrainz.org/browse/PICARD-941

yeah that is possible

just before saving?

file monitoring using qfilewatch is a bad idea, i read about it, and basically most implementations just suck (but inotify/linux) and it is very likely to not work well on all platforms

too many limitations (number of files) or performance issues (win/mac)

hmmm

we can check for date modified?

you ciuld check if file modification time has changed.

that seems like the easiest way

to start with, yes

also zas, we should remove the compatid3 files and the monkey patching imo

maybe also check when picard was in background and has become the active window again?

I had a discussion with lazka about compatid3 as well when I was having trouble with TSST/TMOO tags

samj1912: i tend to agree, it looks to me it causes more issues than it solves

yeah, plus its hard to isolate the issue, whether its with picard or mutagen :P

so should we remove it now or 1.4.1?

or later?

not sure, looks like too important to do it now, but if it causes serious issues, so i would postpone it to 1.4.1

https://github.com/metabrainz/picard/blob/maste... -> we already read mtime at save time, but we don't at load time

hmm, I can make a PR

we can include it in 1.4.1

if it prevents possible file corruption we may include it in 1.4.0

praisethemoon: are you downloading the VM image, or building it yourself?

if you're just downloading the image, you don't need to do anything

alastairp, downloaded the VM

but I can't find pg

what are you trying to do?

connect to the Database from Host to Guest

(Host Being Win10)

zas, at max we can show an icon that a file has been modified while it is being saved?

the question is what to do if we detect file changes, for sure we need to prevent any write

the VM runs using docker inside the virtual machine, so you won't see a process running on the VM guest

ah .. so how can I connect to it? ^^

there was someone trying this on the forum last week

let me see

alright, thanks ^^

an icon to show it is modified?

samj1912: error icon and log ?

yeah

in any case we'll skip any save, we can use the same (hacky) stuff we use in case of network error, having an icon saying "problem" and more infos in Infos..

praisethemoon: do you know how to forward ports to the host using virtualbox?

keep it simple, we need first to test it actually changes anything for Sophist

so skip save, and log an error

alastairp, uhm, not really, but I can google how to do it

I'm looking at the configuration for the musicbrainz installation, it looks like port 5432 should be available inside the virtual machine

you should be able to forward that port to your host and connect to it

alright, gonna try it right away

also note that programs may not change the modification date (ie. Picard has such option), so it will not work in all cases

but that forcibly preserves the earlier date right?

for general cases it should work?

alastairp, isn't user name "musicbrainz" and pwd "musicbrainz"?

i hope so

praisethemoon: sorry, I don't know

okay :) I think it worked, just need to find the pwd

thank you so much

that seems to say yes

zas so Ill start working on it?

and the database name is musicbrainz_db

samj1912: yes please

ah, could you point me to the network error code that you mentioned for ref?

alastairp, alright, I'm rebooting the system, gonna try now

what's the current state of acousticbrainz, as in, what percentage of musicbrainz has been indexed on acousticbrainz?

there are about 3 million recordings in acousticbrainz

musicbrainz has data for 16 million recordings

cool, thanks.

my bad luck, it keeps telling wrong credentials :(

I would recommend logging into the VM and trying to access it from there using the psql program

it might be an issue with IP access permissions

alright, thanks alastairp :)

alastairp: why edit an old closed style ticket? :/

sigh

I was looking at some tickets

and clicked on the description

and it turned into an edit box

Oh, ok, so it was accidental. Nevermind then :)

I guess it saved it when I closed the page

thanks jira

Czechia ftw!

Lotheric: :D

kachinga!

in french it's Tchéquie :)

Lotheric: Tu m'en diras tant ! https://fr.wikipedia.org/wiki/R%C3%A9publique_t... :D

yvanz: What's your preference yvanz ?

for MB use

btw, j'écris toujours en anglais sur IRC pour le bénéfice de ceux qui ne comprennent pas le français :|

but french is my native language

I use MB in english though

pinging: loujine, reosarevok, CallerNo6, yvanz? freso? any and all userscript writers and users of the community that are good at it to help write

zas can you merge this as well? https://github.com/metabrainz/picard/pull/587

Also those picard website pP

*PRs

I'm in my Estonian class, will check in a few hours when I get home :)

\o/