TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | MeB meeting agenda: reviews, gsoc ideas (mayhem), dev priorities (mayhem), mail (zas)
contacting them is one options, yes.
Quesito
what started this was the digital 1/2. (which is us based)...
mayhem
but unless we have a clear idea that our data is in fact being used, it is nothing but a fishing expedition.
Quesito
yeah
since the email is invalid. should I clean it out?
mayhem
I would leave this be and just sort of be aware of that name
yeah
Freso
Is the next expedition after IKEA?
+that
Quesito
ok
dseomn has quit
Slurpee joined the channel
mayhem tries to pick up where we left off with LB.
dseomn joined the channel
Freso
LordSputnik: Ping?
mayhem
alastairp: IIRC you were going to make more tweaks to the test.py script, right?
sorry, test.sh
alastairp
yep
about 70% done
going home shortly
mayhem
got ETA?
alastairp
hopefully tonight
maybe tomorrow afternoon
mayhem
ok, I'll put some effort towards the integration tests.
sampsyo
Freso: Sadly, GitHub Pages doesn't let you SSL your custom domain. :(
Maybe we should move off of GH pages…
UmkaDK joined the channel
iliekcomputers
i have started with test_api.py too, I'll probably send a PR tomorrow or the day after
Freso
sampsyo: Or maybe they could start doing that with LE now.
alastairp, Gentlecat: for pytest I want to have a set of unit tests and a set of integration tests for LB. I want the unit tests to run separately from the integration tests. Any thoughts on how test files should be laid out to facilitate this?
alastairp
with py.test you can specifify a directory that you want to run
so I'd just have a directory somewhere - perhaps tests/integration ?
CatQuest
[16:30] <Quesito> as idea for decor--world wall map that we can pin where our supporters/users are around the world.
[16:30] <Freso> And community members. And staff/office users.
+1§
+1!
Freso
+1@
+1$
+1*
mayhem
tests/integration seems a bit too conflated still.
alastairp
why? because currently our normal tests are inline in the code?
mayhem
normal tests just test from the top level dir, e.g. test everything.
that would mean that we need to specify a subset for testing.
alastairp
kind of - pytest.ini specifies specific directories to test
github joined the channel
github
[acousticbrainz-server] alastair opened pull request #219: Dataset api clean (master...dataset-api-clean) https://git.io/vDWb5
unfortunately I think that moving existing tests is one of those things that we'd have to have a discussion about
simply because we have the current format in CB/MeB/AB/LB
Gentlecat
I'd vote for not having tests in a separate directory tree
that is I'd prefer to have them either in the same directory as the module they are testing or in ./test
alastairp
FYI, I develop locally with pycharm + uniitest2 test runner
so I'd want to see a very good argument to use pytest specific hooks
I'd like to try and make the argument that integration tests are specific and special enough that they can live in their own tree, even if we leave unit tests inline with the code
hibiscuskazeneko has quit
Gentlecat
would be useful to see some examples
shivamt joined the channel
Slurpee has quit
icode has quit
UmkaDK has quit
Mineo joined the channel
alastairp
-> home, errands, gym, food. I should be back around meeting time, and will try and put something together
I need to have a bit of a think about it
UmkaDK joined the channel
Slurpee joined the channel
anshuman73
Freso: I won't be there for meeting today. Didn't do much this week :(
CallerNo6
oh, anshuman73, I didn't respond the other day. sorry. yes, when we have the dates then let's talk about meeting up during the GCI summit.
samj1912 is writing a boring lex tokenizer for sql for a college project :\
iliekcomputers
Found a small bug in get_listens leading to NameError because current_app was not imported :D
testing ftw!
Gentlecat
zas: looks like it's dropping, no?
if so, it was the indexer for solr
github joined the channel
github
[listenbrainz-server] paramsingh opened pull request #116: Import current_app to api.py so that get_listens doesn't throw error (master...get-listen-fix) https://git.io/vDlkq
github has left the channel
SothoTalKer
alastairp: heh, what I always wondered: how does acousticbrainz deal with deleted entities. for example if one merges some recordings which have AB data.
Gentlecat
it doesn't
SothoTalKer
zas: your link requires a login. :D
ARChak is now known as Apra
CatQuest
I made a generic login on grafana... maybe it can become a "guest" type user
thresh has left the channel
github joined the channel
github
[listenbrainz-server] mayhem closed pull request #116: Import current_app to api.py so that get_listens doesn't throw error (master...get-listen-fix) https://git.io/vDlkq
github has left the channel
mayhem
thanks iliekcomputers :)
iliekcomputers: are you planning on participating in GSoC?
iliekcomputers
mayhem: yea, the stats idea of yours is pretty interesting to me.
mayhem
I had that sneaky suspicion.. :)
iliekcomputers
i was gonna talk about GSoC in today's meeting lol :)
mayhem
given what things are hot today, I suspect that a lot of people will want do that one.
samj1912
when is the gsoc deadline for orgs?
mayhem
9th
iliekcomputers
mayhem: i was also thinking of simpler stuff like pages for artists, release-groups and more stats for users ala last.fm
dboys_ joined the channel
mayhem
stats for users is exactly what I am talking about on the ideas page.
iliekcomputers
mayhem: but the stuff like generic queries was not in my mind :)
it'd be pretty cool
mayhem
I'll say this as general guidance to our GSoC applicants who are already part of our community: Your chances for getting accepted are higher than new people.
iliekcomputers
mayhem: how do you plan to show visualizations? d3.js?
mayhem: that is very nice to hear :D
mayhem
that said, if you design something for yourself that is outside of the given ideas pages, you'll cut down the amount of competition you get.
I hadn't decided anything,but I am fond of d3, yes.
and don't get me wrong, I don't want to make a generic reporting system. I just want to make it easy to add more graphs/reports, etc.
building a truly extensible system is beyond what we need
also, I don't really want to wait until summer to work on these graphs.
if you're thinking of doing this project, we may just want to change the idea page to be a 2 part project.
part 1: iliekcomputers builds. part 2: continue iliekcomputers' work, ideally by iliekcomputers. :)
s/builds/builds graphs/
iliekcomputers
mayhem: I was actually hoping to get started as soon as the beta was deployed :D