yes, moving the validate outside of insert_payload sounds like an OK step
I'm a little busy right now so can't confirm that
(e.g., are there any other places in the code that call insert_payload? from a different codepath)
make the change, and I'll verify it in the PR :)
iliekcomputers
alastairp: from a cursory look at git blame, I think it got added twice in some merge conflict resolution.
I'll see if insert_payload is called anywhere else and if validate needs to be in there, and if it doesn't I'll send a PR moving it out
should probably fix the tabs and spaces in manage.py first though
alastairp
:hooray:
mayhem
Quesito: MB is a product of MeB. MeB is a non-profit.
we have only one legal entity, but multiple projects/products.
ferbncode
Gentlecat: Hi :), I was trying to migrate users code off the ORM. But wasn't sure how it should be done. I tried making a user class so the flask-login stuff gets easy to migrate. Here is a sample > https://github.com/ferbncode/critiquebrainz/blo.... Is there a better or more preferred way of doing this?
CatQuest
...
mayhem
Quesito: if you have a metabrainz account (you should sign up for non commercial use) then you can use the officebrainz site to open the door downstairs
hibiscuskazeneko has quit
zas
CatQuest: run Picard from source, or wait for new packages to be build for your platform
CatQuest has no idea how to run from souce on mac os :/
CatQuest
..but if you've got norwegian picard.mo files. I can put these *inside* the picard.app
can you make a branch an alt branch in picard-plugins?
Quesito
Mayhem I donno, but I should come up with a list...as an important part of the PR world...and not the pull request world...
samj1912
or are we gonna keep it in a diff repo?
github joined the channel
github
[listenbrainz-server] mayhem opened pull request #120: Integration tests (master...integration-tests) https://git.io/vD0yW
github has left the channel
mayhem
alastairp: ^^
iliekcomputers: once we get this merged, you should be clear to write integration tests. we still need to think about how to seperate the integration tests from the unit tests. I *think* we have a way forward on that, but I am not sure yet.
ferbncode
Gentlecat: okay, thanks :)
Freso has quit
jwheare has quit
MightyJay has quit
gcilou has quit
samj1912 has quit
beqn has quit
suhas2go has quit
mayhem has quit
belak has quit
kepstin has quit
zas has quit
reosarevok has quit
Quesito has quit
alastairp has quit
laurie_ has quit
LordSputnik has quit
iliekcomputers
netsplit?
SothoTalKer
no
ocharles has quit
irccloud
alastairp_ joined the channel
alastairp_
huh
irccloud is unhappy
SothoTalKer
i am happy
alastairp_
well, that's one of us
iliekcomputers
oh
irccloud always seemed a bit too heavy to me
jwheare joined the channel
alastairp_
ah, looks like irccloud is coming back
iliekcomputers: it's nice having it stay around all the time
samj1912_riot[m]
this is weird
well anywho this matrix bridge works when irccloud gives up one me