samj1912: ^^ this one has to be fixed for 1.4.1 if confirmed
2017-02-17 04853, 2017
samj1912
Okay :)
2017-02-17 04829, 2017
arbenina_ joined the channel
2017-02-17 04853, 2017
antlarr
zas: probably the user is drag&dropping https urls
2017-02-17 04806, 2017
antlarr
which is fixed by my PR which was postponed for 1.4.1
2017-02-17 04844, 2017
antlarr
ah, sorry, files/folders ...
2017-02-17 04804, 2017
antlarr
I'm too focused on cover art lately...
2017-02-17 04813, 2017
antlarr goes to a corner
2017-02-17 04834, 2017
samj1912
:p
2017-02-17 04840, 2017
antlarr
samj1912: btw, what's the right way to make a track/album change its state to "modified" ? I saw your commit in File.update() that checks if orig_metadata.images has changed
2017-02-17 04802, 2017
antlarr
should I call update() after changing the images of a file?
2017-02-17 04832, 2017
samj1912
depends on your call stack
2017-02-17 04837, 2017
antlarr wonders if it would be better to have a set_front_image in File/Track/Album ...
2017-02-17 04848, 2017
samj1912
if update is being called somewhere afterwards then no need
2017-02-17 04858, 2017
antlarr
when dropping an image on the CoverArtBox, the state isn't changed
2017-02-17 04813, 2017
samj1912
hmm, it should be
2017-02-17 04831, 2017
samj1912
the drag and drop is hidden anyways
2017-02-17 04802, 2017
antlarr
I mean the little icon next to the album/track/file
2017-02-17 04815, 2017
antlarr
that doesn't change for me
2017-02-17 04820, 2017
samj1912
yeah, I mean, the drag and drop functionality is hidden
2017-02-17 04825, 2017
antlarr
ah
2017-02-17 04843, 2017
samj1912
and the coverart changes updating the file status was just recently added
2017-02-17 04853, 2017
samj1912
it was ignored earlier since there was no diff to show
2017-02-17 04858, 2017
samj1912
(now there is)
2017-02-17 04842, 2017
samj1912
antlarr: while you are implementing album/cluster level coverarts
2017-02-17 04853, 2017
samj1912
can you take a look at album/cluster level diffs?
2017-02-17 04809, 2017
antlarr
metadata diffs?
2017-02-17 04813, 2017
samj1912
currently they are calculated on every selection change
2017-02-17 04816, 2017
samj1912
yes
2017-02-17 04823, 2017
samj1912
we could maybe store the data
2017-02-17 04840, 2017
samj1912
it was suggested by sophist, will help speed up the UI
2017-02-17 04836, 2017
samj1912
since we now have a orig_metadata and metadata attribute associated with albums/clusters we can maybe calculate the metadata diffs and store them there as well
2017-02-17 04806, 2017
antlarr
maybe, yes
2017-02-17 04839, 2017
antlarr
I'll think about how to do it (and how to keep track of changes in sub-elements)
I see, I added some debug output, and indeed, TrackItem.update is called, but it doesn't call File.update
2017-02-17 04837, 2017
samj1912
hmm
2017-02-17 04845, 2017
antlarr
when track.num_linked_files == 1, there's no codepath that calls File.update
2017-02-17 04821, 2017
antlarr
and even when track.num_linked_files != 1, item.update is only called when the number of linked files changed
2017-02-17 04811, 2017
antlarr
(AFAICS, at least)
2017-02-17 04815, 2017
samj1912
antlarr: nope when >1 file.update does get called
2017-02-17 04857, 2017
antlarr
ah, sorry, I missed the update inside the first for loop
2017-02-17 04851, 2017
antlarr
ok, I see how that works...
2017-02-17 04823, 2017
antlarr
that TrackItem.update updates the child FileItem objects, but that is supposed to be called from the Track/File update() function, so we can't call the File.update() method from *Item.update
2017-02-17 04842, 2017
antlarr
otherwise, there's an infinite recursion
2017-02-17 04824, 2017
samj1912
hmmm
2017-02-17 04841, 2017
samj1912
antlarr: can you take a look at file drop code more closely and see what needs to be done
reosarevok & other wikifarian: Where can I add a wiki page that isn't necessarily linked to anything, but has in GIANT FUCKING BOLD PRINT: WE DO NOT HAVE ANY OF THE MUSIC YOU ACCUSE US OF HAVING, MOFO! ?
