oh, huh, that's old enough that it predates the 'tray' image type
2017-02-17 04821, 2017
kepstin fixes that
2017-02-17 04829, 2017
Freso
But I might need JonnyJD or someone with admin access on GH to add a hook to make it work properly.
2017-02-17 04853, 2017
Leo_Verto
Freso, while you're at it, could you add the botbot repos too?
2017-02-17 04831, 2017
samj1912
zas ping
2017-02-17 04851, 2017
Freso
Anyone with libdiscid GH admin access around?
2017-02-17 04811, 2017
ruaok
a505bb48-ad65-4af4-ae47-29149715bff9 !!!1!!!!
2017-02-17 04834, 2017
SothoTalKer
not me :))
2017-02-17 04851, 2017
antlarr
samj1912, zas: we're fixing the same issues over and over you in your PR#586 and me in my samj1912-picard258-2 branch
2017-02-17 04815, 2017
antlarr
zas: can you accept samj1912's PR so I can submit my branch and then both work on the same codebase ?
2017-02-17 04835, 2017
samj1912
zas yeah, I think that will be better as for now
2017-02-17 04846, 2017
Leo_Verto
ruaok, what about them?
2017-02-17 04857, 2017
samj1912
my PR serves as a base for visual changes
2017-02-17 04810, 2017
samj1912
antlarr: can take it forward with the next step
2017-02-17 04811, 2017
SothoTalKer
ruaok i will change your irc nick on the gsoc page again
2017-02-17 04824, 2017
SothoTalKer
since you got nickserved :D
2017-02-17 04811, 2017
samj1912
antlarr: did you build the opensuse packages for picard 1.4?
2017-02-17 04819, 2017
samj1912
if yes we can update the link on PW :)
2017-02-17 04808, 2017
antlarr
samj1912: btw, I'm now trying to fix a problem by which CoverArtImage(url=u'http://ec1.images-amazon.… has one hash value, but TagCoverArtImage from a file where I previously saved the same image has another value :(
2017-02-17 04808, 2017
samj1912
antlarr: also I noticed the drag n drop system is a bit rudimentary, it can be improved in a lot of ways
2017-02-17 04826, 2017
samj1912
also no where in the entire UI/documentation do we ever mention this functionality
2017-02-17 04837, 2017
antlarr
samj1912: yes, I built it, but it's still in the development project :( (as in, not submitted to be installed with a simple "zypper install picard")
2017-02-17 04839, 2017
samj1912
only someone who has read the code might be able to find it
yep, you have to click on "show unstable packages"
2017-02-17 04818, 2017
samj1912
ohk cool :D
2017-02-17 04838, 2017
samj1912
antlarr: there are a couple mroe bugs with drag and drop that I found
2017-02-17 04851, 2017
Slurpee has quit
2017-02-17 04854, 2017
antlarr
samj1912: tell me
2017-02-17 04802, 2017
samj1912
lets say you drag and dropped an image on a track and then saved and removed the file
2017-02-17 04808, 2017
antlarr
btw, I didn't read the documentation and I found the feature :)
2017-02-17 04846, 2017
Slurpee joined the channel
2017-02-17 04846, 2017
samj1912
now the track keeps that image and if I add any new files to that track they are added to the new file as well
2017-02-17 04822, 2017
samj1912
there isn't anyway to drag and drop an image just for a file
2017-02-17 04833, 2017
samj1912
it can only be track level
2017-02-17 04848, 2017
antlarr
indeed
2017-02-17 04849, 2017
samj1912
(when there is just 1 file)
2017-02-17 04805, 2017
antlarr
well, you dropped it on the track... :)
2017-02-17 04809, 2017
antlarr
but I see
2017-02-17 04838, 2017
samj1912
the way the drag and drop behaves is a bit weird since its behaviour isn't exactly documented and we dont know how it is expected to behave
2017-02-17 04831, 2017
antlarr
I'll change it to change the image on the files associated with the track, and not on tracks themselves, would that be ok?
2017-02-17 04819, 2017
samj1912
hmm, zas was the one who implemented this (I think) so Ill wait for him to make the final call on how it is expected to behave
2017-02-17 04831, 2017
samj1912
a better approach will be a full fleged dialog box
2017-02-17 04812, 2017
samj1912
also we need to figure out where we can display a tooltip/some sort of info indicating that the images can be dropped on CA thumbnail
2017-02-17 04835, 2017
samj1912
and the infodialog needs a major refactoring :\
2017-02-17 04850, 2017
antlarr
IMHO, I think drag&drop (as well as the coverartbox widget) should only work with front covers, and then you can have a full fledged dialog box to add/remove/edit other types of cover art
2017-02-17 04857, 2017
arbenina_ has quit
2017-02-17 04858, 2017
antlarr
yes, I agree with that
2017-02-17 04830, 2017
antlarr
I was trying to implement good album-level cover art diffs in the infodialog a while ago and thought it would be too difficult to do with the current information it has
2017-02-17 04838, 2017
samj1912
yes
2017-02-17 04842, 2017
samj1912
I was trying to do the same
2017-02-17 04840, 2017
samj1912
all the info is concatenated as a single string and new and it isn't OOP based at all, feels more functional
2017-02-17 04848, 2017
antlarr
yep
2017-02-17 04819, 2017
ruaok
Leo_Verto: about to start live!
2017-02-17 04822, 2017
samj1912
I have lots of qualms with get_coverart_widget and get_type_widget
2017-02-17 04823, 2017
antlarr
I thought it would be nice to have a method in album that iterated over its files and returned a set (not a list) of cover diffs
2017-02-17 04830, 2017
samj1912
they could both be implemented as classes
2017-02-17 04810, 2017
samj1912
oh and drag and dropped images can also be duplicates :\
2017-02-17 04821, 2017
samj1912
I tried dragging the same image twice now and it let me
2017-02-17 04844, 2017
samj1912
also, I just fixed another bug in my recent commits
2017-02-17 04818, 2017
antlarr
that might be related to the problem I mentioned above
2017-02-17 04850, 2017
antlarr
datahash seems to have problems to identify images
and the other is TagCoverArtImage(u'/mnt/DD4/media/musica_ok/Delta Saxophone Quartet/1998 - Minimal Tendencies/15 - Terry Riley - Tread on the Trail.mp3', tag='APIC', types=[u'front'], support_types=True)
2017-02-17 04812, 2017
antlarr
Mineo: ouch
2017-02-17 04836, 2017
antlarr
Mineo: you're right, they both have the same hash
2017-02-17 04829, 2017
antlarr
I think I've been in front of the computer for more than 12 hours today, so it's enough :/
2017-02-17 04806, 2017
agentsim_ joined the channel
2017-02-17 04837, 2017
agentsim has quit
2017-02-17 04812, 2017
Zastai has quit
2017-02-17 04809, 2017
samj1912 sleeps
2017-02-17 04802, 2017
SothoTalKer
night :)
2017-02-17 04832, 2017
suhas2go has quit
2017-02-17 04808, 2017
arbenina_ has quit
2017-02-17 04852, 2017
agentsim_
I just submitted a simple PR to the chromaprint repo, but I didn't think to ask here first if that's the best way to go about suggesting a code change
2017-02-17 04847, 2017
shivamt has quit
2017-02-17 04805, 2017
SothoTalKer
well, the repo admin will probably see the PR and comment on it :)
2017-02-17 04842, 2017
CallerNo6
agentsim_, chromaprint isn't an MeB project. You'd have to ping luks for an official answer. But it certainly looks like an active repo.
2017-02-17 04824, 2017
agentsim_
CallerNo6: ok, I'll wait to see if he notices the PR, otherwise I'll bug him :)
2017-02-17 04859, 2017
kepstin
agentsim_: also go hang out in #acoustid where acoustid and chromaprint stuff is discussed :)
2017-02-17 04814, 2017
agentsim_
kepstin: thx, I wasn't aware of #acoustid
2017-02-17 04837, 2017
hibiscuskazeneko joined the channel
2017-02-17 04848, 2017
CatQuest has quit
2017-02-17 04822, 2017
CatQuest joined the channel
2017-02-17 04817, 2017
SothoTalKer
does anyone know how fast acousticbrainz updates newly added recordings from musicbrainz?
2017-02-17 04846, 2017
Mineo
can anyone with a picard development environment to me a quick favor? check out the branch from https://github.com/metabrainz/picard/pull/586, load a release and save it. do you need to click save *twice* for it to be saved?
2017-02-17 04822, 2017
kepstin
SothoTalKer: not sure what you mean?
2017-02-17 04805, 2017
kepstin
SothoTalKer: oh, you mean how often the mb data is update on the acousticbrainz site? It should be running off the hourly replicated data, I think
){kind=link}