My big concern right now is that async pagination is still stagnating in react-select.
2017-03-04 06333, 2017
LordSputnik
I think it will go through eventually
2017-03-04 06350, 2017
LordSputnik
I think it's just the fact that there are a lot of issues and pull requests, and it takes time to get through them
2017-03-04 06304, 2017
Leftmost
I'm considering trying to contact JedWatson directly, see if I can draw attention to it.
2017-03-04 06323, 2017
LordSputnik
If needed we can fork and pull in that change for the time being
2017-03-04 06332, 2017
deeptibaghel joined the channel
2017-03-04 06340, 2017
deeptibaghel has left the channel
2017-03-04 06312, 2017
deeptibaghel joined the channel
2017-03-04 06310, 2017
Freso
samj1912: It doesn't need him saying which e-mail he prefers as much as whether he's okay with the change in general. (The one listed is the one he's using for his more recent commits. If he preferred the other mail, I'm sure he'd use that now.)
2017-03-04 06328, 2017
Leftmost
As far as babel vs. node, I think part of the issue is that babel can't fully implement ES6 modules, since one of the requirements is static analyzability (which is part of why node still doesn't have an implementation). Hopefully, though, it won't be too painful to transition.
2017-03-04 06332, 2017
samj1912
Freso: so I can go ahead and merge it?
2017-03-04 06348, 2017
samj1912
oh, mis read your message, sorry
2017-03-04 06357, 2017
Freso
samj1912: I'd say yes. He's been given enough time to react on it, and I'm pretty sure I pinged him on IRC too.
2017-03-04 06308, 2017
samj1912
cool :)
2017-03-04 06323, 2017
Freso
If he doesn't like it, we can go ahead and make a new commit to remove him from the file, or change the file.
2017-03-04 06331, 2017
Freso
*change his listing in the file
2017-03-04 06344, 2017
samj1912
hehe okay :P
2017-03-04 06349, 2017
LordSputnik
Leftmost: mhmm, that's one of the reasons I've had to change data-js a little bit
2017-03-04 06309, 2017
samj1912
now that I am free again, I wanted to clean up the pending PRs and move forward with 1.4 so we can start with 2.0 discussion
2017-03-04 06315, 2017
Freso
👍
2017-03-04 06315, 2017
LordSputnik
So now the models are returned by calling the exported function, rather than added to the module
2017-03-04 06333, 2017
LordSputnik
Then we can set them on the express app and refer to them in our routes that way
2017-03-04 06338, 2017
Leftmost
Makes sense to me.
2017-03-04 06325, 2017
LordSputnik
I've also added coverage checking to the site code recently
2017-03-04 06335, 2017
Leftmost
Feel free to ping me for early CR or just to let me know that something's ready. I'm working on better incorporating taking time for BB.
the GH bot really should differentiate between merging and closing a PR
2017-03-04 06330, 2017
LordSputnik
I think we should ask ourselves 1. Does this code look broken? 2. Is it possible this code will break data? and if the answer to those is "no", then push it straight to bookbrainz.org
2017-03-04 06336, 2017
samj1912 meanwhile adds osx tests to travis
2017-03-04 06350, 2017
LordSputnik
If either is yes, wait until the major release and all the thorough testing that goes with that
2017-03-04 06336, 2017
travis-ci joined the channel
2017-03-04 06337, 2017
travis-ci
metabrainz/picard#2075 (master - 9e82a54 : Sambhav Kothari): The build passed.
OK, and I also don't think our docker stuff is set up in the best way
2017-03-04 06313, 2017
Leftmost
How so?
2017-03-04 06356, 2017
LordSputnik
Right now, updating the server is quite difficult. We either need to change things so that the code is stored in a volume mounted on the host FS, add a command to update the code inside the container, or stop using docker in production
2017-03-04 06348, 2017
Nyanko-sensei joined the channel
2017-03-04 06359, 2017
Leftmost
What's the difficulty? Is it to do with spinning up a new instance without taking the site down?
2017-03-04 06348, 2017
LordSputnik
That's part of it, yeah
2017-03-04 06306, 2017
LordSputnik
Also I've just noticed the current code always uses the master branch
2017-03-04 06348, 2017
LordSputnik
The code gets pulled in while the container is built, so you'd need to stop the running container, delete and rebuild it, then start it again
2017-03-04 06313, 2017
LordSputnik
and possibly delete some cached images
2017-03-04 06314, 2017
Leftmost
It seems like the whole idea with docker is that you could build the new container separately, spin it up, then bring down the old one. What about our current setup prevents that?
2017-03-04 06325, 2017
D4RK-PH0ENiX has quit
2017-03-04 06354, 2017
LordSputnik
I haven't tried it, but docker-compose may complicate things
2017-03-04 06312, 2017
Nyanko-sensei has quit
2017-03-04 06318, 2017
LordSputnik
But I think we should modify the docker-compose file and docker images to use an external site checkout, which would make it more suitable to development too
2017-03-04 06327, 2017
Leftmost
Hmm. May be worth talking to zas about how it's set up for MB right now.
2017-03-04 06303, 2017
LordSputnik
But generally I've just found Docker complicates a lot of things that used to be simple for not much benefit
2017-03-04 06338, 2017
LordSputnik
Leftmost: oh yeah, you're right, looks like I can rebuild containers while they're running
I think it'd be ideal if we could address those problems without ditching docker, but I'll admit to still being a bit ignorant about the details of docker.
2017-03-04 06331, 2017
LordSputnik
OK, I think we can do that then
2017-03-04 06325, 2017
Leftmost
That does remind me, though, that I'm still not sure that I can make changes to the production environment. A couple people have come through asking in particular about account linking.
2017-03-04 06352, 2017
D4RK-PH0ENiX joined the channel
2017-03-04 06345, 2017
D4RK-PH0ENiX has quit
2017-03-04 06303, 2017
LordSputnik
Leftmost: ahh OK, if you email me a public key I'll add you now, I'm logged in
AB-290: Viewing the recording information of a dataset or a snapshot requires being logged in
2017-03-04 06312, 2017
LordSputnik
Leftmost: as if to prove my point, test.bookbrainz.org is now broken and not fixable currently :P The docker script pulls in the latest version of dependencies, and if, as in this case, one if broken, I can't easily get in manually to fix it. So we should definitely store the code outside and mount it
2017-03-04 06318, 2017
Leftmost
As far as site work goes, is there any specific surface area you can think of for working on entity editing, or anything you want help with? If not, I may try to work on some tech debt and (once the modularization is done) try getting -data-js in shape in prep for WS stuff.
2017-03-04 06303, 2017
travis-ci joined the channel
2017-03-04 06304, 2017
travis-ci
samj1912/picard#66 (picard-osx - 9a5c9c7 : Sambhav Kothari): The build has errored.
Leftmost: it'd be easiest to pick up working on the entity display stuff
2017-03-04 06340, 2017
Leftmost
Hmm. It should be possible to build the container remotely and deploy, though, shouldn't it? Storing the code outside seems contrary to how docker is supposed to work, but we should do what works.
2017-03-04 06316, 2017
Leftmost
Alright. I may do some sketches on that first and run them by you before I write any code.
2017-03-04 06328, 2017
LordSputnik
So one way we could do it is, I could build a working image for "BookBrainz", and then publish and fetch that from the docker cloud using docker-compose to fetch the dependencies (postgres and redis). This actually might be a really good idea
2017-03-04 06306, 2017
LordSputnik
But the "code outside the image" method is what we would want to use for making sure we're both developing using the same environment, for example
2017-03-04 06308, 2017
Freso
FWIW, alastairp and ruaok have been talking about standardising how AB and the rest of the other MeB projects do Docker stuff.
2017-03-04 06326, 2017
Freso
(I think AB does Docker slightly different than the other ones right now?)
2017-03-04 06357, 2017
Freso
Not sure if related, but maybe try and ask them too. Would be nice if BB had the same Docker structure as the other projects.
2017-03-04 06344, 2017
Leftmost
Agreed. It's possible they've already thought about these issues. At the very least, we can raise them, but it'd definitely be nice to be on the same page.
2017-03-04 06317, 2017
LordSputnik
We should all talk about docker at some point
2017-03-04 06302, 2017
LordSputnik
For now, I'm going to go with my last two messages, since they seem sensible and fairly easy to implement as stepping stones to whatever we eventually come up with
2017-03-04 06323, 2017
Leftmost
I won't be able to attend the meeting Monday, but you guys could discuss it, or we could add it to the agenda for the following week.
2017-03-04 06332, 2017
LordSputnik
OK
2017-03-04 06358, 2017
LordSputnik
I've got some entity display stuff to push to GitHub, will do that once I can get a clean repository to put it in
2017-03-04 06330, 2017
Leftmost
Okay, cool.
2017-03-04 06357, 2017
nupurbaghel has left the channel
2017-03-04 06313, 2017
deeptibaghel has left the channel
2017-03-04 06342, 2017
LordSputnik
anything else we should talk about?
2017-03-04 06340, 2017
Leftmost
Nothing I can think of offhand.
2017-03-04 06349, 2017
LordSputnik
OK, me neither for now
2017-03-04 06303, 2017
LordSputnik
Enjoy the rest of your Saturday!
2017-03-04 06314, 2017
Leftmost
Thanks for taking the time to chat with me. :) You too!
2017-03-04 06329, 2017
zas
samj1912: pong
2017-03-04 06330, 2017
samj1912
I wanted to ask about the pending PRs and to finalize a date for 1.4.1 and plans on proceeding with 2.0
2017-03-04 06340, 2017
Mineo has quit
2017-03-04 06333, 2017
arbenina_ has quit
2017-03-04 06346, 2017
alastairp
Freso: probably you mean LB? no Docker in AB yet
2017-03-04 06356, 2017
Freso
Ah, probably, yes. :)
2017-03-04 06312, 2017
alastairp
yes, LB started with copy-paste from other MeB projects, but was heavily influenced by my own opinions
2017-03-04 06322, 2017
xplat has quit
2017-03-04 06316, 2017
colbydray has quit
2017-03-04 06310, 2017
abhishekg5 has quit
2017-03-04 06340, 2017
xplat joined the channel
2017-03-04 06304, 2017
arbenina_ joined the channel
2017-03-04 06345, 2017
samj1912 wishes there was a quicker way to test if your travis config is correct
2017-03-04 06338, 2017
hibiscuskazeneko joined the channel
2017-03-04 06338, 2017
iliekcomputers
alastairp: thank you, that is helpful
2017-03-04 06300, 2017
iliekcomputers
seems like according to that doc, release_name should be in `additional_info`
2017-03-04 06317, 2017
iliekcomputers
I should fix the documentation then.
2017-03-04 06349, 2017
travis-ci joined the channel
2017-03-04 06350, 2017
travis-ci
samj1912/picard#76 (picard-osx - 2bf1152 : Sambhav Kothari): The build has errored.
