And over 100 were solved in the last 3 months I think
antlarr
:D
arbenina_ has quit
samj1912
zas, yes will do
antlarr
zas: done
samj1912
Although I do think moving a cluster to the rhs should call cluster in case there are no albums, or do similarity matching if dropped on top of an album
Will test and see what is possible and not
!m antlarr
BrainzBot
You're doing good work, antlarr!
antlarr
hehe, does that mean that PR 642 will be merged soon? :)
samj1912
Yup :)
Hopefully :p
zas
antlarr: yes, please address last comments.
samj1912: please approve if the changes requested were done on PR 642
samj1912
Yes
Mineo joined the channel
antlarr
done
samj1912
Approved from my side
:)
antlarr
\o/
CallerNo6
<Leo_Verto> "well, pinging the bot and getting an answer is what feels more natural to me :P Freso, what do you think?"
zas WRT to errors such as these I am thinking of adding pylint tests to travis
*formatting errors
will make the job easier :P
antlarr
btw, I enabled some plugins some weeks ago to vim and I already check for pep8 errors before committing, but that line was written some weeks ago :)
I can see there are some documentation errors, btw, like "first sentence has to be in imperative", "end with a point" and be separated by a blank line from the rest of the documentation" and issues like those
should those be fixed too? or documentation "errors" are not so important?
Mineo
can one of you explain to me how pull request 642 relates to picard-1000?
afaict it doesn't touch the info dialog at all
antlarr
magic!
it adds support for orig_metadata.images in albums, so we can show the existing cover -> New cover in the cover art box
it doesn't add that support for the info dialog because the info dialog really needs a refactoring to do that
and in conversations with samj1912, we agreed it's better to do that for 2.0
so instead of "artwork diff for albums" we're getting "front cover artwork diff for albums" for 1.x
like when different tracks have different new front covers, so 2 rows appear, one with "original image -> new image1" and the other with " (empty) -> new image2"
twice a week is our schedule. if you look at the timestamps of the full dumps you can work out when the next ones happen.
(7 days later)
samj1912
antlarr: thats a problem with tracks too, hence the need of refactoring
antlarr
yes, indeed
samj1912
there are even more problems
antlarr
now that I think of it, since the problem appear with tracks too... maybe the diff should be enabled for albums too, so that at least it's consistent :)
samj1912
lets say there was just 1 CA image initially, now if we add an image, the info dialog shows that the previous image was changed to the new image and adds the previews image next to a blank image
antlarr: just add those lines in infodialog, we can refactor the whole code together in 2.0
antlarr
ok
samj1912
also I agree with Mineo's suggestion to use QPixmapCache
sorry for the wasted time :\
Mineo
I think we're really talking about different things here. all I wanted to know was why #642 is supposed to fix picard-1000 if it's implementing something completely unrelated? I'm totally fine with doing other stuff and closing picard-1000 as wontfix or keeping it open or whatnot