potential metadata customer maybe? someone should test de waters
2017-03-19 07806, 2017
Lotheric
~the
2017-03-19 07816, 2017
Gore|home joined the channel
2017-03-19 07847, 2017
G0re has quit
2017-03-19 07810, 2017
hibiscuskazeneko joined the channel
2017-03-19 07828, 2017
JonnyJD has quit
2017-03-19 07826, 2017
jwf
Freso: Yeah, I am going, but it would be cool to see the MusicBrainz folk at a conference sometime. :) Maybe what might be more realistic is going to FOSDEM next year, since I think most of you aren't that far from Brussels.
2017-03-19 07835, 2017
nupurbaghel joined the channel
2017-03-19 07852, 2017
hibiscuskazeneko has quit
2017-03-19 07806, 2017
nupurbaghel_ joined the channel
2017-03-19 07814, 2017
nupurbaghel has quit
2017-03-19 07814, 2017
nupurbaghel_ is now known as nupurbaghel
2017-03-19 07838, 2017
hibiscuskazeneko joined the channel
2017-03-19 07828, 2017
hibiscuskazeneko has quit
2017-03-19 07847, 2017
saifulbkhan joined the channel
2017-03-19 07847, 2017
ruaok
zas: ping
2017-03-19 07804, 2017
ruaok
I agree that the script exiting is the problem at hand. But exec is the right thing to do since it replaces the current process with the new process that gets loaded. in this case, python. it works fine for all the other services that run out of that one image.
2017-03-19 07843, 2017
ruaok
at least the containers is back to restarting, which is an improvement. :)
2017-03-19 07851, 2017
ruaok
thanks for the magic incantation to fix that
2017-03-19 07853, 2017
ruaok writes it down
2017-03-19 07837, 2017
ruaok
now to figure out why it dies silently. :(
2017-03-19 07843, 2017
ruaok
iliekcomputers: any ideas?
2017-03-19 07819, 2017
amanmehta joined the channel
2017-03-19 07806, 2017
nupurbaghel has quit
2017-03-19 07820, 2017
nupurbaghel joined the channel
2017-03-19 07849, 2017
saifulbkhan has quit
2017-03-19 07800, 2017
Mineo joined the channel
2017-03-19 07829, 2017
nupurbaghel has quit
2017-03-19 07857, 2017
nupurbaghel joined the channel
2017-03-19 07837, 2017
Zastai joined the channel
2017-03-19 07807, 2017
antlarr
Mineo: ping
2017-03-19 07812, 2017
Mineo
pong
2017-03-19 07838, 2017
antlarr
I just read your comment on PR 657
2017-03-19 07830, 2017
antlarr
the fixes are somewhat independent, but given the time it usually takes for one PR to get merged, I preferred to join all "cover-art-related" fixes in one PR and not having to fix conflicts and everything
2017-03-19 07831, 2017
zas
ruaok: pooong (in which timezone are you ?? ahahah)
2017-03-19 07846, 2017
antlarr
also, the commits that fix each one are independent
2017-03-19 07823, 2017
antlarr
finally... I've been trying to reproduce your issue, and still couldn't
2017-03-19 07840, 2017
zas
antlarr: having too much code in one PR usually don't help for fast merges ;)
2017-03-19 07853, 2017
antlarr
zas: hehe
2017-03-19 07845, 2017
zas
that said, i would like to merge those fixes for 1.4.1 so i can live with this (not so) fat PR
2017-03-19 07848, 2017
JonnyJD joined the channel
2017-03-19 07854, 2017
zas
Mineo: i think about merging the config option PR too, since it doesn't include any translatable strings and shouldn't impact anything, what do you think ?
2017-03-19 07824, 2017
antlarr
Mineo: about your remaining issue with PICARD-1001, do you see the difference in the coverartbox? or in the infodialog?
Mineo: all I could reproduce with your configuration was http://i.imgur.com/gn27Agu.png, but if you see, the cover art box is ok (I'm having a look at the info dialog now)
2017-03-19 07807, 2017
Mineo
neither shows a difference
2017-03-19 07808, 2017
iliekcomputers
ruaok: did you find out why it's exiting with no logs?
2017-03-19 07818, 2017
iliekcomputers tried but couldn't find anything :/
2017-03-19 07838, 2017
Mineo
antlarr: also, I think you need to save it with that config at least once - there shouldn't be a back image with it
2017-03-19 07810, 2017
ruaok
No, busy drinking 🍺 atm
2017-03-19 07800, 2017
antlarr
Mineo: right, now I don't have any difference
2017-03-19 07802, 2017
iliekcomputers
ha
2017-03-19 07816, 2017
antlarr
so, what's the remaining problem with PICARD-1001 ?
iliekcomputers: be sure to output a message when the script exits (or start)
2017-03-19 07827, 2017
iliekcomputers
zas: both places have messages :/
2017-03-19 07847, 2017
zas
but not to stdout, right ?
2017-03-19 07822, 2017
iliekcomputers
no
2017-03-19 07813, 2017
Mineo
and re PR 657: I haven't looked at the code yet, but the amount of hasattr and getattr calls in it is already scaring me :(
2017-03-19 07837, 2017
zas
Mineo: ahah ;)
2017-03-19 07857, 2017
zas
iliekcomputers: the problem is that if it logs to a file in a container that only exists during the time the command runs... it is pretty pointless. So ensure you can actually see when the script starts and ends in the docker logs command
2017-03-19 07855, 2017
zas
you can get the container id from docker events for fast-dying containers and docker logs <id>
2017-03-19 07856, 2017
zas
also test something is visible in logs in case of syntax error in the script too
2017-03-19 07812, 2017
ruaok
iliekcomputers: let's add some stupid simple stdout logging and see if that improves?
2017-03-19 07836, 2017
iliekcomputers is already on it
2017-03-19 07846, 2017
zas
also, handle signals in your script for clean stop
2017-03-19 07821, 2017
zas
btw, the lack of proper handling of container stop conditions is a real pain for me, since, for example, if i need to reboot system or upgrade docker command, bad things may happen if underlying stuff isn't managing container shutdown properly.
2017-03-19 07836, 2017
antlarr
Mineo: the file is marked as "with pending changes" because file.orig_metadata.images is empty (since the file doesn't have any embeeded image because your options enable "save cover images as separate file"), but file.metadata.images have a cover image, since it's downloaded from the release
2017-03-19 07821, 2017
antlarr
so in file.update(), the state is set to CHANGED
2017-03-19 07811, 2017
antlarr
I'm afraid I don't have time to fix it today (maybe tonight, but I'm not sure), so if you want, tell me how you'd fix (loading file.orig_metadata.images with images from the local files provider when there are no embeeded images?) and I'll try to fix it tomorrow
2017-03-19 07850, 2017
github joined the channel
2017-03-19 07850, 2017
github
[listenbrainz-server] paramsingh opened pull request #150: Add logging to stdout to influx-writer (master...influx-writer/logging) https://git.io/vydGB
2017-03-19 07850, 2017
github has left the channel
2017-03-19 07819, 2017
ruaok
Zas: We really need to create a docker best practices doc for meb.
2017-03-19 07852, 2017
ruaok
I didn't realize that this is what you meant by signals earlier.
2017-03-19 07824, 2017
ruaok
iliekcomputers: thanks for the pr. Will look when I get onto the metro.
